| Message ID | 20171127202700.28697-1-bernd.kuhls@t-online.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [PATCH/next,1/1] package/avahi: configure option pygtk was renamed to pygobject | expand |
Bernd, All, On 2017-11-27 21:27 +0100, Bernd Kuhls spake thusly: > See corresponding commit: > https://github.com/lathiat/avahi/commit/142124dae6f043085aba59fca4657c56b2b23b65 > > Fixes > http://autobuild.buildroot.net/results/1e9/1e974c814ae4236077a869339be1143a9af7e5cd/ > http://autobuild.buildroot.net/results/010/0101b1205aec5a0c9c6509edf3d302aeaa3bd0ca/ > http://autobuild.buildroot.net/results/572/5721634ffa2a4544a82dda08c1fcea331ecdadaf/ > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/avahi/avahi.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk > index b89887b4c7..c8f1af9a9d 100644 > --- a/package/avahi/avahi.mk > +++ b/package/avahi/avahi.mk > @@ -77,7 +77,7 @@ AVAHI_CONF_OPTS = \ > --disable-gtk \ > --disable-gtk3 \ > --disable-gdbm \ > - --disable-pygtk \ > + --disable-pygobject \ This is incorrect, because then this disables the full python support. So, either we do without python-gobject and we remove all the python handling in avahi.mk, or we bump python-gobject and fix the dependency chain. Regards, Yann E. MORIN. > --disable-mono \ > --disable-monodoc \ > --disable-stack-protector \ > -- > 2.11.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, On Tue, Nov 28, 2017 at 02:06:15PM +0100, Yann E. MORIN wrote: > On 2017-11-27 21:27 +0100, Bernd Kuhls spake thusly: > > See corresponding commit: > > https://github.com/lathiat/avahi/commit/142124dae6f043085aba59fca4657c56b2b23b65 > > > > Fixes > > http://autobuild.buildroot.net/results/1e9/1e974c814ae4236077a869339be1143a9af7e5cd/ > > http://autobuild.buildroot.net/results/010/0101b1205aec5a0c9c6509edf3d302aeaa3bd0ca/ > > http://autobuild.buildroot.net/results/572/5721634ffa2a4544a82dda08c1fcea331ecdadaf/ > > > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > > --- > > package/avahi/avahi.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk > > index b89887b4c7..c8f1af9a9d 100644 > > --- a/package/avahi/avahi.mk > > +++ b/package/avahi/avahi.mk > > @@ -77,7 +77,7 @@ AVAHI_CONF_OPTS = \ > > --disable-gtk \ > > --disable-gtk3 \ > > --disable-gdbm \ > > - --disable-pygtk \ > > + --disable-pygobject \ > > This is incorrect, because then this disables the full python support. > > So, either we do without python-gobject and we remove all the python > handling in avahi.mk, or we bump python-gobject and fix the dependency > chain. Newer versions of python-gobject depend on GObject introspection. Buildroot does not currently support introspection. http://lists.busybox.net/pipermail/buildroot/2017-February/184645.html Cross compiling introspection is a painful exercise: http://patchwork.ozlabs.org/patch/828791/ baruch
Baruch, All, On 2017-11-28 15:17 +0200, Baruch Siach spake thusly: > On Tue, Nov 28, 2017 at 02:06:15PM +0100, Yann E. MORIN wrote: > > On 2017-11-27 21:27 +0100, Bernd Kuhls spake thusly: > > > See corresponding commit: > > > https://github.com/lathiat/avahi/commit/142124dae6f043085aba59fca4657c56b2b23b65 > > > > > > Fixes > > > http://autobuild.buildroot.net/results/1e9/1e974c814ae4236077a869339be1143a9af7e5cd/ > > > http://autobuild.buildroot.net/results/010/0101b1205aec5a0c9c6509edf3d302aeaa3bd0ca/ > > > http://autobuild.buildroot.net/results/572/5721634ffa2a4544a82dda08c1fcea331ecdadaf/ > > > > > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > > > --- > > > package/avahi/avahi.mk | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk > > > index b89887b4c7..c8f1af9a9d 100644 > > > --- a/package/avahi/avahi.mk > > > +++ b/package/avahi/avahi.mk > > > @@ -77,7 +77,7 @@ AVAHI_CONF_OPTS = \ > > > --disable-gtk \ > > > --disable-gtk3 \ > > > --disable-gdbm \ > > > - --disable-pygtk \ > > > + --disable-pygobject \ > > > > This is incorrect, because then this disables the full python support. > > > > So, either we do without python-gobject and we remove all the python > > handling in avahi.mk, or we bump python-gobject and fix the dependency > > chain. > > Newer versions of python-gobject depend on GObject introspection. Buildroot > does not currently support introspection. > > http://lists.busybox.net/pipermail/buildroot/2017-February/184645.html So, we'll have to do without python support in avahi... :-/ However, coming back to the original problem. Disabliong pygobject does disable building of avahi-python: Building avahi-python: no (You need python, pygobject and python-dbus!) But it seems that python support might still be enabled: Enable Python: yes But none of the ELF files installed by avahi depend on libpython. That's weird... Bernd, the commit log should explain all this... > Cross compiling introspection is a painful exercise: > http://patchwork.ozlabs.org/patch/828791/ Yep, I'm aware of that effort. This gobject introspection is a real PITA... Regards, Yann E. MORIN.
Hello, On Mon, 27 Nov 2017 21:27:00 +0100, Bernd Kuhls wrote: > See corresponding commit: > https://github.com/lathiat/avahi/commit/142124dae6f043085aba59fca4657c56b2b23b65 > > Fixes > http://autobuild.buildroot.net/results/1e9/1e974c814ae4236077a869339be1143a9af7e5cd/ > http://autobuild.buildroot.net/results/010/0101b1205aec5a0c9c6509edf3d302aeaa3bd0ca/ > http://autobuild.buildroot.net/results/572/5721634ffa2a4544a82dda08c1fcea331ecdadaf/ > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/avahi/avahi.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas
diff --git a/package/avahi/avahi.mk b/package/avahi/avahi.mk index b89887b4c7..c8f1af9a9d 100644 --- a/package/avahi/avahi.mk +++ b/package/avahi/avahi.mk @@ -77,7 +77,7 @@ AVAHI_CONF_OPTS = \ --disable-gtk \ --disable-gtk3 \ --disable-gdbm \ - --disable-pygtk \ + --disable-pygobject \ --disable-mono \ --disable-monodoc \ --disable-stack-protector \
See corresponding commit: https://github.com/lathiat/avahi/commit/142124dae6f043085aba59fca4657c56b2b23b65 Fixes http://autobuild.buildroot.net/results/1e9/1e974c814ae4236077a869339be1143a9af7e5cd/ http://autobuild.buildroot.net/results/010/0101b1205aec5a0c9c6509edf3d302aeaa3bd0ca/ http://autobuild.buildroot.net/results/572/5721634ffa2a4544a82dda08c1fcea331ecdadaf/ Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/avahi/avahi.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)