diff mbox series

[v2] rtl8723bu: new package

Message ID 20171127090119.32215-1-mylene.josserand@free-electrons.com
State Accepted
Headers show
Series [v2] rtl8723bu: new package | expand

Commit Message

Mylene Josserand Nov. 27, 2017, 9:01 a.m. UTC
Add RTL8723BU package to compile the Realtek RTL8723BU Wifi driver.

Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>

---
Changes since v1:
	- Added myself into DEVELOPERS file
	- Removed the loop to install the firmware (not necessary)
	- Updated the installation to remove the hook and use standard
	INSTALL_TARGET_CMDS
---
 DEVELOPERS                       |  3 +++
 package/Config.in                |  1 +
 package/rtl8723bu/Config.in      | 10 ++++++++++
 package/rtl8723bu/rtl8723bu.hash |  2 ++
 package/rtl8723bu/rtl8723bu.mk   | 20 ++++++++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/rtl8723bu/Config.in
 create mode 100644 package/rtl8723bu/rtl8723bu.hash
 create mode 100644 package/rtl8723bu/rtl8723bu.mk

Comments

Jeroen Roovers Nov. 27, 2017, 9:35 a.m. UTC | #1
On 27 November 2017 at 10:01, Mylène Josserand
<mylene.josserand@free-electrons.com> wrote:
> Add RTL8723BU package to compile the Realtek RTL8723BU Wifi driver.

I believe recent versions of the in-kernel rtlwifi driver cover the
RTL8723BU as well. Is there any reason to prefer Realtek's driver? If
there are important differences, then it may be useful to record the
advantages of this driver in the Config.in help section.


Kind regards,
     jer
Mylene Josserand Nov. 27, 2017, 10:04 a.m. UTC | #2
Hello,

Le Mon, 27 Nov 2017 10:35:27 +0100,
Jeroen Roovers <jer@airfi.aero> a écrit :

> On 27 November 2017 at 10:01, Mylène Josserand
> <mylene.josserand@free-electrons.com> wrote:
> > Add RTL8723BU package to compile the Realtek RTL8723BU Wifi
> > driver.  
> 
> I believe recent versions of the in-kernel rtlwifi driver cover the
> RTL8723BU as well. Is there any reason to prefer Realtek's driver? If
> there are important differences, then it may be useful to record the
> advantages of this driver in the Config.in help section.

Yes, I tried this driver and I did not succeed to make it work. I sent
an email on the mailing list "linux-wireless" about that[1]. I still do
not have an answer. It would be nice if it can work with mainline's 
driver.

I tested Realtek's driver and it is working just fine so I thought
to contribute the package, in case it could help others.

I can add it in the help section but maybe, the status of the mainline
driver will change so I do not know.

[1]:
https://www.mail-archive.com/linux-wireless@vger.kernel.org/msg40501.html

Thanks, 
Best regards,

Mylène Josserand
Thomas Petazzoni Dec. 1, 2017, 10:09 p.m. UTC | #3
Hello,

On Mon, 27 Nov 2017 10:01:19 +0100, Mylène Josserand wrote:
> Add RTL8723BU package to compile the Realtek RTL8723BU Wifi driver.
> 
> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
> 
> ---
> Changes since v1:
> 	- Added myself into DEVELOPERS file
> 	- Removed the loop to install the firmware (not necessary)
> 	- Updated the installation to remove the hook and use standard
> 	INSTALL_TARGET_CMDS
> ---
>  DEVELOPERS                       |  3 +++
>  package/Config.in                |  1 +
>  package/rtl8723bu/Config.in      | 10 ++++++++++
>  package/rtl8723bu/rtl8723bu.hash |  2 ++
>  package/rtl8723bu/rtl8723bu.mk   | 20 ++++++++++++++++++++
>  5 files changed, 36 insertions(+)
>  create mode 100644 package/rtl8723bu/Config.in
>  create mode 100644 package/rtl8723bu/rtl8723bu.hash
>  create mode 100644 package/rtl8723bu/rtl8723bu.mk

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 7621f969a0..d3d243e111 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1191,6 +1191,9 @@  N:	Mike Harmony <mike.harmony@snapav.com>
 F:	board/sinovoip/m2-plus/
 F:	configs/bananapi_m2_plus_defconfig
 
+N:	Mylène Josserand <mylene.josserand@free-electrons.com>
+F:	package/rtl8723bu/
+
 N:	Nathan Lynch <ntl@pobox.com>
 F:	package/chrony/
 
diff --git a/package/Config.in b/package/Config.in
index fe5ccc434e..9d5a031e50 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -482,6 +482,7 @@  endmenu
 	source "package/rs485conf/Config.in"
 	source "package/rtl8188eu/Config.in"
 	source "package/rtl8723bs/Config.in"
+	source "package/rtl8723bu/Config.in"
 	source "package/rtl8821au/Config.in"
 	source "package/sane-backends/Config.in"
 	source "package/sdparm/Config.in"
diff --git a/package/rtl8723bu/Config.in b/package/rtl8723bu/Config.in
new file mode 100644
index 0000000000..266a794a7d
--- /dev/null
+++ b/package/rtl8723bu/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_RTL8723BU
+	bool "rtl8723bu"
+	depends on BR2_LINUX_KERNEL
+	help
+	  rtl8723bu wifi driver
+
+	  https://github.com/lwfinger/rtl8723bu
+
+comment "rtl8723bu needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
diff --git a/package/rtl8723bu/rtl8723bu.hash b/package/rtl8723bu/rtl8723bu.hash
new file mode 100644
index 0000000000..ef4eddaa63
--- /dev/null
+++ b/package/rtl8723bu/rtl8723bu.hash
@@ -0,0 +1,2 @@ 
+# Locally computed
+sha256 da04cffc306d9738abdc67d234b8948db6ca97ed77760c68d99d18817839a513 rtl8723bu-b922079a090dcaad58179d478442ff97f18521c9.tar.gz
diff --git a/package/rtl8723bu/rtl8723bu.mk b/package/rtl8723bu/rtl8723bu.mk
new file mode 100644
index 0000000000..942b13bbf6
--- /dev/null
+++ b/package/rtl8723bu/rtl8723bu.mk
@@ -0,0 +1,20 @@ 
+################################################################################
+#
+# rtl8723bu
+#
+################################################################################
+
+RTL8723BU_VERSION = b922079a090dcaad58179d478442ff97f18521c9
+RTL8723BU_SITE = $(call github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
+RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)
+
+RTL8723BU_MODULE_MAKE_OPTS = \
+	KVER=$(LINUX_VERSION_PROBED) \
+	KSRC=$(LINUX_DIR)
+
+define RTL8723BU_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 644 $(@D)/rtl8723b_fw.bin $(TARGET_DIR)/lib/firmware/rtlwifi/rtl8723b_fw.bin
+endef
+
+$(eval $(kernel-module))
+$(eval $(generic-package))