From patchwork Thu Nov 2 07:00:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waldemar Brodkorb X-Patchwork-Id: 833233 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ySGLp3c42z9sRW for ; Thu, 2 Nov 2017 18:05:22 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0FB42880E2; Thu, 2 Nov 2017 07:05:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SMoUG2h3uMLf; Thu, 2 Nov 2017 07:05:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id A76FB87C09; Thu, 2 Nov 2017 07:05:18 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 5F1BB1C025D for ; Thu, 2 Nov 2017 07:05:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 596C087FBC for ; Thu, 2 Nov 2017 07:05:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yray-uXy9sBG for ; Thu, 2 Nov 2017 07:05:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from helium.openadk.org (helium.openadk.org [89.238.66.15]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 60F0C87FAD for ; Thu, 2 Nov 2017 07:05:13 +0000 (UTC) Received: by helium.openadk.org (Postfix, from userid 1000) id 8050210111; Thu, 2 Nov 2017 08:00:47 +0100 (CET) Date: Thu, 2 Nov 2017 08:00:47 +0100 From: Waldemar Brodkorb To: buildroot@buildroot.org Message-ID: <20171102070046.GA6819@waldemar-brodkorb.de> MIME-Version: 1.0 Content-Disposition: inline X-Operating-System: Linux 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Subject: [Buildroot] [PATCH] uclibc: convert accept4 to use cancel.h macros X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes: http://autobuild.buildroot.net/results/78e033fe9f43845581a5d87b21a8451f67520e44 Signed-off-by: Waldemar Brodkorb Tested-by: Samuel Martin --- ...03-convert-accept4-to-use-cancel.h-macros.patch | 102 +++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 package/uclibc/0003-convert-accept4-to-use-cancel.h-macros.patch diff --git a/package/uclibc/0003-convert-accept4-to-use-cancel.h-macros.patch b/package/uclibc/0003-convert-accept4-to-use-cancel.h-macros.patch new file mode 100644 index 0000000000..178dcde581 --- /dev/null +++ b/package/uclibc/0003-convert-accept4-to-use-cancel.h-macros.patch @@ -0,0 +1,102 @@ +From c7e82668bd23fbdd02ebe1e83ff2bb6877812423 Mon Sep 17 00:00:00 2001 +From: Waldemar Brodkorb +Date: Thu, 2 Nov 2017 02:40:43 +0100 +Subject: [PATCH] convert accept4() to use cancel.h macros + +Signed-off-by: Waldemar Brodkorb +--- + include/sys/socket.h | 1 + + libc/inet/socketcalls.c | 37 +++++++++-------------------------- + libpthread/linuxthreads/wrapsyscall.c | 7 +++++++ + 3 files changed, 17 insertions(+), 28 deletions(-) + +diff --git a/include/sys/socket.h b/include/sys/socket.h +index 63dc4b953..83e1fcaa2 100644 +--- a/include/sys/socket.h ++++ b/include/sys/socket.h +@@ -269,6 +269,7 @@ libc_hidden_proto(accept) + __THROW. */ + extern int accept4 (int __fd, __SOCKADDR_ARG __addr, + socklen_t *__restrict __addr_len, int __flags); ++libc_hidden_proto(accept4) + #endif + + /* Shut down all or part of the connection open on socket FD. +diff --git a/libc/inet/socketcalls.c b/libc/inet/socketcalls.c +index e33d69344..1b92609d0 100644 +--- a/libc/inet/socketcalls.c ++++ b/libc/inet/socketcalls.c +@@ -76,43 +76,24 @@ lt_libc_hidden(accept) + #endif + + #ifdef L_accept4 +-#ifdef __NR_accept4 +-# define __NR___sys_accept4 __NR_accept4 +-static _syscall4(int, __sys_accept4, int, fd, struct sockaddr *, addr, socklen_t *, addrlen, int, flags) +-int accept4(int fd, struct sockaddr *addr, socklen_t * addrlen, int flags) +-{ +- if (SINGLE_THREAD_P) +- return __sys_accept4(fd, addr, addrlen, flags); +-#ifdef __UCLIBC_HAS_THREADS_NATIVE__ +- else { +- int oldtype = LIBC_CANCEL_ASYNC (); +- int result = __sys_accept4(fd, addr, addrlen, flags); +- LIBC_CANCEL_RESET (oldtype); +- return result; +- } +-#endif +-} +-#elif defined(__NR_socketcall) +-int accept4(int fd, struct sockaddr *addr, socklen_t *addrlen, int flags) ++static int __NC(accept4)(int fd, struct sockaddr *addr, socklen_t *addrlen, int flags) + { ++# ifdef __NR_accept4 ++ return INLINE_SYSCALL(accept4, 4, fd, addr, addrlen, flags); ++# elif defined(__NR_socketcall) + unsigned long args[4]; + + args[0] = fd; + args[1] = (unsigned long) addr; + args[2] = (unsigned long) addrlen; + args[3] = flags; +- if (SINGLE_THREAD_P) +- return __socketcall(SYS_ACCEPT4, args); +-#ifdef __UCLIBC_HAS_THREADS_NATIVE__ +- else { +- int oldtype = LIBC_CANCEL_ASYNC (); +- int result = __socketcall(SYS_ACCEPT4, args); +- LIBC_CANCEL_RESET (oldtype); +- return result; +- } ++ ++ return __socketcall(SYS_ACCEPT4, args); + #endif + } +-#endif ++CANCELLABLE_SYSCALL(int, accept4, (int fd, struct sockaddr *addr, socklen_t *addrlen, int flags), ++ (fd, addr, addrlen, flags)) ++lt_libc_hidden(accept4) + #endif + + #ifdef L_bind +diff --git a/libpthread/linuxthreads/wrapsyscall.c b/libpthread/linuxthreads/wrapsyscall.c +index ca046a442..2386bfdef 100644 +--- a/libpthread/linuxthreads/wrapsyscall.c ++++ b/libpthread/linuxthreads/wrapsyscall.c +@@ -192,6 +192,13 @@ CANCELABLE_SYSCALL (int, accept, (int fd, __SOCKADDR_ARG addr, + socklen_t *addr_len), + (fd, addr, addr_len)) + ++#if defined __UCLIBC_LINUX_SPECIFIC__ ++/* accept4(2). */ ++CANCELABLE_SYSCALL (int, accept4, (int fd, __SOCKADDR_ARG addr, ++ socklen_t *addr_len, int flags), ++ (fd, addr, addr_len, flags)) ++#endif ++ + /* connect(2). */ + CANCELABLE_SYSCALL (int, connect, (int fd, __CONST_SOCKADDR_ARG addr, + socklen_t len), +-- +2.11.0 +