diff mbox

[2/2] boot/syslinux: disable syslinux legacy-BIOS for toolchains affected by binutils bug 19615

Message ID 20170704120110.29107-2-romain.naour@smile.fr
State Accepted
Headers show

Commit Message

Romain Naour July 4, 2017, 12:01 p.m. UTC
Since [1] syslinux is build with the target toolchain in order to
properly build with gnu-efi package.
But toolchains built with binutils 2.26 break the syslinux legacy-BIOS
build as reported [2].

Thanks to Benoît Allard for the investigation and the link to the
binutils bug [3].

[1] 6e432d5ecb46959f3c27dbbca48e41512bb40a70
[2] http://lists.busybox.net/pipermail/buildroot/2017-July/196253.html
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=19615

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: Benoît Allard <benoit.allard@greenbone.net>
---
 boot/syslinux/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard July 19, 2017, 12:52 p.m. UTC | #1
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > Since [1] syslinux is build with the target toolchain in order to
 > properly build with gnu-efi package.
 > But toolchains built with binutils 2.26 break the syslinux legacy-BIOS
 > build as reported [2].

 > Thanks to Benoît Allard for the investigation and the link to the
 > binutils bug [3].

 > [1] 6e432d5ecb46959f3c27dbbca48e41512bb40a70
 > [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196253.html
 > [3] https://sourceware.org/bugzilla/show_bug.cgi?id=19615

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>
 > Cc: Benoît Allard <benoit.allard@greenbone.net>

Committed to 2017.05.x, thanks.

I take it that our internal 2.26.1 binutils isn't affected by this?
diff mbox

Patch

diff --git a/boot/syslinux/Config.in b/boot/syslinux/Config.in
index 299a559..da03549 100644
--- a/boot/syslinux/Config.in
+++ b/boot/syslinux/Config.in
@@ -35,6 +35,7 @@  config BR2_TARGET_SYSLINUX_PXELINUX
 
 config BR2_TARGET_SYSLINUX_MBR
 	bool "install mbr"
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615
 	select BR2_TARGET_SYSLINUX_LEGACY_BIOS
 	help
 	  Install the legacy-BIOS 'mbr' image, to boot off a