From patchwork Sat Jul 1 08:24:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 783054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x060G1K7Yz9sNn for ; Sat, 1 Jul 2017 18:25:18 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B25D5885D4; Sat, 1 Jul 2017 08:25:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q+UQiLnThUxu; Sat, 1 Jul 2017 08:25:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id A44DE82146; Sat, 1 Jul 2017 08:25:15 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 71B161C157B for ; Sat, 1 Jul 2017 08:25:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6736686C1D for ; Sat, 1 Jul 2017 08:25:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 228hyoudBBq7 for ; Sat, 1 Jul 2017 08:25:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from exchange.essensium.com (220.77.144.195.ipv4.evonet.be [195.144.77.220]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 5B21184974 for ; Sat, 1 Jul 2017 08:25:13 +0000 (UTC) Received: from vandecaa-laptop.bzh.lan (10.3.7.11) by beleexch01.local.ess-mail.com (10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32; Sat, 1 Jul 2017 10:24:47 +0200 From: "Arnout Vandecappelle (Essensium/Mind)" To: Date: Sat, 1 Jul 2017 10:24:46 +0200 Message-ID: <20170701082446.24664-1-arnout@mind.be> X-Mailer: git-send-email 2.13.1 MIME-Version: 1.0 X-Originating-IP: [10.3.7.11] X-ClientProxiedBy: beleexch01.local.ess-mail.com (10.3.7.8) To beleexch01.local.ess-mail.com (10.3.7.8) Subject: [Buildroot] [PATCH] Makefile: don't run "menuconfig" automatically X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Since forever, we run 'menuconfig' automatically on an unconfigured tree. However, this does not help users that much: - If they read the documentation, they should already know to run make menuconfig first. - If they haven't read the documentation, dropping them in menuconfig isn't very helpful. - It's a likely that the user didn't intend to be in an unconfigured tree (e.g. wrong O= specified), so starting menuconfig (and polluting this wrong O= directory) is not very helpful. - It's possible that the user really doesn't want menuconfig, but instead needs xconfig, or some defconfig, or ... So, instead of trying to guess what the user needs, print an error and let the user decide what to do next. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 387ae248c2..d5f5596795 100644 --- a/Makefile +++ b/Makefile @@ -816,13 +816,12 @@ check-dependencies: else # ifeq ($(BR2_HAVE_DOT_CONFIG),y) -all: menuconfig - # Some subdirectories are also package names. To avoid that "make linux" # on an unconfigured tree produces "Nothing to be done", add an explicit # rule for it. +# Also for 'all' we error out and ask the user to configure first. .PHONY: linux toolchain -linux toolchain: +linux toolchain all: $(error Please configure Buildroot first (e.g. "make menuconfig")) @exit 1