From patchwork Sat Apr 22 17:17:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Duskett X-Patchwork-Id: 753794 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w9K841hMcz9rvt for ; Sun, 23 Apr 2017 03:18:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Hd9fj2/Y"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B52E08ACF8; Sat, 22 Apr 2017 17:18:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TWjLMo5dFKIj; Sat, 22 Apr 2017 17:18:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id B8F6E8ACB5; Sat, 22 Apr 2017 17:18:37 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D7F8F1C2767 for ; Sat, 22 Apr 2017 17:18:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D156425D53 for ; Sat, 22 Apr 2017 17:18:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C8r+DpoYU2eR for ; Sat, 22 Apr 2017 17:18:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by silver.osuosl.org (Postfix) with ESMTPS id 1153526070 for ; Sat, 22 Apr 2017 17:18:19 +0000 (UTC) Received: by mail-qt0-f194.google.com with SMTP id c45so15575449qtb.0 for ; Sat, 22 Apr 2017 10:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/QCuoS6Vs8ONZqPY7tW+ZxG5tMZ3kC3t8vT0DXtZg9c=; b=Hd9fj2/YBmEIXndRYWkoiJZbmVFPSMmNjqEI2bWegHCdr1xtAmutYEN9/TYoamOfbJ +yj7jGLhepL8yIptT3yTHVWmSrqqHzjhxUN3eedqVdtSymmvpTGhl8VfFZPQ4xCYD1rh 8t9iAYxQIjRbsTezXeog5ct91u64eDnC10mgBZ6EPGxiz7U8V8IRr2ihxFU3wyGpu5fr SGfC9oJo2pmHyZMBQdg1EWSIiz8IgtvP5Lz03LyR09dOOBk/T8VgMu21SNELQJ/xgwF1 sojmsGLaetjxWvxHuNW/4XDz1CsJx6gPIH+RbW1ThOpamXPynCGNMS13sdHQ9diwmCMm vJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/QCuoS6Vs8ONZqPY7tW+ZxG5tMZ3kC3t8vT0DXtZg9c=; b=bJOeWkb5EHN3O9jm52k6YXi4h3nM4JyGYoUciBcZiu27MIue0svTRaNPLHgUjhWRQR G62US64DDefAUIuDbxw3I7XXNddq9VGNRDKJS6/gCIW5AyAc0V3TS2fA86RFBAHKreK1 oh32LGXHWTgCN0SNAtbplWL5Caqc9KsRsrxHQjq6xqrxxlgssDsBCIa3Ui4DOXYE2Ver nmvkBnXaEn4NLUKdVAmPSJ+A0YyrjJ1unZT3eW3ER/rBc6/ZfyZMzuDaJatve3AKhlLV l+8Aw/PgCIdi9fDepj7IC3cIXtxjovsuVKtlaGiIY20g7GebaAHl/F6Am9Krr0aRHBIb C78A== X-Gm-Message-State: AN3rC/4gzhGYg5z3xuUMQac45DTte01itr7mtvxkCQkoGK1IpJQnnpbf lwfN7cAXmyNnEA== X-Received: by 10.200.40.200 with SMTP id j8mr19887333qtj.80.1492881498150; Sat, 22 Apr 2017 10:18:18 -0700 (PDT) Received: from aduskett.duskett (24-247-4-207.dhcp.aldl.mi.charter.com. [24.247.4.207]) by smtp.gmail.com with ESMTPSA id t68sm8971015qkc.44.2017.04.22.10.18.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Apr 2017 10:18:17 -0700 (PDT) From: Adam Duskett X-Google-Original-From: Adam Duskett To: buildroot@buildroot.org Date: Sat, 22 Apr 2017 13:17:51 -0400 Message-Id: <20170422171811.1346-5-Adamduskett@outlook.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170422171811.1346-1-Adamduskett@outlook.com> References: <20170422171811.1346-1-Adamduskett@outlook.com> Cc: Adam Duskett Subject: [Buildroot] [PATCH v2 05/25] fix ordering on configs starting with 'd' X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The check-package script when ran gives warnings on ordering issues on all of these Config files. This patch cleans up all warnings related to the ordering in the Config files for packages starting with the letter d in the package directory. The appropriate ordering is: type, default, depends on, select, help See http://nightly.buildroot.org/#_config_files for more information. Signed-off-by: Adam Duskett --- v1 -> v2: - Broke package up into just packages starting with the letter d. package/ding-libs/Config.in | 2 +- package/directfb/Config.in | 6 +++--- package/docker-engine/Config.in | 2 +- package/dos2unix/Config.in | 2 +- package/dovecot/Config.in | 2 +- package/dropwatch/Config.in | 4 ++-- package/dvblast/Config.in | 4 ++-- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/package/ding-libs/Config.in b/package/ding-libs/Config.in index 7af75b7..d397f29 100644 --- a/package/ding-libs/Config.in +++ b/package/ding-libs/Config.in @@ -1,8 +1,8 @@ config BR2_PACKAGE_DING_LIBS bool "ding-libs" + depends on BR2_USE_WCHAR || !BR2_NEEDS_GETTEXT select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE - depends on BR2_USE_WCHAR || !BR2_NEEDS_GETTEXT help The ding-libs packages contain a set of libraries used by the System Security Services Daemon (SSSD) and other diff --git a/package/directfb/Config.in b/package/directfb/Config.in index 6a3d718..e3b53e0 100644 --- a/package/directfb/Config.in +++ b/package/directfb/Config.in @@ -21,9 +21,9 @@ if BR2_PACKAGE_DIRECTFB config BR2_PACKAGE_DIRECTFB_MULTI bool "directfb multi application" - select BR2_PACKAGE_LINUX_FUSION depends on BR2_USE_MMU # madvise() depends on BR2_LINUX_KERNEL + select BR2_PACKAGE_LINUX_FUSION help Enable use of multiple concurrent DirectFB applications @@ -113,8 +113,8 @@ config BR2_PACKAGE_DIRECTFB_SERIALMOUSE config BR2_PACKAGE_DIRECTFB_TSLIB bool "enable touchscreen support" - depends on !BR2_STATIC_LIBS # tslib default y + depends on !BR2_STATIC_LIBS # tslib select BR2_PACKAGE_TSLIB comment "touchscreen support needs a toolchain w/ dynamic library" @@ -130,8 +130,8 @@ config BR2_PACKAGE_DIRECTFB_TIFF config BR2_PACKAGE_DIRECTFB_IMLIB2 bool "enable IMLIB2 support" - select BR2_PACKAGE_IMLIB2 depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_IMLIB2 comment "imlib2 support needs a toolchain w/ dynamic library" depends on BR2_STATIC_LIBS diff --git a/package/docker-engine/Config.in b/package/docker-engine/Config.in index 8cde4a4..caaf639 100644 --- a/package/docker-engine/Config.in +++ b/package/docker-engine/Config.in @@ -13,11 +13,11 @@ if BR2_PACKAGE_DOCKER_ENGINE config BR2_PACKAGE_DOCKER_ENGINE_DAEMON bool "docker daemon" + default y depends on BR2_USE_MMU # docker-containerd select BR2_PACKAGE_DOCKER_CONTAINERD # runtime dependency select BR2_PACKAGE_IPTABLES # runtime dependency select BR2_PACKAGE_SQLITE # runtime dependency - default y help Build the Docker system daemon. If not selected, will build client only. diff --git a/package/dos2unix/Config.in b/package/dos2unix/Config.in index 0a4f5e2..6945f52 100644 --- a/package/dos2unix/Config.in +++ b/package/dos2unix/Config.in @@ -1,7 +1,7 @@ config BR2_PACKAGE_DOS2UNIX - select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE bool "dos2unix" depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE help dos2unix converts text file line endings between CRLF and LF diff --git a/package/dovecot/Config.in b/package/dovecot/Config.in index d1ff7bc..b93e09f 100644 --- a/package/dovecot/Config.in +++ b/package/dovecot/Config.in @@ -17,9 +17,9 @@ if BR2_PACKAGE_DOVECOT config BR2_PACKAGE_DOVECOT_MYSQL bool "mysql support" - select BR2_PACKAGE_MYSQL depends on BR2_INSTALL_LIBSTDCPP # mysql depends on BR2_TOOLCHAIN_HAS_THREADS # mysql + select BR2_PACKAGE_MYSQL help Enable MySQL support. diff --git a/package/dropwatch/Config.in b/package/dropwatch/Config.in index 6f04c85..127b698 100644 --- a/package/dropwatch/Config.in +++ b/package/dropwatch/Config.in @@ -1,11 +1,11 @@ config BR2_PACKAGE_DROPWATCH bool "dropwatch" - select BR2_PACKAGE_BINUTILS depends on !BR2_nios2 # binutils depends on BR2_USE_WCHAR # binutils + depends on BR2_TOOLCHAIN_HAS_THREADS # libnl + select BR2_PACKAGE_BINUTILS select BR2_PACKAGE_READLINE select BR2_PACKAGE_LIBNL - depends on BR2_TOOLCHAIN_HAS_THREADS # libnl help Dropwatch is an interactive utility for monitoring and recording packets that are dropped by the kernel diff --git a/package/dvblast/Config.in b/package/dvblast/Config.in index b7f0c06..c358531 100644 --- a/package/dvblast/Config.in +++ b/package/dvblast/Config.in @@ -1,10 +1,10 @@ config BR2_PACKAGE_DVBLAST bool "dvblast" + depends on !BR2_bfin # libev + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() select BR2_PACKAGE_BITSTREAM select BR2_PACKAGE_LIBEV select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE - depends on !BR2_bfin # libev - depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep() help DVBlast is a simple and powerful MPEG-2/TS demux and streaming application.