From patchwork Sat Apr 22 17:18:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Duskett X-Patchwork-Id: 753812 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w9K9j02tlz9rxl for ; Sun, 23 Apr 2017 03:20:09 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qiEsX4ae"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0EF848ADD1; Sat, 22 Apr 2017 17:20:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QgPHOAqQgiqX; Sat, 22 Apr 2017 17:20:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 6EC518ADCC; Sat, 22 Apr 2017 17:19:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 689501C0346 for ; Sat, 22 Apr 2017 17:18:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5AB4726070 for ; Sat, 22 Apr 2017 17:18:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nT85lmkln-xr for ; Sat, 22 Apr 2017 17:18:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by silver.osuosl.org (Postfix) with ESMTPS id 9CF9025D53 for ; Sat, 22 Apr 2017 17:18:31 +0000 (UTC) Received: by mail-qk0-f196.google.com with SMTP id y63so6628464qkd.3 for ; Sat, 22 Apr 2017 10:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xobC8kFzA37xpJK8maKLFKGXgwV5AtoR/gmkbXKkNAg=; b=qiEsX4aeuldYIpg4UpLde7wIi0VK7dY/7Ijq7bHAD+ZV/lkwEFQdKqG/vaIYhFHe+8 aZ4sIMnADE/7a1LXXjKqO6PzfIZwhqVtRlftrHi1VCNU2SL5RBvSTtTSnEmhrYZDx2GC Apd5n8wWLAB0EzhStVtBZR15zMRhdeSZec9wUKs0gjE9K5rq+2GewaM4QtzSVbE2wS0w 50xUAT3NoLo149QmeYus6sO6fu86F8TOUCV5AiYvpttyn001vYowox4mAs9rG4O07Dqg MBKGtthk32T2fOWG24QO/QuclSPYzvUrrmIJdJaHwI/pVxoD1NSihrDS117oPXtz/Vpd GGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xobC8kFzA37xpJK8maKLFKGXgwV5AtoR/gmkbXKkNAg=; b=lepzO87jwriqwE41pIvZdxV0iQMSSg4GFDWj1tqPxZdJPW7gJKQnWiIUVHl6p2a4Nl PXtOgvCLh+NzQB/70O20A98GRSlwUPt7GxeqSD8/ERQ6i5q4imZOGokjzWVy4e4CMc/7 lGZAhJzqLrvRRfbZ/0onevrhJmLHTkjhkA/RoYkeAT4663tXfLHzGEvNMFAlQuuzDcIx QDOggtCoOEIBWK3jE3J+2lz2xyB4A3Q1XZjANE3i+/9eSyJ2YElAIFzwuD+OZms3Xd3y 5LgArIw/7Zfuzed/A4sZ7r5JAEVmkGF9jwdhXAJ0+G+mwvTvzGImemNQlM4gePO+wHZD 58JA== X-Gm-Message-State: AN3rC/4wWL368I5kGrGSFTiv0wmKQne7gUouilYN5rqTcsvNLVxPXqcp wXfp8QE3+zEboA== X-Received: by 10.55.65.65 with SMTP id o62mr20073854qka.52.1492881510799; Sat, 22 Apr 2017 10:18:30 -0700 (PDT) Received: from aduskett.duskett (24-247-4-207.dhcp.aldl.mi.charter.com. [24.247.4.207]) by smtp.gmail.com with ESMTPSA id t68sm8971015qkc.44.2017.04.22.10.18.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Apr 2017 10:18:30 -0700 (PDT) From: Adam Duskett X-Google-Original-From: Adam Duskett To: buildroot@buildroot.org Date: Sat, 22 Apr 2017 13:18:09 -0400 Message-Id: <20170422171811.1346-23-Adamduskett@outlook.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170422171811.1346-1-Adamduskett@outlook.com> References: <20170422171811.1346-1-Adamduskett@outlook.com> Cc: Adam Duskett Subject: [Buildroot] [PATCH v2 23/25] fix ordering on configs starting with 'w' X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The check-package script when ran gives warnings on ordering issues on all of these Config files. This patch cleans up all warnings related to the ordering in the Config files for packages starting with the letter w in the package directory. The appropriate ordering is: type, default, depends on, select, help See http://nightly.buildroot.org/#_config_files for more information. Signed-off-by: Adam Duskett --- v1 -> v2: - Broke package up into just packages starting with the letter w. package/weston/Config.in | 10 +++++----- package/wireshark/Config.in | 4 ++-- package/wmctrl/Config.in | 6 +++--- package/wpa_supplicant/Config.in | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/package/weston/Config.in b/package/weston/Config.in index b4e198d..454a14d 100644 --- a/package/weston/Config.in +++ b/package/weston/Config.in @@ -5,6 +5,11 @@ comment "weston needs udev and a toolchain w/ locale, threads, dynamic library, config BR2_PACKAGE_WESTON bool "weston" + depends on BR2_ENABLE_LOCALE # libinput + depends on BR2_PACKAGE_HAS_UDEV + depends on !BR2_STATIC_LIBS # wayland + depends on BR2_TOOLCHAIN_HAS_THREADS # wayland + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 select BR2_PACKAGE_WAYLAND select BR2_PACKAGE_WAYLAND_PROTOCOLS select BR2_PACKAGE_LIBXKBCOMMON @@ -14,11 +19,6 @@ config BR2_PACKAGE_WESTON select BR2_PACKAGE_JPEG select BR2_PACKAGE_MTDEV select BR2_PACKAGE_LIBINPUT - depends on BR2_ENABLE_LOCALE # libinput - depends on BR2_PACKAGE_HAS_UDEV - depends on !BR2_STATIC_LIBS # wayland - depends on BR2_TOOLCHAIN_HAS_THREADS # wayland - depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # Runtime dependency select BR2_PACKAGE_XKEYBOARD_CONFIG # Make sure at least one compositor is selected. diff --git a/package/wireshark/Config.in b/package/wireshark/Config.in index c5b5c3e..4d5a215 100644 --- a/package/wireshark/Config.in +++ b/package/wireshark/Config.in @@ -1,10 +1,10 @@ config BR2_PACKAGE_WIRESHARK bool "wireshark" - select BR2_PACKAGE_LIBPCAP - select BR2_PACKAGE_LIBGLIB2 depends on BR2_USE_MMU # fork(), glib2 depends on BR2_USE_WCHAR # glib2 depends on BR2_TOOLCHAIN_HAS_THREADS # glib2 + select BR2_PACKAGE_LIBPCAP + select BR2_PACKAGE_LIBGLIB2 help Network traffic sniffer and protocol decoder. diff --git a/package/wmctrl/Config.in b/package/wmctrl/Config.in index bc09431..37a1f25 100644 --- a/package/wmctrl/Config.in +++ b/package/wmctrl/Config.in @@ -1,12 +1,12 @@ config BR2_PACKAGE_WMCTRL bool "wmctrl" - select BR2_PACKAGE_XLIB_LIBX11 - select BR2_PACKAGE_XLIB_LIBXMU - select BR2_PACKAGE_LIBGLIB2 depends on BR2_PACKAGE_XORG7 depends on BR2_USE_WCHAR # libglib2 depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 depends on BR2_USE_MMU # libglib2 + select BR2_PACKAGE_XLIB_LIBX11 + select BR2_PACKAGE_XLIB_LIBXMU + select BR2_PACKAGE_LIBGLIB2 help Provides command line access to almost all the features defined in the EWMH specification. It can be used, for diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in index 9250a3b..0f62916 100644 --- a/package/wpa_supplicant/Config.in +++ b/package/wpa_supplicant/Config.in @@ -11,8 +11,8 @@ if BR2_PACKAGE_WPA_SUPPLICANT config BR2_PACKAGE_WPA_SUPPLICANT_NL80211 bool "Enable nl80211 support" default y - select BR2_PACKAGE_LIBNL depends on BR2_TOOLCHAIN_HAS_THREADS # libnl + select BR2_PACKAGE_LIBNL help Enable support for nl80211. This is the current wireless API for Linux, supported by all wireless drivers in vanilla @@ -83,8 +83,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_CLI Install wpa_cli command line utility config BR2_PACKAGE_WPA_SUPPLICANT_WPA_CLIENT_SO - depends on !BR2_STATIC_LIBS bool "Install wpa_client shared library" + depends on !BR2_STATIC_LIBS help Install libwpa_client.so.