From patchwork Tue Apr 18 15:55:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phelip Etienne X-Patchwork-Id: 751886 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w6qW354j6z9s65 for ; Wed, 19 Apr 2017 01:56:31 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 571BB30AF9; Tue, 18 Apr 2017 15:56:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YotaB33aPK+Y; Tue, 18 Apr 2017 15:56:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 1B97830B2A; Tue, 18 Apr 2017 15:56:25 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 7051F1C2C9D for ; Tue, 18 Apr 2017 15:56:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3AE1688471 for ; Tue, 18 Apr 2017 15:56:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zWKMTwwngo-Y for ; Tue, 18 Apr 2017 15:56:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by fraxinus.osuosl.org (Postfix) with ESMTPS id DF95D88470 for ; Tue, 18 Apr 2017 15:56:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id D27F39C1C91; Tue, 18 Apr 2017 11:56:01 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id X4dM9SiKxPQZ; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 9F0519C1A16; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4yYGlw9XpFVd; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) Received: from localhost.mtl.sfl (unknown [192.168.49.129]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id 6C86F9C1BC9; Tue, 18 Apr 2017 11:56:00 -0400 (EDT) From: Etienne Phelip To: buildroot@buildroot.org Date: Tue, 18 Apr 2017 11:55:52 -0400 Message-Id: <20170418155554.28732-3-etienne.phelip@savoirfairelinux.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170418155554.28732-1-etienne.phelip@savoirfairelinux.com> References: <20170418155554.28732-1-etienne.phelip@savoirfairelinux.com> Cc: abhimanyu.v@gmail.com, thomas.petazzoni@free-electrons.com, gael.portay@savoirfairelinux.com, Etienne Phelip Subject: [Buildroot] [RFC 2/4] genimage.sh: fix getopts traces X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The first trace is never displayed, the second shows an empty string because OPTARG is not set. To display both traces properly, the optstring of getopts needs to start with a colon. Signed-off-by: Etienne Phelip --- support/scripts/genimage.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/scripts/genimage.sh b/support/scripts/genimage.sh index 6684e73..6f9102c 100755 --- a/support/scripts/genimage.sh +++ b/support/scripts/genimage.sh @@ -10,7 +10,7 @@ GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp" # First argument is BINARIES_DIR, skip it shift -while getopts c: OPT ; do +while getopts :c: OPT ; do case "${OPT}" in c) GENIMAGE_CFG="${OPTARG}";; :) die "option '${OPTARG}' expects a mandatory argument\n";;