| Message ID | 20170331213249.7920-1-romain.naour@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Fri, 31 Mar 2017 23:32:49 +0200, Romain Naour wrote: > Build lensfun.a for static only build. > > Fixes: > http://autobuild.buildroot.net/results/63e/63e7700a242c7c28ede0fe0b6a63db288e73e974/build-end.log > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > --- > package/lensfun/lensfun.mk | 6 ++++++ > 1 file changed, 6 insertions(+) I was a little bit confused at first, because we normally want the static library either in the BR2_STATIC_LIBS or BR2_SHARED_STATIC_LIBS case. But lensfun build system only allows to build either the shared library *OR* the static library, not both, so what you did is I believe the best solution. Therefore: applied, thanks! Best regards, Thomas
diff --git a/package/lensfun/lensfun.mk b/package/lensfun/lensfun.mk index 8e92e59..fa002c7 100644 --- a/package/lensfun/lensfun.mk +++ b/package/lensfun/lensfun.mk @@ -34,6 +34,12 @@ else LENSFUN_CONF_OPTS += -DBUILD_LENSTOOL=OFF endif +ifeq ($(BR2_STATIC_LIBS),y) +LENSFUN_CONF_OPTS += -DBUILD_STATIC=ON +else +LENSFUN_CONF_OPTS += -DBUILD_STATIC=OFF +endif + # Don't install helper scripts (which require python3 and gksudo). # Don't run setup.py on the host. LENSFUN_CONF_OPTS += -DINSTALL_HELPER_SCRIPTS=OFF -DPYTHON=OFF
Build lensfun.a for static only build. Fixes: http://autobuild.buildroot.net/results/63e/63e7700a242c7c28ede0fe0b6a63db288e73e974/build-end.log Signed-off-by: Romain Naour <romain.naour@gmail.com> --- package/lensfun/lensfun.mk | 6 ++++++ 1 file changed, 6 insertions(+)