From patchwork Sat Mar 11 21:26:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 737750 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vgcf10B5Sz9s78 for ; Sun, 12 Mar 2017 08:27:04 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N/a9tkuj"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6351F2F740; Sat, 11 Mar 2017 21:27:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rtlk7faF4xh3; Sat, 11 Mar 2017 21:26:59 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 99F2E2F7ED; Sat, 11 Mar 2017 21:26:59 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3C7ED1C0156 for ; Sat, 11 Mar 2017 21:26:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3820F89B70 for ; Sat, 11 Mar 2017 21:26:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 47oayOoTYd-P for ; Sat, 11 Mar 2017 21:26:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id D85CF89B6C for ; Sat, 11 Mar 2017 21:26:56 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id z63so4216953wmg.2 for ; Sat, 11 Mar 2017 13:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=22hB3+xq7SfmvjqjC91Tes66TxKGEgfzir4esLu/eWk=; b=N/a9tkuj+QYDOv+R6yOaY78cyexh4KaFXXHmHQq61F8qgSsHOrFtIzCWMS/p/j24Kr PgxlE87aVz1/xp9HcnrxFBqvgXkbbGCIkJca6LfUWwLQ/rZOtxOY93H2oVXpdMkkksjd nznV04Tk0+ZPROBQN6WfTztbxegyjn0owenxf0qXRrEqkQw1zqgkjKlgIzXL6YedIesJ 7oVCRbPhUBXORtktO8smGmFA7cpXq3FcPUNpeHR7I+0ERHmi8vZXKo39qPASnl3cgKoD wGI3NlT4gr2a3HLKSQpxfxlG9Dr1mL9+WauVUUHSqSTK4evNblNL+aHX6oWWTFF0y86t 6iIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=22hB3+xq7SfmvjqjC91Tes66TxKGEgfzir4esLu/eWk=; b=P4XE5WPUNupiFrDjiZppolesTmsAeLGn6gx5H4LBIiuPySNoTaqrNuncjfZs48t9FB 3tER5RsrIy7GCM+gGuan3mUaaQuV2Ih+/KzOV7sy/OHy6gUIry4A09WvjjIKdQeKoxkl +xrie+tvcFGh91pjn3WB/9jwIuondP3nMfIdnaXTfdKZjbAz+kF6/3Z2LswQKX5c0U/J sOnGMYHV0BHd7lw9rYtsGWMFHSzEhOLquGo7D8YCVvryBBVNSKdKs2NOgDMFsX+r98q9 HEJTmF7wgEZTY11GFFChgqmynKIDE5FOGegcSMG8U03Z+DnsR8KDmQ2D5vjIjd2yyFEf SmzQ== X-Gm-Message-State: AFeK/H2LrlYEpmhePLbtejCNcx0rEvndnWBSFHqLhj0GcuwdwvEriAR1U6pZGcCuRA3c4g== X-Received: by 10.28.150.136 with SMTP id y130mr4124520wmd.103.1489267615240; Sat, 11 Mar 2017 13:26:55 -0800 (PST) Received: from localhost.localdomain (gam75-1-81-57-22-125.fbx.proxad.net. [81.57.22.125]) by smtp.gmail.com with ESMTPSA id r8sm2742092wrb.33.2017.03.11.13.26.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 13:26:54 -0800 (PST) From: Romain Naour To: buildroot@buildroot.org Date: Sat, 11 Mar 2017 22:26:45 +0100 Message-Id: <20170311212645.11896-1-romain.naour@gmail.com> X-Mailer: git-send-email 2.9.3 Cc: Thomas Petazzoni , Romain Naour Subject: [Buildroot] [PATCH] package/gdb: fix gnulib issue with musl and uClibc toolchains again X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The commit [1] doesn't fix this issue for all cases (it doesn't work when BR2_PACKAGE_GDB_DEBUGGER=y). So, leave the configure script alone and override gl_cv_func_gettimeofday_clobber from GDB_MAKE_ENV. [1] 560334bb2a46a77081a3944d092df7732dfca432 Fixes: http://autobuild.buildroot.net/results/719/719a441421030b79c0aa1bbfb707130f3ac87338 Signed-off-by: Romain Naour Cc: Thomas Petazzoni --- Note: AlpineLinux doesn't build gdbserver "gdb server does not compile with musl" http://git.alpinelinux.org/cgit/aports/tree/main/gdb/APKBUILD --- package/gdb/gdb.mk | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index 606f1f9..c589714 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -67,13 +67,6 @@ GDB_DISABLE_BINUTILS_CONF_OPTS = \ --disable-ld \ --disable-gas -# Starting with gdb 7.11, the bundled gnulib tries to use -# rpl_gettimeofday (gettimeofday replacement) due to the code being -# unable to determine if the replacement function should be used or -# not when cross-compiling with uClibc or musl as C libraries. So use -# gl_cv_func_gettimeofday_clobber=no to not use rpl_gettimeofday, -# assuming musl and uClibc have a properly working gettimeofday -# implementation. GDB_CONF_ENV = \ ac_cv_type_uintptr_t=yes \ gt_cv_func_gettext_libintl=yes \ @@ -83,8 +76,18 @@ GDB_CONF_ENV = \ bash_cv_must_reinstall_sighandlers=no \ bash_cv_func_sigsetjmp=present \ bash_cv_have_mbstate_t=yes \ - gdb_cv_func_sigsetjmp=yes \ - gl_cv_func_gettimeofday_clobber=no + gdb_cv_func_sigsetjmp=yes + +# Starting with gdb 7.11, the bundled gnulib tries to use +# rpl_gettimeofday (gettimeofday replacement) due to the code being +# unable to determine if the replacement function should be used or +# not when cross-compiling with uClibc or musl as C libraries. So use +# gl_cv_func_gettimeofday_clobber=no to not use rpl_gettimeofday, +# assuming musl and uClibc have a properly working gettimeofday +# implementation. +# Add gl_cv_func_gettimeofday_clobber=no to GDB_MAKE_ENV since it's +# lost when calling sub configure scripts. +GDB_MAKE_ENV = gl_cv_func_gettimeofday_clobber=no # The shared only build is not supported by gdb, so enable static build for # build-in libraries with --enable-static.