From patchwork Wed Oct 5 15:01:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Hadjinlian X-Patchwork-Id: 678481 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3spzX637xRz9s9x for ; Thu, 6 Oct 2016 02:01:57 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=hbeCYJyN; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 98D05331C0; Wed, 5 Oct 2016 15:01:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PZp9akrIC7PL; Wed, 5 Oct 2016 15:01:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 4ACD4331C1; Wed, 5 Oct 2016 15:01:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id AA6331CE847 for ; Wed, 5 Oct 2016 15:01:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9BECD331C0 for ; Wed, 5 Oct 2016 15:01:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H+eWSvuFTnRi for ; Wed, 5 Oct 2016 15:01:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by silver.osuosl.org (Postfix) with ESMTPS id 93298331C1 for ; Wed, 5 Oct 2016 15:01:42 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id b184so24999634wma.3 for ; Wed, 05 Oct 2016 08:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=l9NFJwWAkmUnCHfhtpSSlyhGhLqYJER7ngixqPW1fYM=; b=hbeCYJyNdxn+27eyhH2kyY8r6YxJ5CIZ1DKdmClS8biVUUlnCXlhivIUhWuG5AxD3A ibAdPkgE6C8lZf2LWDCdmnXEy9T4eQGAmbqJcOwwKxCOJxfsMzgHrT+ZYZl2JhZWeRCI YXHi1hJv0TNUKCjXc1hc2xwWsJR8mjvqGRwmldCOwPU+5WyZAJMBSJMeqCGNkPiD3eSc npGw0TNRxj7LyBLGzs1rck0GgwvIJ87cgTm7XlxqxW+dDfrIFqPSa3yEGVBE6gi0yCLT 40gcBWIeBkXzCtj/hEZoBZTW/s2z8TBQoW7wtaFoVc0bGj5uH1BJ9xdYrA+flulQo5Mv WKQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=l9NFJwWAkmUnCHfhtpSSlyhGhLqYJER7ngixqPW1fYM=; b=He0uyTPVsdMGMVDogHtaqppx5vDHXsLJnhnYIooQMNSqo9rEtrywlTNhwvn64Qy+AK UN6+BFCBV4PWbJirXgev5nCB7c0cNAptYKVhayPnXVpL/BOPYEN1paRhEI5MaZJCzFR7 xXggAYW3bW0ldpNEABlz8eFhUy4VXq6qC2xHeMEr8prkGsfMe12vK8pqfLRsYeBTGghP szTRH4U5JCLflY4IAZ+jFw76YzhIEyX0DIPf2T1BeJVCRkHH18emBnCTFtyB+P1iMztg g7S82PNmjt+uXXygRXmBnvFKlB+5JPtsU9jCISJBSeS0NuJkE9KIn+nc0Sf5Dxbi4Fq5 wvxQ== X-Gm-Message-State: AA6/9RmqTUzK+wmAiEVY43ZqPZzzaLrxWU/IYtNG4y+71LqhPN0kAG6X1gHUtOAVfqugOA== X-Received: by 10.28.74.21 with SMTP id x21mr21245903wma.16.1475679700524; Wed, 05 Oct 2016 08:01:40 -0700 (PDT) Received: from localhost.localdomain ([88.191.165.76]) by smtp.gmail.com with ESMTPSA id q65sm9979163wmd.24.2016.10.05.08.01.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Oct 2016 08:01:39 -0700 (PDT) From: Maxime Hadjinlian To: buildroot@buildroot.org Date: Wed, 5 Oct 2016 17:01:23 +0200 Message-Id: <20161005150123.6334-1-maxime.hadjinlian@gmail.com> X-Mailer: git-send-email 2.9.3 Subject: [Buildroot] [PATCH v2] fakeroot: fix spurious message "undefined symbol" X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Since the glibc 2.24-3, and this commit: https://sourceware.org/git/?p=glibc.git;a=commit;h=80f87443eed17838fe453f1f5406ccf5d3698c25 fakeroot will print spurious message about symbols not being found. [...] dlsym(acl_get_fd): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_fd dlsym(acl_get_file): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_file dlsym(acl_set_fd): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_set_fd dlsym(acl_set_file): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_set_file dlsym(acl_get_fd): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_fd dlsym(acl_get_file): /usr/lib/libfakeroot/libfakeroot.so: undefined symbol: acl_get_file [...] It doesn't seem to impair the behavior of fakeroot, it's simply annoying for the user. Debian (which is the creator of fakeroot) has a patch which is a workaround: simply don't display the message. Note if you wish to bump fakeroot: A new version is available but the release tarball doesn't include the 'configure' and 'Makefile' pre-generated. This means that if we were to bump, the package would need to run its own 'bootstrap' script which will add dependencies to host-{automake,autoconf,...} which would be annoying (since almost every build runs fakeroot). Signed-off-by: Maxime Hadjinlian --- v1 -> v2: - Rename patch to include ordering - Add SoB on the patch --- package/fakeroot/0001-hide-dlsym-error.patch | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 package/fakeroot/0001-hide-dlsym-error.patch diff --git a/package/fakeroot/0001-hide-dlsym-error.patch b/package/fakeroot/0001-hide-dlsym-error.patch new file mode 100644 index 0000000..2c61fab --- /dev/null +++ b/package/fakeroot/0001-hide-dlsym-error.patch @@ -0,0 +1,34 @@ +Description: Hide error from dlsym() + dlsym(), starting in glibc 2.24 actually reports errors. In our case, + we try to get ACL functions which are not in the glibc. This causes + failures in test suites, so hide those messages for non-debugging + purposes for now. It also makes the build logs annoying to read. +Author: Julian Andres Klode +Origin: vendor +Bug-Debian: https://bugs.debian.org/830912 +Forwarded: no +Last-Update: 2016-08-12 + +Signed-off-by: Maxime Hadjinlian + +--- a/libfakeroot.c ++++ b/libfakeroot.c +@@ -256,10 +256,16 @@ void load_library_symbols(void){ + /* clear dlerror() just in case dlsym() legitimately returns NULL */ + msg = dlerror(); + *(next_wrap[i].doit)=dlsym(get_libc(), next_wrap[i].name); ++ + if ( (msg = dlerror()) != NULL){ +- fprintf (stderr, "dlsym(%s): %s\n", next_wrap[i].name, msg); +-/* abort ();*/ ++#ifdef LIBFAKEROOT_DEBUGGING ++ if (fakeroot_debug) { ++ fprintf (stderr, "dlsym(%s): %s\n", next_wrap[i].name, msg); ++/* abort ();*/ ++ } ++#endif + } ++ + } + } +