From patchwork Fri Sep 23 05:55:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 673823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sgMzB1mQjz9t0p for ; Fri, 23 Sep 2016 15:55:33 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 88B678B361; Fri, 23 Sep 2016 05:55:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8jPBG5cCkFWF; Fri, 23 Sep 2016 05:55:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 4E54A8B35A; Fri, 23 Sep 2016 05:55:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id DBAB21C2C33 for ; Fri, 23 Sep 2016 05:55:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D7D528C0AD for ; Fri, 23 Sep 2016 05:55:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ed+7QgDq7oCP for ; Fri, 23 Sep 2016 05:55:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by whitealder.osuosl.org (Postfix) with ESMTP id D62A68C068 for ; Fri, 23 Sep 2016 05:55:26 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 80A9B4A3; Fri, 23 Sep 2016 07:55:25 +0200 (CEST) Received: from localhost (unknown [89.248.140.12]) by mail.free-electrons.com (Postfix) with ESMTPSA id 31EB01C2; Fri, 23 Sep 2016 07:55:25 +0200 (CEST) Date: Fri, 23 Sep 2016 07:55:24 +0200 From: Thomas Petazzoni To: Lothar Felten Message-ID: <20160923075524.10122519@free-electrons.com> In-Reply-To: References: Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: buildroot Subject: Re: [Buildroot] uboot: building MLO fails X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Hello, On Fri, 23 Sep 2016 00:55:51 +0200, Lothar Felten wrote: > with the current uboot.mk the MLO isn't generated anymore. > > I modified my defconfig (beaglebone_defconfig) to: > BR2_TARGET_UBOOT_FORMAT_CUSTOM=y > BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="spl/u-boot-spl.bin" This looks wrong. The image format is u-boot.img. > BR2_TARGET_UBOOT_SPL=y > BR2_TARGET_UBOOT_SPL_NAME="MLO" > > In uboot.mk $(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME) is added to > UBOOT_BINS but not to UBOOT_MAKE_TARGET, why? However, indeed, MLO is no longer built. This is a fallout from https://git.buildroot.org/buildroot/commit/boot/uboot?id=fad58cefa4a392b52eafe46a773f8cbfb8aadb43. I really think we should do, in order to build both the default images for the selected platforms *and* the additional make targets if any. I tested with this patch, and it generates and installs MLO and u-boot.img properly. Best regards, Thomas diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 7379a4d..81c5169 100644 --- a/boot/uboot/uboot.mk +++ b/boot/uboot/uboot.mk @@ -179,7 +179,7 @@ endif # BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY define UBOOT_BUILD_CMDS $(TARGET_CONFIGURE_OPTS) \ $(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) \ - $(UBOOT_MAKE_TARGET) + all $(UBOOT_MAKE_TARGET) $(if $(BR2_TARGET_UBOOT_FORMAT_SD), $(@D)/tools/mxsboot sd $(@D)/u-boot.sb $(@D)/u-boot.sd) $(if $(BR2_TARGET_UBOOT_FORMAT_NAND),