| Message ID | 20160611103859.31752-1-jaap@jcz.nl |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Sat, 11 Jun 2016 12:38:59 +0200, Jaap Crezee wrote: > Signed-off-by: Jaap Crezee <jaap@jcz.nl> The commit title must always have the form: <package>: <description> > --- > package/lzop/001-host-gcc-6.patch | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 package/lzop/001-host-gcc-6.patch > > diff --git a/package/lzop/001-host-gcc-6.patch b/package/lzop/001-host-gcc-6.patch > new file mode 100644 > index 0000000..852debe > --- /dev/null > +++ b/package/lzop/001-host-gcc-6.patch > @@ -0,0 +1,26 @@ All patches must have a description + Signed-off-by. Could you rework your patch to fix those issues? Thanks, Thomas
Hello, Please keep the Buildroot mailing list in Cc. On Sat, 11 Jun 2016 18:49:37 +0200, Jaap Crezee wrote: > I did exactly as specified by the documentation on buildroot.org. If I would update that > as well (what format?), would you apply that also? Well, the Buildroot documentation explicitly says that patches added to packages should have a description + Signed-off-by: https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches > I could invest the extra time to do that to make the world a better > place :). It would be good :) Thanks, Thomas
diff --git a/package/lzop/001-host-gcc-6.patch b/package/lzop/001-host-gcc-6.patch new file mode 100644 index 0000000..852debe --- /dev/null +++ b/package/lzop/001-host-gcc-6.patch @@ -0,0 +1,26 @@ +--- a/src/miniacc.h.orig 2016-02-10 16:09:23.247315866 +0100 ++++ b/src/miniacc.h 2016-02-10 16:12:14.973297054 +0100 +@@ -4469,12 +4469,12 @@ + #if defined(__MSDOS__) && defined(__TURBOC__) && (__TURBOC__ < 0x0150) + #elif 1 && (ACC_CC_SUNPROC) && !defined(ACCCHK_CFG_PEDANTIC) + #else +- ACCCHK_ASSERT((1 << (8*SIZEOF_INT-1)) < 0) ++ ACCCHK_ASSERT((int)(1u << (8*SIZEOF_INT-1)) < 0) + #endif + ACCCHK_ASSERT((1u << (8*SIZEOF_INT-1)) > 0) + #if 1 && (ACC_CC_SUNPROC) && !defined(ACCCHK_CFG_PEDANTIC) + #else +- ACCCHK_ASSERT((1l << (8*SIZEOF_LONG-1)) < 0) ++ ACCCHK_ASSERT((long)(1ul << (8*SIZEOF_LONG-1)) < 0) + #endif + ACCCHK_ASSERT((1ul << (8*SIZEOF_LONG-1)) > 0) + #if defined(acc_int16e_t) +@@ -4703,7 +4703,7 @@ + #elif 1 && (ACC_CC_LCC || ACC_CC_LCCWIN32) && !defined(ACCCHK_CFG_PEDANTIC) + #elif 1 && (ACC_CC_SUNPROC) && !defined(ACCCHK_CFG_PEDANTIC) + #elif !(ACC_BROKEN_INTEGRAL_PROMOTION) && (SIZEOF_INT > 1) +- ACCCHK_ASSERT( (((unsigned char)128) << (int)(8*sizeof(int)-8)) < 0) ++ ACCCHK_ASSERT( (int)((unsigned int)((unsigned char)128) << (int)(8*sizeof(int)-8)) < 0) + #endif + #if (ACC_CC_BORLANDC && (__BORLANDC__ >= 0x0530) && (__BORLANDC__ < 0x0560)) + # pragma option pop
Signed-off-by: Jaap Crezee <jaap@jcz.nl> --- package/lzop/001-host-gcc-6.patch | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 package/lzop/001-host-gcc-6.patch