From patchwork Tue Oct 13 21:27:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 529921 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 31D67140E40 for ; Wed, 14 Oct 2015 08:27:20 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5EC52A35BE; Tue, 13 Oct 2015 21:27:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vWRt9m5Vl8fP; Tue, 13 Oct 2015 21:27:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id E2B73A369A; Tue, 13 Oct 2015 21:27:17 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E06AB1C1641 for ; Tue, 13 Oct 2015 21:27:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0339F90EA7 for ; Tue, 13 Oct 2015 21:27:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MTYTa4fcVyUM for ; Tue, 13 Oct 2015 21:27:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by whitealder.osuosl.org (Postfix) with ESMTP id 5822988CE5 for ; Tue, 13 Oct 2015 21:27:15 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 8174442D8; Tue, 13 Oct 2015 23:27:14 +0200 (CEST) Received: from localhost (AToulouse-657-1-1010-128.w83-200.abo.wanadoo.fr [83.200.212.128]) by mail.free-electrons.com (Postfix) with ESMTPSA id 3F07622; Tue, 13 Oct 2015 23:27:14 +0200 (CEST) Date: Tue, 13 Oct 2015 23:27:13 +0200 From: Thomas Petazzoni To: Mike Williams Message-ID: <20151013232713.465c1f48@free-electrons.com> In-Reply-To: <1444747538-2996-2-git-send-email-mike@mikebwilliams.com> References: <1444747538-2996-1-git-send-email-mike@mikebwilliams.com> <1444747538-2996-2-git-send-email-mike@mikebwilliams.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: buildroot@busybox.net Subject: Re: [Buildroot] [PATCH] connman: add missing dbus system bus configuration X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Dear Mike Williams, On Tue, 13 Oct 2015 10:45:38 -0400, Mike Williams wrote: > Signed-off-by: Mike Williams > --- > package/connman/connman.mk | 7 +++++++ > 1 file changed, 7 insertions(+) Thanks for the patch. However, I believe it's not the proper way of solving the problem. Can you try the below patch instead: This will make Connman automatically install its D-Bus configuration file in /etc/dbus-1/system.d/. If it works for you, can you send a new version of the patch? For this new version, please include the explanation *inside* the commit log, and not in the cover letter. Thanks a lot! Thomas diff --git a/package/connman/connman.mk b/package/connman/connman.mk index 87d81ce..3b14a80 100644 --- a/package/connman/connman.mk +++ b/package/connman/connman.mk @@ -12,6 +12,7 @@ CONNMAN_INSTALL_STAGING = YES CONNMAN_LICENSE = GPLv2 CONNMAN_LICENSE_FILES = COPYING CONNMAN_CONF_OPTS += \ + --with-dbusconfdir=/etc \ $(if $(BR2_PACKAGE_CONNMAN_DEBUG),--enable-debug,--disable-debug) \ $(if $(BR2_PACKAGE_CONNMAN_ETHERNET),--enable-ethernet,--disable-ethernet) \ $(if $(BR2_PACKAGE_CONNMAN_WIFI),--enable-wifi,--disable-wifi) \