From patchwork Tue Mar 17 15:13:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 451012 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 3C61814019D for ; Wed, 18 Mar 2015 02:13:28 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 79CBCA2BFA; Tue, 17 Mar 2015 15:13:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2vXyN4q-e3xH; Tue, 17 Mar 2015 15:13:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 854B7A29A2; Tue, 17 Mar 2015 15:13:25 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C71341C24B4 for ; Tue, 17 Mar 2015 15:13:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C2FF5A29A2 for ; Tue, 17 Mar 2015 15:13:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pQCkxct0mLbO for ; Tue, 17 Mar 2015 15:13:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by fraxinus.osuosl.org (Postfix) with ESMTP id A5E96A2979 for ; Tue, 17 Mar 2015 15:13:22 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 3692735E; Tue, 17 Mar 2015 16:13:24 +0100 (CET) Received: from localhost (col31-4-88-188-83-94.fbx.proxad.net [88.188.83.94]) by mail.free-electrons.com (Postfix) with ESMTPSA id D557D265; Tue, 17 Mar 2015 16:13:23 +0100 (CET) Date: Tue, 17 Mar 2015 16:13:20 +0100 From: Thomas Petazzoni To: Gustavo Zacarias Message-ID: <20150317161320.50559502@free-electrons.com> In-Reply-To: <55084360.1070405@zacarias.com.ar> References: <20150315221722.3645eb35@free-electrons.com> <20150315221813.173a36e2@free-electrons.com> <5508382D.7080008@zacarias.com.ar> <20150317153028.66788805@free-electrons.com> <55084360.1070405@zacarias.com.ar> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "buildroot@uclibc.org" Subject: Re: [Buildroot] Blackfin Buildroot toolchain issue X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Dear Gustavo Zacarias, On Tue, 17 Mar 2015 12:08:16 -0300, Gustavo Zacarias wrote: > There's this as well: > https://bugs.busybox.net/show_bug.cgi?id=7921 > Which basically boils down to uclibc NPTL requiring TLS. > I'll check for space savings to see if it makes sense for it to even be > an option. I think it might make sense to keep it a blind option so that we don't do --enable-tls on architectures that don't have TLS support at all (if that even exists). I have something like that in one of my branches: commit 2ea50f3887747d6b72d6b133806d8b3ff995fe4a Author: Thomas Petazzoni Date: Wed Mar 11 23:05:00 2015 +0100 gcc: make TLS option a blind option The current BR2_GCC_ENABLE_TLS option can lead users to create a non-working configuration: if they choose uClibc with NPTL and disable TLS support. This is bug #7921. Since TLS support is really an internal thing, it doesn't make a lot of sense to have a visible option for this. Therefore, this commit turns it to a blind option: TLS support is enabled in the compiler if glibc, eglibc or uClibc NPTL are used, and is disabled otherwise. Signed-off-by: Thomas Petazzoni Thomas diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index 1a5281c..120d4d8 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -109,12 +109,9 @@ config BR2_TOOLCHAIN_BUILDROOT_CXX your target system. config BR2_GCC_ENABLE_TLS - bool "Enable compiler tls support" if BR2_TOOLCHAIN_BUILDROOT_UCLIBC + bool default y depends on BR2_PTHREADS_NATIVE || BR2_TOOLCHAIN_BUILDROOT_EGLIBC || BR2_TOOLCHAIN_BUILDROOT_GLIBC - help - Enable the compiler to generate code for accessing - thread local storage variables config BR2_GCC_ENABLE_LTO bool "Enable compiler link-time-optimization support"