From patchwork Fri Nov 15 14:45:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Ruder X-Patchwork-Id: 291587 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id ADD0D2C00C6 for ; Sat, 16 Nov 2013 01:47:13 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DF31493CDC; Fri, 15 Nov 2013 14:47:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9y15c-495DUi; Fri, 15 Nov 2013 14:47:12 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 5D18A941CD; Fri, 15 Nov 2013 14:47:12 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0CF661C1045 for ; Fri, 15 Nov 2013 14:47:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 075818F6CD for ; Fri, 15 Nov 2013 14:47:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hNrr1yx6OXUm for ; Fri, 15 Nov 2013 14:47:09 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ie0-f179.google.com (mail-ie0-f179.google.com [209.85.223.179]) by whitealder.osuosl.org (Postfix) with ESMTPS id 0FB278F4DF for ; Fri, 15 Nov 2013 14:47:08 +0000 (UTC) Received: by mail-ie0-f179.google.com with SMTP id u16so4981888iet.10 for ; Fri, 15 Nov 2013 06:47:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=cvQjq83kOr+d9BFnqR7abQINrM/QMQn4BKl+VnIO6BA=; b=eBOaCHTeP6YfKCotAjYt9BqSxqePD+z0zZ38jEfITG/ndvNSYLP6Csra3+6MAVqUNH N81TBEY9n9jYn7hMOS8dzFxFGG3AojAy0LRvuIEf9E/chcjSOVk9FP4wAcRPOK4vN+im 7jaT81sIBpP6QkFg+gvibTf4Y/Ktk4QUO0vTxwuRtlKaj47/uohvsAyEmkaauBHYvYQk ce46LivMsudluk56lxI7/l+2C5DhbdBz27jPy96o0BGOSeuiM9MFTqNx/jTJeJujvtGy ZZ159hYqKKc0uWdIIKkkRd8kRqhwniOQcPn1LxHMYegvk2+pYM8Zudj/QP0VYGCZJivh YKfQ== X-Gm-Message-State: ALoCoQkmmhs808qVovfvxKFE5Pw7kfSBDycwRimN78C/SCQ0L8bum/MIbnucz7t90hnXp3feXTZR X-Received: by 10.50.152.39 with SMTP id uv7mr4749779igb.13.1384526828349; Fri, 15 Nov 2013 06:47:08 -0800 (PST) Received: from gmail.com (64-198-156-98.ip.mcleodusa.net. [64.198.156.98]) by mx.google.com with ESMTPSA id l7sm3482612igx.2.2013.11.15.06.47.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 15 Nov 2013 06:47:07 -0800 (PST) Date: Fri, 15 Nov 2013 08:45:28 -0600 From: Andrew Ruder To: buildroot@busybox.net Message-ID: <20131115144528.GA1086@gmail.com> References: <20131114225758.GA13765@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131114225758.GA13765@gmail.com> User-Agent: Mutt/1.5.21+155 (d3096e8796e7) (2012-12-30) Subject: Re: [Buildroot] [PATCH] wvstreams: remove tcl dependency support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Simon, I mistakingly left you off the original e-mail. Any chance you could review the sanity of this patch? As best as I can tell, the TCL support is some holdover from an earlier version of wvstreams (I can't find any references to the HAVE_TCL_H and friends in the source code) and never linked properly anyway as wvstreams only looks for tcl 8.3. I only came across it as I am trying to bump tcl and started looking at packages with tcl dependencies and found this one. I actually have a similar patch that fixes it to find/link against tcl 8.4 or tcl 8.6 but that's when I started digging around to see what it actually changed in the source code and never could find anything and went with this patch instead. Thanks, Andy ---------- As far as I can tell enabling tcl support has no affect on the actual library. Furthermore, wvstreams has been checking for/linking against tcl 8.3 which has never been supported in buildroot as far as I can tell (8.4 added in 2005). That being said there is clearly no reason to keep this around. Signed-off-by: Andrew Ruder --- On a side-note, I am testing a few bigger patches to get expect 5.45 and tcl 8.6.1 added/bumped. I haven't done a decent amount of testing, but figured I'd get some of the smaller patches out of the way as I go. package/wvstreams/wvstreams.mk | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk index b4f7d89..41155a7 100644 --- a/package/wvstreams/wvstreams.mk +++ b/package/wvstreams/wvstreams.mk @@ -22,7 +22,8 @@ WVSTREAMS_CONF_OPT += \ --with-openssl \ --with-zlib \ --without-pam \ - --disable-warnings + --disable-warnings \ + --without-tcl # needed for openssl detection when statically linking (as ssl needs lz) WVSTREAMS_CONF_ENV += LIBS=-lz @@ -38,13 +39,6 @@ else WVSTREAMS_CONF_OPT += --without-dbus endif -ifeq ($(BR2_PACKAGE_TCL),y) - WVSTREAMS_DEPENDENCIES += tcl - WVSTREAMS_CONF_OPT += --with-tcl -else - WVSTREAMS_CONF_OPT += --without-tcl -endif - ifeq ($(BR2_PACKAGE_QT),y) WVSTREAMS_DEPENDENCIES += qt WVSTREAMS_CONF_OPT += --with-qt