From patchwork Tue Apr 24 12:05:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 154662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 5EB5BB6F62 for ; Tue, 24 Apr 2012 22:06:10 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B712A101906; Tue, 24 Apr 2012 12:06:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bL0IXwIMvKs5; Tue, 24 Apr 2012 12:06:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 18C591001C9; Tue, 24 Apr 2012 12:06:05 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 47A6D8F78D for ; Tue, 24 Apr 2012 12:06:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 31DDB8B45C for ; Tue, 24 Apr 2012 12:06:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4XYKdq0nyzXb for ; Tue, 24 Apr 2012 12:06:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [88.190.12.23]) by whitealder.osuosl.org (Postfix) with ESMTP id 38D198B411 for ; Tue, 24 Apr 2012 12:06:01 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 168AA1B2; Tue, 24 Apr 2012 14:06:00 +0200 (CEST) Received: from skate (col31-4-88-188-83-94.fbx.proxad.net [88.188.83.94]) by mail.free-electrons.com (Postfix) with ESMTPSA id B014C149 for ; Tue, 24 Apr 2012 14:05:49 +0200 (CEST) Date: Tue, 24 Apr 2012 14:05:48 +0200 From: Thomas Petazzoni To: buildroot@busybox.net Message-ID: <20120424140548.5cf4c706@skate> In-Reply-To: <1335268524-31735-1-git-send-email-bachmann@tofwerk.com> References: <1335268524-31735-1-git-send-email-bachmann@tofwerk.com> Organization: Free Electrons X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.6; x86_64-pc-linux-gnu) Mime-Version: 1.0 Subject: Re: [Buildroot] [PATCH v3] Add new package apr-util X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Hello Rico, Le Tue, 24 Apr 2012 13:55:24 +0200, Rico Bachmann a écrit : > Signed-off-by: Rico Bachmann > --- > v1: Add package apr-util > Add patch to remove check for apr > because check for apr search for ./apr and not for defined folder > v2: Change spaces to tab in *.mk > v3: Add Signed-off-by and comments to package-patch > --- > --- Those two lines with '---' are useless. > diff --git a/package/apr-util/apr-util-1.4.1-remove-checkapr.patch b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch > new file mode 100644 > index 0000000..128a1b0 > --- /dev/null > +++ b/package/apr-util/apr-util-1.4.1-remove-checkapr.patch > @@ -0,0 +1,17 @@ > +Signed-off-by: Rico Bachmann > +--- > +disable the check for APU_FIND_APR because the check only looks into folders > +named apr, and our source-tree is called apr-versionnumber (e.g. apr-1.4.6) > +--- The description should be *before* the Signed-off-by, and not separated by ---. It seems like you misunderstand what the format of a patch should be. Here is an explanation that I hope will clarify things: ------------------------8<------------------- This is the title, should be less than ~80 chars This is a long description that explains what the patch is doing, why, how, and all other details that are useful. This description (and the title above, and the above Signed-off-by line) will be part of the commit log and remain in the Git history. Therefore, it should *not* contain any changelog information about the patch, or other "personal" messages. The title and the description must be separated by one empty line. Signed-off-by: Foo Bar --- This is some text that will *not* be included in the Git history, so it is typically used for the changelog. package/Config.in | 1 + package/apr-util/Config.in | 7 +++++++ .../apr-util/apr-util-1.4.1-remove-checkapr.patch | 17 +++++++++++++++++ package/apr-util/apr-util.mk | 14 ++++++++++++++ 4 files changed, 39 insertions(+), 0 deletions(-) create mode 100644 package/apr-util/Config.in create mode 100644 package/apr-util/apr-util-1.4.1-remove-checkapr.patch create mode 100644 package/apr-util/apr-util.mk ------------------------8<------------------- Regards, Thomas diff --git a/package/Config.in b/package/Config.in index 5ae1c81..805f56a 100644 --- a/package/Config.in +++ b/package/Config.in @@ -375,6 +375,7 @@ endmenu menu "Other" source "package/apr/Config.in" +source "package/apr-util/Config.in" source "package/fftw/Config.in" source "package/libargtable2/Config.in" source "package/argp-standalone/Config.in"