From patchwork Wed Jun 11 23:40:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 358930 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 8FE431400DF for ; Thu, 12 Jun 2014 09:40:31 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C37AB31D29; Wed, 11 Jun 2014 23:40:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8tfJ8r4QNt5g; Wed, 11 Jun 2014 23:40:20 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id F22D230A95; Wed, 11 Jun 2014 23:40:18 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id CDBB61C2DF3 for ; Wed, 11 Jun 2014 23:40:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id C9D948732B for ; Wed, 11 Jun 2014 23:40:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id us7F+5tC4-Ac for ; Wed, 11 Jun 2014 23:40:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by hemlock.osuosl.org (Postfix) with ESMTPS id 07CEF85D19 for ; Wed, 11 Jun 2014 23:40:16 +0000 (UTC) Received: by mail-we0-f177.google.com with SMTP id u56so455404wes.22 for ; Wed, 11 Jun 2014 16:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tkTPK3mLKnGubKD3R32Nm9vZvXagg6Em0b/ZI69aLuI=; b=yzVWA/H4LbDNaZPeTxXRl5e1lphoHtwkzheTL5Ppq2U5aceyXO0igpTT+yVc1tOf4x FY8IpVSc5gqSc+NIZFaYI4MqbVMovW2baHeCLyuwgpjDi1jBIXWWarPJEiaUeUtIvE5L 6SI3wOvOIPf1HlQLT1utLQLjLY8mzAJqYlYgA/dyDJDS7R2K0uwhEsjPRkeIzo5HN+3i DT6D2APLKHCAca1SYPtGbhsOBz1GRzwHZEd2v/v9m5SXii8U7BcAzQh3lmo5IDSSzqMd YhvLExl9L9box1PgR0wGAI2FXhfIVVUxmzTDqVJzBcT9JQSR18uk/XQMSH6bko3nE9T/ dIMA== X-Received: by 10.180.183.131 with SMTP id em3mr1226017wic.56.1402530015204; Wed, 11 Jun 2014 16:40:15 -0700 (PDT) Received: from gourin.bzh.lan (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id u1sm592672wia.16.2014.06.11.16.40.13 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Jun 2014 16:40:14 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Thu, 12 Jun 2014 01:40:08 +0200 Message-Id: <19d4922545f58b8ef5beede8251cf9612aa8fd9e.1402529398.git.yann.morin.1998@free.fr> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: References: Cc: Thomas Petazzoni , Bernd Kuhls , "Yann E. MORIN" Subject: [Buildroot] [PATCH 1/5 RFC] package/eudev: remove the prompt X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: "Yann E. MORIN" The package eudev depends on DEVICE_CREATION_DYNAMIC_EUDEV, and is also selected by DEVICE_CREATION_DYNAMIC_EUDEV. This means that: - eudev is not visible when DEVICE_CREATION_DYNAMIC_EUDEV is not set - eudev is visible but forced when DEVICE_CREATION_DYNAMIC_EUDEV is set As a consequence, eudev is never user-selectable. Since the user already made the decision to use eudev in the /dev management choice, there is no point in showing the eudev package at all in the menuconfig. Just remove the prompt. Also remove the comments, since anyway the user can't do anything about it. Although not strictly required, we anyway keep the dependencies expressed in eudev, to explain where they come from (fork, util-linux...), so it is explicit their duplication in the .dev management choice entry comes from eudev itself. So, update the comments there. Also, move the help text to the /dev macnagement choice, so the user has a chance to look at it! ;-) Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Bernd Kuhls --- package/eudev/Config.in | 30 +++++++++--------------------- system/Config.in | 21 ++++++++++++++++----- 2 files changed, 25 insertions(+), 26 deletions(-) diff --git a/package/eudev/Config.in b/package/eudev/Config.in index 40ff721..b204a90 100644 --- a/package/eudev/Config.in +++ b/package/eudev/Config.in @@ -1,7 +1,13 @@ +# Note: being prompt-less, and selected in the /dev management choice, +# it is not needed to have dependencies on this symbol, since the +# choice entry already have those dependencies. +# However, it seems more logical to have the dependencies listed here, +# so it is easier to uderstand why we have those, and duplicate them in +# the choice entry. + config BR2_PACKAGE_EUDEV - bool "eudev" + bool depends on !BR2_avr32 # no epoll_create1 - depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV depends on BR2_USE_MMU # uses fork() depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux @@ -10,14 +16,6 @@ config BR2_PACKAGE_EUDEV select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_KMOD - help - Userspace device daemon. This is a standalone version, - independent of systemd. It is a fork maintained by Gentoo. - - eudev requires a Linux kernel >= 2.6.34: it relies on devtmpfs - and inotify. - - http://github.com/gentoo/eudev/ if BR2_PACKAGE_EUDEV @@ -25,18 +23,8 @@ config BR2_PACKAGE_PROVIDES_UDEV default "eudev" config BR2_PACKAGE_EUDEV_RULES_GEN - bool "enable rules generator" + bool "eudev rules generator" help Enable persistent rules generator endif - -comment "eudev needs eudev /dev management" - depends on !BR2_avr32 - depends on BR2_USE_MMU - depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV - -comment "eudev needs a toolchain w/ largefile, wchar, dynamic library" - depends on !BR2_avr32 - depends on BR2_USE_MMU - depends on !BR2_LARGEFILE || !BR2_USE_WCHAR || BR2_PREFER_STATIC_LIB diff --git a/system/Config.in b/system/Config.in index 53bca53..2305de2 100644 --- a/system/Config.in +++ b/system/Config.in @@ -124,12 +124,23 @@ config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV bool "Dynamic using eudev" - depends on !BR2_avr32 # eudev - depends on BR2_LARGEFILE - depends on BR2_USE_WCHAR - depends on !BR2_PREFER_STATIC_LIB - depends on BR2_USE_MMU # eudev + depends on !BR2_avr32 # eudev (no epoll_create1) + depends on BR2_USE_MMU # eudev (fork) + depends on BR2_LARGEFILE # eudev (util-linux) + depends on BR2_USE_WCHAR # eudev (util-linux) + depends on !BR2_PREFER_STATIC_LIB # eudev select BR2_PACKAGE_EUDEV + help + Userspace device daemon. This is a standalone version, + independent of systemd. It is a fork maintained by Gentoo. + + eudev requires a Linux kernel >= 2.6.34: it relies on devtmpfs + and inotify. + + You can further configure systemd in: + Target packages --> Hardware handling + + http://github.com/gentoo/eudev/ comment "eudev needs a toolchain w/ largefile, wchar, dynamic library" depends on !BR2_avr32 # eudev