diff mbox series

[v2] configs/rock_pi_n8: new defconfig

Message ID 1594986634-10056-1-git-send-email-sunil@amarulasolutions.com
State Accepted
Headers show
Series [v2] configs/rock_pi_n8: new defconfig | expand

Commit Message

Suniel Mahesh July 17, 2020, 11:50 a.m. UTC 
Add initial support for RK3288 SOM based radxa rockpi-n8
target with below features:

	- Custom U-Boot 2020.07-rc4
	  https://github.com/amarula/u-boot-amarula.git
	  commit: "ba120841bf40ebaed049d64bb4f980083a1cf6b7"
	- Custom Linux 5.7.0-rc1
	  https://github.com/amarula/linux-amarula.git
	  commit: "5dcb0132685b07beb82065c5d7521e6c555c55b6"
	- GPT partition layout is being used
	- Default packages from buildroot

Signed-off-by: Suniel Mahesh <sunil@amarulasolutions.com>
---
Changes for v2:
- As suggested by Thomas Pettazonni, replaced custom repo version with
  commit ID for both u-boot and Linux.
- Replaced legacy uImage with zImage
- cleanup's
- Will send a patch with upstream uboot and Linux once the patches are
  merged.
---
 .gitlab-ci.yml                      |  1 +
 DEVELOPERS                          |  2 ++
 board/radxa/rockpi-n8/extlinux.conf |  4 +++
 board/radxa/rockpi-n8/genimage.cfg  | 39 ++++++++++++++++++++++++
 board/radxa/rockpi-n8/post-build.sh |  5 +++
 board/radxa/rockpi-n8/readme.txt    | 61 +++++++++++++++++++++++++++++++++++++
 configs/rock_pi_n8_defconfig        | 46 ++++++++++++++++++++++++++++
 7 files changed, 158 insertions(+)
 create mode 100644 board/radxa/rockpi-n8/extlinux.conf
 create mode 100644 board/radxa/rockpi-n8/genimage.cfg
 create mode 100755 board/radxa/rockpi-n8/post-build.sh
 create mode 100644 board/radxa/rockpi-n8/readme.txt
 create mode 100644 configs/rock_pi_n8_defconfig

Comments

Suniel Mahesh Aug. 3, 2020, 12:32 p.m. UTC | #1 
Hi Thomas and Buildroot Team,

On Fri, Jul 17, 2020 at 5:20 PM Suniel Mahesh <sunil@amarulasolutions.com>
wrote:

> Add initial support for RK3288 SOM based radxa rockpi-n8
> target with below features:
>
>         - Custom U-Boot 2020.07-rc4
>           https://github.com/amarula/u-boot-amarula.git
>           commit: "ba120841bf40ebaed049d64bb4f980083a1cf6b7"
>         - Custom Linux 5.7.0-rc1
>           https://github.com/amarula/linux-amarula.git
>           commit: "5dcb0132685b07beb82065c5d7521e6c555c55b6"
>         - GPT partition layout is being used
>         - Default packages from buildroot
>
> Signed-off-by: Suniel Mahesh <sunil@amarulasolutions.com>
> ---
> Changes for v2:
> - As suggested by Thomas Pettazonni, replaced custom repo version with
>   commit ID for both u-boot and Linux.
> - Replaced legacy uImage with zImage
> - cleanup's
> - Will send a patch with upstream uboot and Linux once the patches are
>   merged.
> ---
>

Can you please review this patch and suggest for any changes required.

Regards
Suniel

 .gitlab-ci.yml                      |  1 +
>  DEVELOPERS                          |  2 ++
>  board/radxa/rockpi-n8/extlinux.conf |  4 +++
>  board/radxa/rockpi-n8/genimage.cfg  | 39 ++++++++++++++++++++++++
>  board/radxa/rockpi-n8/post-build.sh |  5 +++
>  board/radxa/rockpi-n8/readme.txt    | 61
> +++++++++++++++++++++++++++++++++++++
>  configs/rock_pi_n8_defconfig        | 46 ++++++++++++++++++++++++++++
>  7 files changed, 158 insertions(+)
>  create mode 100644 board/radxa/rockpi-n8/extlinux.conf
>  create mode 100644 board/radxa/rockpi-n8/genimage.cfg
>  create mode 100755 board/radxa/rockpi-n8/post-build.sh
>  create mode 100644 board/radxa/rockpi-n8/readme.txt
>  create mode 100644 configs/rock_pi_n8_defconfig
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 673aa8b..6884d43 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -323,6 +323,7 @@ riotboard_defconfig: { extends: .defconfig }
>  roc_pc_rk3399_defconfig: { extends: .defconfig }
>  rock64_defconfig: { extends: .defconfig }
>  rock_pi_4_defconfig: { extends: .defconfig }
> +rock_pi_n8_defconfig: { extends: .defconfig }
>  rock_pi_n10_defconfig: { extends: .defconfig }
>  roseapplepi_defconfig: { extends: .defconfig }
>  s6lx9_microboard_defconfig: { extends: .defconfig }
> diff --git a/DEVELOPERS b/DEVELOPERS
> index f91314a..9cf2ac9 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2418,9 +2418,11 @@ F:       package/powertop/
>  N:     Suniel Mahesh <sunil@amarulasolutions.com>
>  F:     board/firefly/
>  F:     board/radxa/rockpi-4
> +F:     board/radxa/rockpi-n8
>  F:     board/radxa/rockpi-n10
>  F:     configs/roc_pc_rk3399_defconfig
>  F:     configs/rock_pi_4_defconfig
> +F:     configs/rock_pi_n8_defconfig
>  F:     configs/rock_pi_n10_defconfig
>  F:     package/arm-gnu-a-toolchain/
>
> diff --git a/board/radxa/rockpi-n8/extlinux.conf
> b/board/radxa/rockpi-n8/extlinux.conf
> new file mode 100644
> index 0000000..c323fe1
> --- /dev/null
> +++ b/board/radxa/rockpi-n8/extlinux.conf
> @@ -0,0 +1,4 @@
> +label RK3288_ROCKPI_N8 linux
> +  kernel /zImage
> +  devicetree /rk3288-rock-pi-n8.dtb
> +  append console=ttyS2,115200n8 root=/dev/mmcblk0p4 rw rootwait
> diff --git a/board/radxa/rockpi-n8/genimage.cfg
> b/board/radxa/rockpi-n8/genimage.cfg
> new file mode 100644
> index 0000000..88b55de3
> --- /dev/null
> +++ b/board/radxa/rockpi-n8/genimage.cfg
> @@ -0,0 +1,39 @@
> +image boot.vfat {
> +       vfat {
> +               files = {
> +                       "zImage",
> +                       "rk3288-rock-pi-n8.dtb",
> +                       "extlinux"
> +               }
> +       }
> +       size = 16M
> +}
> +
> +image sdcard.img {
> +
> +       hdimage {
> +               gpt = true
> +       }
> +
> +       partition loader1 {
> +               image = "idbloader.img"
> +               offset = 32K
> +       }
> +
> +       partition loader2 {
> +               image = "u-boot-dtb.img"
> +               offset = 8M
> +       }
> +
> +       partition boot {
> +               partition-type = 0xC
> +               bootable = "true"
> +               image = "boot.vfat"
> +               offset = 16M
> +       }
> +
> +       partition rootfs {
> +               partition-type = 0x83
> +               image = "rootfs.ext4"
> +       }
> +}
> diff --git a/board/radxa/rockpi-n8/post-build.sh
> b/board/radxa/rockpi-n8/post-build.sh
> new file mode 100755
> index 0000000..ba29375
> --- /dev/null
> +++ b/board/radxa/rockpi-n8/post-build.sh
> @@ -0,0 +1,5 @@
> +#!/bin/sh
> +
> +BOARD_DIR="$(dirname $0)"
> +
> +install -m 0644 -D $BOARD_DIR/extlinux.conf
> $BINARIES_DIR/extlinux/extlinux.conf
> diff --git a/board/radxa/rockpi-n8/readme.txt
> b/board/radxa/rockpi-n8/readme.txt
> new file mode 100644
> index 0000000..ac83d5c
> --- /dev/null
> +++ b/board/radxa/rockpi-n8/readme.txt
> @@ -0,0 +1,61 @@
> +RADXA ROCKPI-N8
> +================
> +https://wiki.radxa.com/RockpiN8
> +
> +Build:
> +======
> +  $ make rock_pi_n8_defconfig
> +  $ make
> +
> +Files created in output directory
> +=================================
> +
> +output/images
> +.
> +├── boot.vfat
> +├── extlinux
> +├── idbloader.img
> +├── rk3288-rock-pi-n8.dtb
> +├── rootfs.ext2
> +├── rootfs.ext4 -> rootfs.ext2
> +├── rootfs.tar
> +├── sdcard.img
> +├── u-boot.bin
> +├── u-boot-dtb.bin
> +├── u-boot-dtb.img
> +└── zImage
> +
> +Creating bootable SD card:
> +==========================
> +
> +Simply invoke (as root)
> +
> +sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
> +
> +Where X is your SD card device.
> +
> +Booting:
> +========
> +
> +Serial console:
> +---------------
> +RockPi-N8 has a 40-pin GPIO header. The pin layout is as follows:
> +
> +pin 6:  gnd
> +pin 8:  tx
> +pin 10: rx
> +
> +Baudrate for this board is 115200.
> +
> +The boot order on rockpi-n8 is emmc, sd. If emmc contains a valid Image,
> the board
> +always boots from emmc. To boot from SD, erase emmc as per the guide:
> +
> +https://wiki.amarulasolutions.com/bsp/setup/rockchip/rk3399_emmc.html
> +
> +Login:
> +------
> +Enter 'root' as login user, and the prompt is ready.
> +
> +wiki link:
> +----------
> +https://wiki.amarulasolutions.com/bsp/rockchip/rk3288/rock-pi-n8.html
> diff --git a/configs/rock_pi_n8_defconfig b/configs/rock_pi_n8_defconfig
> new file mode 100644
> index 0000000..8d6f31d
> --- /dev/null
> +++ b/configs/rock_pi_n8_defconfig
> @@ -0,0 +1,46 @@
> +# Architecture
> +BR2_arm=y
> +BR2_cortex_a17=y
> +BR2_ARM_FPU_NEON_VFPV4=y
> +
> +# Linux headers same as kernel, a 5.7 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_7=y
> +
> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="
> https://github.com/amarula/u-boot-amarula.git"
>
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="ba120841bf40ebaed049d64bb4f980083a1cf6b7"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock-pi-n8-rk3288"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
> +BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="
> https://github.com/amarula/linux-amarula.git"
>
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="5dcb0132685b07beb82065c5d7521e6c555c55b6"
> +BR2_LINUX_KERNEL_USE_DEFCONFIG=y
> +BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-rock-pi-n8"
> +
> +# Filesystem
> +BR2_TARGET_GENERIC_HOSTNAME="rockpi-n8"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to ROCKPI-N8"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="64M"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/radxa/rockpi-n8/genimage.cfg"
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/radxa/rockpi-n8/post-build.sh"
> --
> 2.7.4
>
>
Suniel Mahesh Aug. 10, 2020, 6:41 a.m. UTC | #2 
Hi Thomas and Buildroot Team,

On Mon, Aug 3, 2020 at 6:02 PM Suniel Mahesh <sunil@amarulasolutions.com> wrote:
>
> Hi Thomas and Buildroot Team,
>
> On Fri, Jul 17, 2020 at 5:20 PM Suniel Mahesh <sunil@amarulasolutions.com> wrote:
>>
>> Add initial support for RK3288 SOM based radxa rockpi-n8
>> target with below features:
>>
>>         - Custom U-Boot 2020.07-rc4
>>           https://github.com/amarula/u-boot-amarula.git
>>           commit: "ba120841bf40ebaed049d64bb4f980083a1cf6b7"
>>         - Custom Linux 5.7.0-rc1
>>           https://github.com/amarula/linux-amarula.git
>>           commit: "5dcb0132685b07beb82065c5d7521e6c555c55b6"
>>         - GPT partition layout is being used
>>         - Default packages from buildroot
>>
>> Signed-off-by: Suniel Mahesh <sunil@amarulasolutions.com>
>> ---
>> Changes for v2:
>> - As suggested by Thomas Pettazonni, replaced custom repo version with
>>   commit ID for both u-boot and Linux.
>> - Replaced legacy uImage with zImage
>> - cleanup's
>> - Will send a patch with upstream uboot and Linux once the patches are
>>   merged.
>> ---
>
>
> Can you please review this patch and suggest for any changes required.
>
> Regards
> Suniel

Can you please review this patch and suggest for any changes required.

Regards
Suniel

>
>>  .gitlab-ci.yml                      |  1 +
>>  DEVELOPERS                          |  2 ++
>>  board/radxa/rockpi-n8/extlinux.conf |  4 +++
>>  board/radxa/rockpi-n8/genimage.cfg  | 39 ++++++++++++++++++++++++
>>  board/radxa/rockpi-n8/post-build.sh |  5 +++
>>  board/radxa/rockpi-n8/readme.txt    | 61 +++++++++++++++++++++++++++++++++++++
>>  configs/rock_pi_n8_defconfig        | 46 ++++++++++++++++++++++++++++
>>  7 files changed, 158 insertions(+)
>>  create mode 100644 board/radxa/rockpi-n8/extlinux.conf
>>  create mode 100644 board/radxa/rockpi-n8/genimage.cfg
>>  create mode 100755 board/radxa/rockpi-n8/post-build.sh
>>  create mode 100644 board/radxa/rockpi-n8/readme.txt
>>  create mode 100644 configs/rock_pi_n8_defconfig
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 673aa8b..6884d43 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -323,6 +323,7 @@ riotboard_defconfig: { extends: .defconfig }
>>  roc_pc_rk3399_defconfig: { extends: .defconfig }
>>  rock64_defconfig: { extends: .defconfig }
>>  rock_pi_4_defconfig: { extends: .defconfig }
>> +rock_pi_n8_defconfig: { extends: .defconfig }
>>  rock_pi_n10_defconfig: { extends: .defconfig }
>>  roseapplepi_defconfig: { extends: .defconfig }
>>  s6lx9_microboard_defconfig: { extends: .defconfig }
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index f91314a..9cf2ac9 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -2418,9 +2418,11 @@ F:       package/powertop/
>>  N:     Suniel Mahesh <sunil@amarulasolutions.com>
>>  F:     board/firefly/
>>  F:     board/radxa/rockpi-4
>> +F:     board/radxa/rockpi-n8
>>  F:     board/radxa/rockpi-n10
>>  F:     configs/roc_pc_rk3399_defconfig
>>  F:     configs/rock_pi_4_defconfig
>> +F:     configs/rock_pi_n8_defconfig
>>  F:     configs/rock_pi_n10_defconfig
>>  F:     package/arm-gnu-a-toolchain/
>>
>> diff --git a/board/radxa/rockpi-n8/extlinux.conf b/board/radxa/rockpi-n8/extlinux.conf
>> new file mode 100644
>> index 0000000..c323fe1
>> --- /dev/null
>> +++ b/board/radxa/rockpi-n8/extlinux.conf
>> @@ -0,0 +1,4 @@
>> +label RK3288_ROCKPI_N8 linux
>> +  kernel /zImage
>> +  devicetree /rk3288-rock-pi-n8.dtb
>> +  append console=ttyS2,115200n8 root=/dev/mmcblk0p4 rw rootwait
>> diff --git a/board/radxa/rockpi-n8/genimage.cfg b/board/radxa/rockpi-n8/genimage.cfg
>> new file mode 100644
>> index 0000000..88b55de3
>> --- /dev/null
>> +++ b/board/radxa/rockpi-n8/genimage.cfg
>> @@ -0,0 +1,39 @@
>> +image boot.vfat {
>> +       vfat {
>> +               files = {
>> +                       "zImage",
>> +                       "rk3288-rock-pi-n8.dtb",
>> +                       "extlinux"
>> +               }
>> +       }
>> +       size = 16M
>> +}
>> +
>> +image sdcard.img {
>> +
>> +       hdimage {
>> +               gpt = true
>> +       }
>> +
>> +       partition loader1 {
>> +               image = "idbloader.img"
>> +               offset = 32K
>> +       }
>> +
>> +       partition loader2 {
>> +               image = "u-boot-dtb.img"
>> +               offset = 8M
>> +       }
>> +
>> +       partition boot {
>> +               partition-type = 0xC
>> +               bootable = "true"
>> +               image = "boot.vfat"
>> +               offset = 16M
>> +       }
>> +
>> +       partition rootfs {
>> +               partition-type = 0x83
>> +               image = "rootfs.ext4"
>> +       }
>> +}
>> diff --git a/board/radxa/rockpi-n8/post-build.sh b/board/radxa/rockpi-n8/post-build.sh
>> new file mode 100755
>> index 0000000..ba29375
>> --- /dev/null
>> +++ b/board/radxa/rockpi-n8/post-build.sh
>> @@ -0,0 +1,5 @@
>> +#!/bin/sh
>> +
>> +BOARD_DIR="$(dirname $0)"
>> +
>> +install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux/extlinux.conf
>> diff --git a/board/radxa/rockpi-n8/readme.txt b/board/radxa/rockpi-n8/readme.txt
>> new file mode 100644
>> index 0000000..ac83d5c
>> --- /dev/null
>> +++ b/board/radxa/rockpi-n8/readme.txt
>> @@ -0,0 +1,61 @@
>> +RADXA ROCKPI-N8
>> +================
>> +https://wiki.radxa.com/RockpiN8
>> +
>> +Build:
>> +======
>> +  $ make rock_pi_n8_defconfig
>> +  $ make
>> +
>> +Files created in output directory
>> +=================================
>> +
>> +output/images
>> +.
>> +├── boot.vfat
>> +├── extlinux
>> +├── idbloader.img
>> +├── rk3288-rock-pi-n8.dtb
>> +├── rootfs.ext2
>> +├── rootfs.ext4 -> rootfs.ext2
>> +├── rootfs.tar
>> +├── sdcard.img
>> +├── u-boot.bin
>> +├── u-boot-dtb.bin
>> +├── u-boot-dtb.img
>> +└── zImage
>> +
>> +Creating bootable SD card:
>> +==========================
>> +
>> +Simply invoke (as root)
>> +
>> +sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
>> +
>> +Where X is your SD card device.
>> +
>> +Booting:
>> +========
>> +
>> +Serial console:
>> +---------------
>> +RockPi-N8 has a 40-pin GPIO header. The pin layout is as follows:
>> +
>> +pin 6:  gnd
>> +pin 8:  tx
>> +pin 10: rx
>> +
>> +Baudrate for this board is 115200.
>> +
>> +The boot order on rockpi-n8 is emmc, sd. If emmc contains a valid Image, the board
>> +always boots from emmc. To boot from SD, erase emmc as per the guide:
>> +
>> +https://wiki.amarulasolutions.com/bsp/setup/rockchip/rk3399_emmc.html
>> +
>> +Login:
>> +------
>> +Enter 'root' as login user, and the prompt is ready.
>> +
>> +wiki link:
>> +----------
>> +https://wiki.amarulasolutions.com/bsp/rockchip/rk3288/rock-pi-n8.html
>> diff --git a/configs/rock_pi_n8_defconfig b/configs/rock_pi_n8_defconfig
>> new file mode 100644
>> index 0000000..8d6f31d
>> --- /dev/null
>> +++ b/configs/rock_pi_n8_defconfig
>> @@ -0,0 +1,46 @@
>> +# Architecture
>> +BR2_arm=y
>> +BR2_cortex_a17=y
>> +BR2_ARM_FPU_NEON_VFPV4=y
>> +
>> +# Linux headers same as kernel, a 5.7 series
>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_7=y
>> +
>> +# Bootloader
>> +BR2_TARGET_UBOOT=y
>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
>> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/amarula/u-boot-amarula.git"
>> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="ba120841bf40ebaed049d64bb4f980083a1cf6b7"
>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock-pi-n8-rk3288"
>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
>> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>> +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
>> +BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y
>> +BR2_TARGET_UBOOT_SPL=y
>> +BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
>> +
>> +# Kernel
>> +BR2_LINUX_KERNEL=y
>> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
>> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/amarula/linux-amarula.git"
>> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="5dcb0132685b07beb82065c5d7521e6c555c55b6"
>> +BR2_LINUX_KERNEL_USE_DEFCONFIG=y
>> +BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-rock-pi-n8"
>> +
>> +# Filesystem
>> +BR2_TARGET_GENERIC_HOSTNAME="rockpi-n8"
>> +BR2_TARGET_GENERIC_ISSUE="Welcome to ROCKPI-N8"
>> +BR2_TARGET_ROOTFS_EXT2=y
>> +BR2_TARGET_ROOTFS_EXT2_4=y
>> +BR2_TARGET_ROOTFS_EXT2_SIZE="64M"
>> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
>> +BR2_PACKAGE_HOST_GENIMAGE=y
>> +BR2_PACKAGE_HOST_MTOOLS=y
>> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/radxa/rockpi-n8/genimage.cfg"
>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/radxa/rockpi-n8/post-build.sh"
>> --
>> 2.7.4
>>
Thomas Petazzoni Aug. 16, 2020, 8:50 p.m. UTC | #3 
Hello,

I have applied to next, after a few changes. See below for some
comments.

On Fri, 17 Jul 2020 17:20:34 +0530
Suniel Mahesh <sunil@amarulasolutions.com> wrote:

> Add initial support for RK3288 SOM based radxa rockpi-n8
> target with below features:
> 
> 	- Custom U-Boot 2020.07-rc4
> 	  https://github.com/amarula/u-boot-amarula.git
> 	  commit: "ba120841bf40ebaed049d64bb4f980083a1cf6b7"
> 	- Custom Linux 5.7.0-rc1
> 	  https://github.com/amarula/linux-amarula.git
> 	  commit: "5dcb0132685b07beb82065c5d7521e6c555c55b6"

Could you do a round of update on the defconfigs you've added recently
and try to use non-rc versions of U-Boot/Linux ? And preferably
upstream U-Boot/Linux versions instead of Amarula ones.

>  .gitlab-ci.yml                      |  1 +

Changing the .gitlab-ci.yml is no longer needed (but it was back when
you created this patch, so this is just FYI).

> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/amarula/linux-amarula.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="5dcb0132685b07beb82065c5d7521e6c555c55b6"
> +BR2_LINUX_KERNEL_USE_DEFCONFIG=y
> +BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-rock-pi-n8"

BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y

was missing here.

> +
> +# Filesystem
> +BR2_TARGET_GENERIC_HOSTNAME="rockpi-n8"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to ROCKPI-N8"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="64M"

This was not needed, our default of 60 MB is fine.

> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y

This was apparently not needed, since you're now using a zImage.

Appplied with those changes. Thanks!

Thomas
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 673aa8b..6884d43 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -323,6 +323,7 @@  riotboard_defconfig: { extends: .defconfig }
 roc_pc_rk3399_defconfig: { extends: .defconfig }
 rock64_defconfig: { extends: .defconfig }
 rock_pi_4_defconfig: { extends: .defconfig }
+rock_pi_n8_defconfig: { extends: .defconfig }
 rock_pi_n10_defconfig: { extends: .defconfig }
 roseapplepi_defconfig: { extends: .defconfig }
 s6lx9_microboard_defconfig: { extends: .defconfig }
diff --git a/DEVELOPERS b/DEVELOPERS
index f91314a..9cf2ac9 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2418,9 +2418,11 @@  F:	package/powertop/
 N:	Suniel Mahesh <sunil@amarulasolutions.com>
 F:	board/firefly/
 F:	board/radxa/rockpi-4
+F:	board/radxa/rockpi-n8
 F:	board/radxa/rockpi-n10
 F:	configs/roc_pc_rk3399_defconfig
 F:	configs/rock_pi_4_defconfig
+F:	configs/rock_pi_n8_defconfig
 F:	configs/rock_pi_n10_defconfig
 F:	package/arm-gnu-a-toolchain/
 
diff --git a/board/radxa/rockpi-n8/extlinux.conf b/board/radxa/rockpi-n8/extlinux.conf
new file mode 100644
index 0000000..c323fe1
--- /dev/null
+++ b/board/radxa/rockpi-n8/extlinux.conf
@@ -0,0 +1,4 @@ 
+label RK3288_ROCKPI_N8 linux
+  kernel /zImage
+  devicetree /rk3288-rock-pi-n8.dtb
+  append console=ttyS2,115200n8 root=/dev/mmcblk0p4 rw rootwait
diff --git a/board/radxa/rockpi-n8/genimage.cfg b/board/radxa/rockpi-n8/genimage.cfg
new file mode 100644
index 0000000..88b55de3
--- /dev/null
+++ b/board/radxa/rockpi-n8/genimage.cfg
@@ -0,0 +1,39 @@ 
+image boot.vfat {
+	vfat {
+		files = {
+			"zImage",
+			"rk3288-rock-pi-n8.dtb",
+			"extlinux"
+		}
+	}
+	size = 16M
+}
+
+image sdcard.img {
+
+	hdimage {
+		gpt = true
+	}
+
+	partition loader1 {
+		image = "idbloader.img"
+		offset = 32K
+	}
+
+	partition loader2 {
+		image = "u-boot-dtb.img"
+		offset = 8M
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 16M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
diff --git a/board/radxa/rockpi-n8/post-build.sh b/board/radxa/rockpi-n8/post-build.sh
new file mode 100755
index 0000000..ba29375
--- /dev/null
+++ b/board/radxa/rockpi-n8/post-build.sh
@@ -0,0 +1,5 @@ 
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux/extlinux.conf
diff --git a/board/radxa/rockpi-n8/readme.txt b/board/radxa/rockpi-n8/readme.txt
new file mode 100644
index 0000000..ac83d5c
--- /dev/null
+++ b/board/radxa/rockpi-n8/readme.txt
@@ -0,0 +1,61 @@ 
+RADXA ROCKPI-N8
+================
+https://wiki.radxa.com/RockpiN8
+
+Build:
+======
+  $ make rock_pi_n8_defconfig
+  $ make
+
+Files created in output directory
+=================================
+
+output/images
+.
+├── boot.vfat
+├── extlinux
+├── idbloader.img
+├── rk3288-rock-pi-n8.dtb
+├── rootfs.ext2
+├── rootfs.ext4 -> rootfs.ext2
+├── rootfs.tar
+├── sdcard.img
+├── u-boot.bin
+├── u-boot-dtb.bin
+├── u-boot-dtb.img
+└── zImage
+
+Creating bootable SD card:
+==========================
+
+Simply invoke (as root)
+
+sudo dd if=output/images/sdcard.img of=/dev/sdX && sync
+
+Where X is your SD card device.
+
+Booting:
+========
+
+Serial console:
+---------------
+RockPi-N8 has a 40-pin GPIO header. The pin layout is as follows:
+
+pin 6:  gnd
+pin 8:  tx
+pin 10: rx
+
+Baudrate for this board is 115200.
+
+The boot order on rockpi-n8 is emmc, sd. If emmc contains a valid Image, the board
+always boots from emmc. To boot from SD, erase emmc as per the guide:
+
+https://wiki.amarulasolutions.com/bsp/setup/rockchip/rk3399_emmc.html
+
+Login:
+------
+Enter 'root' as login user, and the prompt is ready.
+
+wiki link:
+----------
+https://wiki.amarulasolutions.com/bsp/rockchip/rk3288/rock-pi-n8.html
diff --git a/configs/rock_pi_n8_defconfig b/configs/rock_pi_n8_defconfig
new file mode 100644
index 0000000..8d6f31d
--- /dev/null
+++ b/configs/rock_pi_n8_defconfig
@@ -0,0 +1,46 @@ 
+# Architecture
+BR2_arm=y
+BR2_cortex_a17=y
+BR2_ARM_FPU_NEON_VFPV4=y
+
+# Linux headers same as kernel, a 5.7 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_7=y
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/amarula/u-boot-amarula.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="ba120841bf40ebaed049d64bb4f980083a1cf6b7"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="rock-pi-n8-rk3288"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="idbloader.img"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/amarula/linux-amarula.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="5dcb0132685b07beb82065c5d7521e6c555c55b6"
+BR2_LINUX_KERNEL_USE_DEFCONFIG=y
+BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-rock-pi-n8"
+
+# Filesystem
+BR2_TARGET_GENERIC_HOSTNAME="rockpi-n8"
+BR2_TARGET_GENERIC_ISSUE="Welcome to ROCKPI-N8"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="64M"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/radxa/rockpi-n8/genimage.cfg"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/radxa/rockpi-n8/post-build.sh"