From patchwork Tue Nov 26 13:24:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 1201052 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="GPCGATkk"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Ml5800S1z9sP3 for ; Wed, 27 Nov 2019 00:25:15 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1D10488018; Tue, 26 Nov 2019 13:25:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F3mr42+4r47M; Tue, 26 Nov 2019 13:25:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id D005687FC3; Tue, 26 Nov 2019 13:25:11 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3C3F81BF2C8 for ; Tue, 26 Nov 2019 13:25:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3963586CB4 for ; Tue, 26 Nov 2019 13:25:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cF4hhIytetQ2 for ; Tue, 26 Nov 2019 13:25:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by whitealder.osuosl.org (Postfix) with ESMTPS id CB46486C53 for ; Tue, 26 Nov 2019 13:25:08 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id s5so22429481wrw.2 for ; Tue, 26 Nov 2019 05:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id; bh=kDo5cw80k7ddT7qz70dB53wXYT3EmKnwRZHg1nqK1Ug=; b=GPCGATkkzCsWhQS2EKYttEwAaPPV6GtiN64PaeaRLXguVpCWh5uMTr42MHO4qK6Pnt LamDvCi6kmcgAFBAYhQJDFC9K5k0iI9NqJ/7g6elI7AIz0pJgOTC27ctCQNUetguZlaQ jrcQzEhGJuOSsfhv05N2rJAjmOWOhlGPVQBJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kDo5cw80k7ddT7qz70dB53wXYT3EmKnwRZHg1nqK1Ug=; b=MdzBouUk0nranHnJM9rTVmRLQB065ZD0WclpuFHmnvnZMFn4Ca6271B4vmUQeQS0t5 HcyPeLAMpCBd9C2UBNjygWtNKgjlk2ygfBY2Alt6gwSe1Iys5HmTyxEhhZUn+4zB+Iip 7G8Efx9xOWvPz/CM7rqZSo2k07T5KiV8oMNHMEwIXcKAVOOYklV1wsz9vG/RONuWv5Yb 0sCTaIo7mGuKBaN+4UNKRWhg/ePCsRWEnNp9coCyUbAZ3KhZap6b5F3XDNnlhWUSemmP bBWS4brsvgW7Jfj7wslc4OwlhezEbX2L2aLS9L4fnLCOtl3kSa83vizygOe3LRiliZXW jn4g== X-Gm-Message-State: APjAAAXvNBNEqJPaQKKxAn82ar1NefVBze1x341ChX2CUn4k3XKvwGMj MCNB2C1J+BUnqGUW+hd65bkP/j/rGrY= X-Google-Smtp-Source: APXvYqy8o0VlgKMpUzlKXjdDCtFX2aAB4l0p8oBI41Ef2RgqqeqgDpIITZlx0FF27ueGwIkeKMbK+A== X-Received: by 2002:adf:c00a:: with SMTP id z10mr36991527wre.81.1574774706780; Tue, 26 Nov 2019 05:25:06 -0800 (PST) Received: from localhost.localdomain ([89.202.204.147]) by smtp.gmail.com with ESMTPSA id f6sm15119421wrr.15.2019.11.26.05.25.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Nov 2019 05:25:05 -0800 (PST) From: Angelo Compagnucci To: buildroot@buildroot.org Date: Tue, 26 Nov 2019 14:24:58 +0100 Message-Id: <1574774698-17881-1-git-send-email-angelo@amarulasolutions.com> X-Mailer: git-send-email 2.7.4 Subject: [Buildroot] [PATCH v3] package/pkg-kconfig: fix reconfigure for kconfig packages X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci , Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Angelo Compagnucci Commit 4b81badbcc0b25678ac6627548160702731cf393 Currently, calling foo-reconfigure for a kconfig-based package will not re-trigger the configuration (kconfig-wise) step for the package. was supposed to solve this problem and lately we had Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f infra/pkg-kconfig: do not rely on package's .config as a timestamp that introduced the .stamp_dotconfig file. For this reason, to trigger a kconfig package reconfigure is now necessary to remove the .stamp_dotconfig file. Signed-off-by: Angelo Compagnucci --- package/pkg-kconfig.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk index 86d7c14..f1931b8 100644 --- a/package/pkg-kconfig.mk +++ b/package/pkg-kconfig.mk @@ -175,7 +175,7 @@ $$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done $(1)-clean-for-reconfigure: $(1)-clean-kconfig-for-reconfigure $(1)-clean-kconfig-for-reconfigure: - rm -f $$($(2)_DIR)/.stamp_kconfig_fixup_done + rm -f $$($(2)_DIR)/$$($(2)_KCONFIG_STAMP_DOTCONFIG) # Only enable the foo-*config targets when the package is actually enabled. # Note: the variable $(2)_KCONFIG_VAR is not related to the kconfig