diff mbox series

[v4] package/python-modbus-tk: new package

Message ID 1568742691-27792-1-git-send-email-pjtexier@koncepto.io
State Accepted
Headers show
Series [v4] package/python-modbus-tk: new package | expand

Commit Message

Pierre-Jean Texier Sept. 17, 2019, 5:51 p.m. UTC
Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes v3 -> v4:
	- Rebase on top of master

Changes v2 -> v3:
	- Rework _LICENSE (after review of Yegor Yefremov)

Changes v1 -> v2:
	- add missing entry in Config.in

 DEVELOPERS                                     |  1 +
 package/Config.in                              |  1 +
 package/python-modbus-tk/Config.in             |  7 +++++++
 package/python-modbus-tk/python-modbus-tk.hash |  6 ++++++
 package/python-modbus-tk/python-modbus-tk.mk   | 14 ++++++++++++++
 5 files changed, 29 insertions(+)
 create mode 100644 package/python-modbus-tk/Config.in
 create mode 100644 package/python-modbus-tk/python-modbus-tk.hash
 create mode 100644 package/python-modbus-tk/python-modbus-tk.mk

Comments

Yegor Yefremov Oct. 29, 2019, 11:31 a.m. UTC | #1
On Tue, Sep 17, 2019 at 7:51 PM Pierre-Jean Texier <pjtexier@koncepto.io> wrote:
>
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes v3 -> v4:
>         - Rebase on top of master
>
> Changes v2 -> v3:
>         - Rework _LICENSE (after review of Yegor Yefremov)
>
> Changes v1 -> v2:
>         - add missing entry in Config.in
>
>  DEVELOPERS                                     |  1 +
>  package/Config.in                              |  1 +
>  package/python-modbus-tk/Config.in             |  7 +++++++
>  package/python-modbus-tk/python-modbus-tk.hash |  6 ++++++
>  package/python-modbus-tk/python-modbus-tk.mk   | 14 ++++++++++++++
>  5 files changed, 29 insertions(+)
>  create mode 100644 package/python-modbus-tk/Config.in
>  create mode 100644 package/python-modbus-tk/python-modbus-tk.hash
>  create mode 100644 package/python-modbus-tk/python-modbus-tk.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 4467688..a99fdda 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1898,6 +1898,7 @@ F:        package/libarchive/
>  F:     package/libevent/
>  F:     package/libubootenv/
>  F:     package/libxml2/
> +F:     package/python-modbus-tk/
>  F:     package/python-periphery/
>  F:     package/stunnel/
>  F:     package/tree/
> diff --git a/package/Config.in b/package/Config.in
> index ab43543..dc5176c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -951,6 +951,7 @@ menu "External python modules"
>         source "package/python-meld3/Config.in"
>         source "package/python-mimeparse/Config.in"
>         source "package/python-mistune/Config.in"
> +       source "package/python-modbus-tk/Config.in"
>         source "package/python-more-itertools/Config.in"
>         source "package/python-msgpack/Config.in"
>         source "package/python-multidict/Config.in"
> diff --git a/package/python-modbus-tk/Config.in b/package/python-modbus-tk/Config.in
> new file mode 100644
> index 0000000..16d87ff
> --- /dev/null
> +++ b/package/python-modbus-tk/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_MODBUS_TK
> +       bool "python-modbus-tk"
> +       select BR2_PACKAGE_PYTHON_SERIAL # runtime
> +       help
> +         Implementation of modbus protocol in python.
> +
> +         https://github.com/ljean/modbus-tk/
> diff --git a/package/python-modbus-tk/python-modbus-tk.hash b/package/python-modbus-tk/python-modbus-tk.hash
> new file mode 100644
> index 0000000..f4da4e5
> --- /dev/null
> +++ b/package/python-modbus-tk/python-modbus-tk.hash
> @@ -0,0 +1,6 @@
> +# md5, sha256 from https://pypi.org/pypi/modbus-tk/json
> +md5    e268242483b719030656ab6047cebff3  modbus_tk-1.0.0.tar.gz
> +sha256 041a34afec8ef487d9e8c0c20834909c2f43a3ae9a0d007b978686d580e9b873  modbus_tk-1.0.0.tar.gz
> +# Locally computed sha256 checksums
> +sha256 3b6a7f9c478ac1982e86cdadb45eb4788241b95839500eb26839d5053b74a24a  license.txt
> +sha256 aa7ca42152a13db6a27b31944f99851efc3b9ee813912ff21d7d6ceadca62e6f  copying.txt
> diff --git a/package/python-modbus-tk/python-modbus-tk.mk b/package/python-modbus-tk/python-modbus-tk.mk
> new file mode 100644
> index 0000000..3d790e1
> --- /dev/null
> +++ b/package/python-modbus-tk/python-modbus-tk.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-modbus-tk
> +#
> +################################################################################
> +
> +PYTHON_MODBUS_TK_VERSION = 1.0.0

Looks like it can be bumped to 1.1.0 (https://pypi.org/project/modbus_tk/)

Yegor

> +PYTHON_MODBUS_TK_SOURCE = modbus_tk-$(PYTHON_MODBUS_TK_VERSION).tar.gz
> +PYTHON_MODBUS_TK_SITE = https://files.pythonhosted.org/packages/8b/03/50193a66aac4eeccbaecea22044de6f07f4e8bfcb6ec37d724a0bba50f46
> +PYTHON_MODBUS_TK_SETUP_TYPE = setuptools
> +PYTHON_MODBUS_TK_LICENSE = LGPL-2.1-or-later
> +PYTHON_MODBUS_TK_LICENSE_FILES = license.txt copying.txt
> +
> +$(eval $(python-package))
> --
> 2.7.4
>
Thomas Petazzoni April 13, 2020, 12:44 p.m. UTC | #2
Hello,

On Tue, 17 Sep 2019 19:51:31 +0200
Pierre-Jean Texier <pjtexier@koncepto.io> wrote:

> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

I've applied after bumping to 1.1.0, and doing a small fix to the
license information.

> +PYTHON_MODBUS_TK_LICENSE = LGPL-2.1-or-later

I know what you used is the SPDX standard tag, but in Buildroot, for
historical reasons, we use LGPL-2.1+ and not LGPL-2.1-or-later.

Thanks!

Thomas
Pierre-Jean Texier April 13, 2020, 12:48 p.m. UTC | #3
Hello Thomas,

Le 13/04/2020 à 14:44, Thomas Petazzoni a écrit :
> Hello,
> 
> On Tue, 17 Sep 2019 19:51:31 +0200
> Pierre-Jean Texier <pjtexier@koncepto.io> wrote:
> 
>> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> 
> I've applied after bumping to 1.1.0, and doing a small fix to the
> license information.
> 
>> +PYTHON_MODBUS_TK_LICENSE = LGPL-2.1-or-later
> 
> I know what you used is the SPDX standard tag, but in Buildroot, for
> historical reasons, we use LGPL-2.1+ and not LGPL-2.1-or-later.

Yes indeed, thanks for the clarification ;)

Pierre-Jean
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 4467688..a99fdda 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1898,6 +1898,7 @@  F:	package/libarchive/
 F:	package/libevent/
 F:	package/libubootenv/
 F:	package/libxml2/
+F:	package/python-modbus-tk/
 F:	package/python-periphery/
 F:	package/stunnel/
 F:	package/tree/
diff --git a/package/Config.in b/package/Config.in
index ab43543..dc5176c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -951,6 +951,7 @@  menu "External python modules"
 	source "package/python-meld3/Config.in"
 	source "package/python-mimeparse/Config.in"
 	source "package/python-mistune/Config.in"
+	source "package/python-modbus-tk/Config.in"
 	source "package/python-more-itertools/Config.in"
 	source "package/python-msgpack/Config.in"
 	source "package/python-multidict/Config.in"
diff --git a/package/python-modbus-tk/Config.in b/package/python-modbus-tk/Config.in
new file mode 100644
index 0000000..16d87ff
--- /dev/null
+++ b/package/python-modbus-tk/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_PYTHON_MODBUS_TK
+	bool "python-modbus-tk"
+	select BR2_PACKAGE_PYTHON_SERIAL # runtime
+	help
+	  Implementation of modbus protocol in python.
+
+	  https://github.com/ljean/modbus-tk/
diff --git a/package/python-modbus-tk/python-modbus-tk.hash b/package/python-modbus-tk/python-modbus-tk.hash
new file mode 100644
index 0000000..f4da4e5
--- /dev/null
+++ b/package/python-modbus-tk/python-modbus-tk.hash
@@ -0,0 +1,6 @@ 
+# md5, sha256 from https://pypi.org/pypi/modbus-tk/json
+md5	e268242483b719030656ab6047cebff3  modbus_tk-1.0.0.tar.gz
+sha256	041a34afec8ef487d9e8c0c20834909c2f43a3ae9a0d007b978686d580e9b873  modbus_tk-1.0.0.tar.gz
+# Locally computed sha256 checksums
+sha256	3b6a7f9c478ac1982e86cdadb45eb4788241b95839500eb26839d5053b74a24a  license.txt
+sha256	aa7ca42152a13db6a27b31944f99851efc3b9ee813912ff21d7d6ceadca62e6f  copying.txt
diff --git a/package/python-modbus-tk/python-modbus-tk.mk b/package/python-modbus-tk/python-modbus-tk.mk
new file mode 100644
index 0000000..3d790e1
--- /dev/null
+++ b/package/python-modbus-tk/python-modbus-tk.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# python-modbus-tk
+#
+################################################################################
+
+PYTHON_MODBUS_TK_VERSION = 1.0.0
+PYTHON_MODBUS_TK_SOURCE = modbus_tk-$(PYTHON_MODBUS_TK_VERSION).tar.gz
+PYTHON_MODBUS_TK_SITE = https://files.pythonhosted.org/packages/8b/03/50193a66aac4eeccbaecea22044de6f07f4e8bfcb6ec37d724a0bba50f46
+PYTHON_MODBUS_TK_SETUP_TYPE = setuptools
+PYTHON_MODBUS_TK_LICENSE = LGPL-2.1-or-later
+PYTHON_MODBUS_TK_LICENSE_FILES = license.txt copying.txt
+
+$(eval $(python-package))