| Message ID | 1549376201-16547-1-git-send-email-angelo@amarulasolutions.com |
|---|---|
| State | Accepted |
| Commit | 097e85abfca75179a4bd889997ff3d9458af2fb6 |
| Headers | show |
| Series | package/mender: fixing init script naming | expand |
>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes: > The installed systemv script should be name S42mender and not S04mender. You forgot to explain _WHY_, E.G. that mender needs the network to be up before it starts (presumably?)
On Tue, Feb 5, 2019 at 3:26 PM Peter Korsgaard <peter@korsgaard.com> wrote: > > >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes: > > > The installed systemv script should be name S42mender and not S04mender. > > You forgot to explain _WHY_, E.G. that mender needs the network to be up > before it starts (presumably?) It's simply a bug, the init script is already named that way! > > -- > Bye, Peter Korsgaard
>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes: > On Tue, Feb 5, 2019 at 3:26 PM Peter Korsgaard <peter@korsgaard.com> wrote: >> >> >>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes: >> >> > The installed systemv script should be name S42mender and not S04mender. >> >> You forgot to explain _WHY_, E.G. that mender needs the network to be up >> before it starts (presumably?) > It's simply a bug, the init script is already named that way! Ahh, ok - That wasn't clear from the description. Committed with the commit log tweaked, thanks.
diff --git a/package/mender/mender.mk b/package/mender/mender.mk index 0d71938..ae5bcb8 100644 --- a/package/mender/mender.mk +++ b/package/mender/mender.mk @@ -70,8 +70,8 @@ define MENDER_INSTALL_INIT_SYSTEMD endef define MENDER_INSTALL_INIT_SYSV - $(INSTALL) -D -m 755 package/mender/S04mender \ - $(TARGET_DIR)/etc/init.d/S04mender + $(INSTALL) -D -m 755 package/mender/S42mender \ + $(TARGET_DIR)/etc/init.d/S42mender endef $(eval $(golang-package))
The installed systemv script should be name S42mender and not S04mender. Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> --- package/mender/mender.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)