| Message ID | 1520910585-19097-8-git-send-email-ricardo.martincoski@gmail.com |
|---|---|
| State | Accepted |
| Commit | 9324167b8090fa4703703c28e8cefff7fa001d21 |
| Headers | show |
| Series | fix Python code style v3 | expand |
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes: > This script comes from the kernel source, so ignore any code style > warnings for it in order to keep it as close as possible to the original > one, making synchronization between repos easier. > The option --exclude for flake8/pycodestyle is an absolute list and has > a default, so ideally the default values should be added too. > But the use cases for flake8 in the tree are: > - when developing a new script or changing an existing one, the > developer calls flake8 only on that script; > - in the GitLab job, a list of all Python files to be tested is created > and then passed to flake8. > None of these involve calling 'flake8' without parameters, so don't care > about adding the default value. > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> > Cc: Marcus Folkesson <marcus.folkesson@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > Changes v2 -> v3: > - no changes > Changes v1 -> v2: > - instead of tweaking even more the script from the kernel source, > ignore any warnings for it; (suggested by Thomas Petazzoni) > - move the patch after the one adding the GitLab job so I can > reference it in the commit message. Committed, thanks.
diff --git a/.flake8 b/.flake8 index afdb967..7dd7b54 100644 --- a/.flake8 +++ b/.flake8 @@ -1,2 +1,5 @@ [flake8] +exclude= + # copied from the kernel sources + utils/diffconfig max-line-length=132
This script comes from the kernel source, so ignore any code style warnings for it in order to keep it as close as possible to the original one, making synchronization between repos easier. The option --exclude for flake8/pycodestyle is an absolute list and has a default, so ideally the default values should be added too. But the use cases for flake8 in the tree are: - when developing a new script or changing an existing one, the developer calls flake8 only on that script; - in the GitLab job, a list of all Python files to be tested is created and then passed to flake8. None of these involve calling 'flake8' without parameters, so don't care about adding the default value. Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Cc: Marcus Folkesson <marcus.folkesson@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- Changes v2 -> v3: - no changes Changes v1 -> v2: - instead of tweaking even more the script from the kernel source, ignore any warnings for it; (suggested by Thomas Petazzoni) - move the patch after the one adding the GitLab job so I can reference it in the commit message. --- .flake8 | 3 +++ 1 file changed, 3 insertions(+)