| Message ID | 1516356909-18620-9-git-send-email-romain.naour@smile.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add /etc/shells handling | expand |
Romain, All, On 2018-01-19 11:15 +0100, Romain Naour spake thusly: > Commit 4d279697afbf8fb295274784103be2b837113d5e missed one comment > from Yann E. Morin about the double-dollar. > > Signed-off-by: Romain Naour <romain.naour@smile.fr> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/bash/bash.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/bash/bash.mk b/package/bash/bash.mk > index 03f8f28..ab6b43b 100644 > --- a/package/bash/bash.mk > +++ b/package/bash/bash.mk > @@ -46,7 +46,7 @@ define BASH_INSTALL_TARGET_CMDS > $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ > DESTDIR=$(TARGET_DIR) exec_prefix=/ install > rm -f $(TARGET_DIR)/bin/bashbug > - grep -qsE '^/bin/bash' $(TARGET_DIR)/etc/shells \ > + grep -qsE '^/bin/bash$$' $(TARGET_DIR)/etc/shells \ > || echo "/bin/bash" >> $(TARGET_DIR)/etc/shells > endef > > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/bash/bash.mk b/package/bash/bash.mk index 03f8f28..ab6b43b 100644 --- a/package/bash/bash.mk +++ b/package/bash/bash.mk @@ -46,7 +46,7 @@ define BASH_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ DESTDIR=$(TARGET_DIR) exec_prefix=/ install rm -f $(TARGET_DIR)/bin/bashbug - grep -qsE '^/bin/bash' $(TARGET_DIR)/etc/shells \ + grep -qsE '^/bin/bash$$' $(TARGET_DIR)/etc/shells \ || echo "/bin/bash" >> $(TARGET_DIR)/etc/shells endef
Commit 4d279697afbf8fb295274784103be2b837113d5e missed one comment from Yann E. Morin about the double-dollar. Signed-off-by: Romain Naour <romain.naour@smile.fr> --- package/bash/bash.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)