diff mbox series

[1/1] package: remove the default value of the $(PKG)_SOURCE variable

Message ID 1513506292-27032-1-git-send-email-jerzy.m.grzegorek@gmail.com
State Accepted
Headers show
Series [1/1] package: remove the default value of the $(PKG)_SOURCE variable | expand

Commit Message

Jerzy Grzegorek Dec. 17, 2017, 10:24 a.m. UTC
Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
---
 package/pimd/pimd.mk                                   | 1 -
 package/proj/proj.mk                                   | 1 -
 package/traceroute/traceroute.mk                       | 1 -
 3 files changed, 3 deletions(-)

Comments

Thomas Petazzoni Dec. 17, 2017, 11:04 a.m. UTC | #1
Hello,

On Sun, 17 Dec 2017 11:24:52 +0100, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
> ---
>  package/pimd/pimd.mk                                   | 1 -
>  package/proj/proj.mk                                   | 1 -
>  package/traceroute/traceroute.mk                       | 1 -
>  3 files changed, 3 deletions(-)

Applied to master, thanks. In order to avoid such mistakes in the
future, would you be willing to contribute an addition to the
check-package script that detects usage of the default <pkg>_SOURCE
value ?

Thanks!

Thomas
Jerzy Grzegorek Dec. 17, 2017, 11:13 p.m. UTC | #2
Hi Thomas,

> Hello,
>
> On Sun, 17 Dec 2017 11:24:52 +0100, Jerzy Grzegorek wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
>> ---
>>   package/pimd/pimd.mk                                   | 1 -
>>   package/proj/proj.mk                                   | 1 -
>>   package/traceroute/traceroute.mk                       | 1 -
>>   3 files changed, 3 deletions(-)
> Applied to master, thanks. In order to avoid such mistakes in the
> future, would you be willing to contribute an addition to the
> check-package script that detects usage of the default <pkg>_SOURCE
> value ?

Sure, I'll try to do it.

Regards,
Jerzy

>
> Thanks!
>
> Thomas
diff mbox series

Patch

diff --git a/package/pimd/pimd.mk b/package/pimd/pimd.mk
index 21b5e10..7a12f8f 100644
--- a/package/pimd/pimd.mk
+++ b/package/pimd/pimd.mk
@@ -5,7 +5,6 @@ 
 ################################################################################
 
 PIMD_VERSION = 2.3.2
-PIMD_SOURCE = pimd-$(PIMD_VERSION).tar.gz
 PIMD_SITE = https://github.com/troglobit/pimd/releases/download/$(PIMD_VERSION)
 
 PIMD_LICENSE = BSD-3-Clause
diff --git a/package/proj/proj.mk b/package/proj/proj.mk
index 5607dc0..6d029bb 100644
--- a/package/proj/proj.mk
+++ b/package/proj/proj.mk
@@ -5,7 +5,6 @@ 
 ################################################################################
 
 PROJ_VERSION = 4.9.3
-PROJ_SOURCE = proj-$(PROJ_VERSION).tar.gz
 PROJ_SITE = http://download.osgeo.org/proj
 PROJ_LICENSE = MIT
 PROJ_LICENSE_FILES = COPYING
diff --git a/package/traceroute/traceroute.mk b/package/traceroute/traceroute.mk
index 9d74b8f..d01c62d 100644
--- a/package/traceroute/traceroute.mk
+++ b/package/traceroute/traceroute.mk
@@ -5,7 +5,6 @@ 
 ################################################################################
 
 TRACEROUTE_VERSION = 2.1.0
-TRACEROUTE_SOURCE = traceroute-$(TRACEROUTE_VERSION).tar.gz
 TRACEROUTE_SITE = http://downloads.sourceforge.net/traceroute/traceroute/traceroute-$(TRACEROUTE_VERSION)
 
 TRACEROUTE_LICENSE = GPL-2.0+, LGPL-2.1+