From patchwork Wed May 3 19:04:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Bedarkar X-Patchwork-Id: 758182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wJ6zb5kjWz9ryT for ; Thu, 4 May 2017 05:04:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KvTAy2R9"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C5A0E878A8; Wed, 3 May 2017 19:04:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oWJ2LM4orp1V; Wed, 3 May 2017 19:04:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5207F87779; Wed, 3 May 2017 19:04:54 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4548B1C049C for ; Wed, 3 May 2017 19:04:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3D331885D0 for ; Wed, 3 May 2017 19:04:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id azspNpeL9tYX for ; Wed, 3 May 2017 19:04:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5B510885B1 for ; Wed, 3 May 2017 19:04:51 +0000 (UTC) Received: by mail-pf0-f194.google.com with SMTP id b23so5726634pfc.0 for ; Wed, 03 May 2017 12:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=E4z/JGzcZrx+hgwtEBXM9ehXAlBiLC0XQ/PXiW9MPD0=; b=KvTAy2R9Fxp1XcAMJzrSdL7202mwLBdVRFomXp9AgAcpU4W//wIz+9ejIbIi6Lrfgy TE1CZFpdAEEKA2d4g277kuAfLenoExY23UDoEsUMOnfMm+n6GgG9hRN06B/nbFxkBSfG yWBKwoHh7+s/+OkGGss2IeOSS4k7kl2H0pfC+SphLkaYuUKnGrETo6DCk77MxQaS6mJw kbq2KbMvk55ltEy3/jEar0yz1oWDDSqD7bHshc9q8CNCnS4iRnVAAYF3M7N+YdbPfusz hRtL+chEVEWY0dSZaivs3Ht8jIujeq3hD1vrJrtDacBPRSexSuGDEDQ+0ve561aaIyu6 pC+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=E4z/JGzcZrx+hgwtEBXM9ehXAlBiLC0XQ/PXiW9MPD0=; b=P9dMJ3qO33ZxjevEAPwvJgVGK3VjUAhXKCC6u7R+x6ovehn7CbVaQ55glnl049k0Kr 34O5leFtAnIAq+3boDGFBsVm53zR0NlFdsOlvCLczKmyCx2BVcxt2y+VaTwlBk32oG+D Giy5WYAshUQabxE2q+B7oCzBukSQolg/yW+10gbd5s6RXexAsTJ0fNqSZx1Sm8/Xo5aY uEwJlQSUSpcL4eExPov2Ndw5CYKhGVgBCToQD7p81pBPrNa3jVbH4+KSr0YiR4AmXFl+ Nq9wy1ofFEEWRK1aOG1d8v+8oD+Jpk8dsxEjblbkRoVth21kGplS3IebdPlelgvKCmqA s/FQ== X-Gm-Message-State: AN3rC/7Iu1VI7BHOTtTWtK6pXE5zfE60imYZvurQgGcnXvURVpBwjUxn +8c8aefqC9/Uorc/YQ4= X-Received: by 10.99.109.199 with SMTP id i190mr16033480pgc.71.1493838290891; Wed, 03 May 2017 12:04:50 -0700 (PDT) Received: from localhost.localdomain ([49.35.13.14]) by smtp.gmail.com with ESMTPSA id d1sm5626195pfa.56.2017.05.03.12.04.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 May 2017 12:04:50 -0700 (PDT) From: Rahul Bedarkar To: buildroot@buildroot.org Date: Thu, 4 May 2017 00:34:14 +0530 Message-Id: <1493838254-3658-1-git-send-email-rahulbedarkar89@gmail.com> X-Mailer: git-send-email 2.7.4 Cc: Rahul Bedarkar Subject: [Buildroot] [PATCH] tinyxml2: fix build in static libs configuration X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" tinyxml2 can build both static and shared libraries. By default, only shared library is built. Shared/static builds are controlled using separate cmake flags BUILD_SHARED_LIBS and BUILD_STATIC_LIBS. In static libs configuration, we internally pass -DBUILD_SHARED_LIBS=OFF cmake flag to build system which disables both shared and static builds of library, resulting in failures while linking executable with library. So pass -DBUILD_STATIC_LIBS=ON cmake flag in case of static libs configuration. fixes: http://autobuild.buildroot.net/results/d30/d301bcbe5db26068b35eaa94bd816ae8cf8ef2e1 Signed-off-by: Rahul Bedarkar --- package/tinyxml2/tinyxml2.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/tinyxml2/tinyxml2.mk b/package/tinyxml2/tinyxml2.mk index bb1e167..e289ca9 100644 --- a/package/tinyxml2/tinyxml2.mk +++ b/package/tinyxml2/tinyxml2.mk @@ -10,4 +10,8 @@ TINYXML2_LICENSE = Zlib TINYXML2_LICENSE_FILES = readme.md TINYXML2_INSTALL_STAGING = YES +ifeq ($(BR2_STATIC_LIBS),y) +TINYXML2_CONF_OPTS += -DBUILD_STATIC_LIBS=ON +endif + $(eval $(cmake-package))