From patchwork Tue Mar 7 21:16:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 736365 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vd8bv1DMjz9sN6 for ; Wed, 8 Mar 2017 08:16:43 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LnM9ErU4"; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6612A26805; Tue, 7 Mar 2017 21:16:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Yoc923p0OgLy; Tue, 7 Mar 2017 21:16:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id AB20B26649; Tue, 7 Mar 2017 21:16:37 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id DFA9E1BFE6A for ; Tue, 7 Mar 2017 21:16:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C913E26649 for ; Tue, 7 Mar 2017 21:16:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wYaFHfT84XJP for ; Tue, 7 Mar 2017 21:16:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by silver.osuosl.org (Postfix) with ESMTPS id 75B1826455 for ; Tue, 7 Mar 2017 21:16:34 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id n11so3074459wma.0 for ; Tue, 07 Mar 2017 13:16:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=El85AaNAVAx6ff29UOcHgNCqo2TKligu23czroX2duw=; b=LnM9ErU4vZdLQGC3cd4MbgjmIqjlmgqCItyh4bdO53ofo04kSIw6mpjCpt8nJEBHZY DO9qJXLDPjKrmAGhgjxG6TMod1XhnCmxbm/JfeJoCTQYfOLVxcGZylYuZ3ilIo9Jvzv0 T08wjGc1jLlJ76WDqGBh99/OWdRbyzTO7eN+Iw18cWbyQUq5XkWhPN6ZNHGWROUFNj2A Db4YZkrxSjakCJnK/gzyO9rUz/ja0ythtD5XIbH0QvfwpAfLXG1ADG846C4vvGxjPC++ zfgT7qZSBodK+4Vx8sTFNpMhRyIivCMRETOPVgqPfZqpLeTnVnFJXvvxanwnzKSaoQTO YbRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=El85AaNAVAx6ff29UOcHgNCqo2TKligu23czroX2duw=; b=ciFjOMk1o0O5aZYt11MwnNnMfvgffBNwLl0E7I0cUmWGlBcVe33ErG5jwHsKNj8XPf TJHS1TAkn5MTfNyXZ3A7L/bsediOWgq0PSjmJH/jFZ9HBYXhiCUXxoAAmqXxkdJjCRmZ wfTm65qViFqtnaeENYi4FYZpyFhv165fwTS6S9aSbPWOnXs6ZxxF7R4Z+LfwIHMtfcQd mJB6bAlvG9kDAoVcHT+sMHkkifhKHKU+Kp1Rrhfv5rW1ZfHq1ca7WHHT0VmrQXmc1Q1B KeviC9Bk0GznO5wsxgHYZUfombM9PPlja7BY7c0/afTqiUlEhR4uIxhohr7n93y8p0jz hVwg== X-Gm-Message-State: AMke39nWYTQISCrrhBU06twRl0uH1pJLePxG6Q5Me28qtRQ4VFQap77PFUbQxPPB/H+Sxg== X-Received: by 10.28.234.20 with SMTP id i20mr20167465wmh.91.1488921392828; Tue, 07 Mar 2017 13:16:32 -0800 (PST) Received: from gourin.bzh.lan (ns304657.ip-46-105-103.eu. [46.105.103.66]) by smtp.gmail.com with ESMTPSA id u7sm1441279wru.56.2017.03.07.13.16.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Mar 2017 13:16:31 -0800 (PST) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Tue, 7 Mar 2017 22:16:28 +0100 Message-Id: <1488921388-9691-1-git-send-email-yann.morin.1998@free.fr> X-Mailer: git-send-email 2.7.4 Cc: "Yann E. MORIN" Subject: [Buildroot] [PATCH] package/rpi-userland: don't isntall file in random location X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Currently, rpi-userland installs files in $(@D)/../../bin/ which is entirely stupid, especially in cross-compilation. Get rid of the dubious, broken, custom install command. Signed-off-by: "Yann E. MORIN" Tested-by: Peter Seiderer --- ...toverlay-don-t-install-script-in-random-l.patch | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 package/rpi-userland/0006-host-apps-dtoverlay-don-t-install-script-in-random-l.patch diff --git a/package/rpi-userland/0006-host-apps-dtoverlay-don-t-install-script-in-random-l.patch b/package/rpi-userland/0006-host-apps-dtoverlay-don-t-install-script-in-random-l.patch new file mode 100644 index 0000000..2900eb7 --- /dev/null +++ b/package/rpi-userland/0006-host-apps-dtoverlay-don-t-install-script-in-random-l.patch @@ -0,0 +1,45 @@ +From a5a4e361c8116ca9228a896f672102c02be56bb7 Mon Sep 17 00:00:00 2001 +From: "Yann E. MORIN" +Date: Tue, 7 Mar 2017 22:01:39 +0100 +Subject: [PATCH] host-apps/dtoverlay: don't install script in random location + +Currently, we add a custom command that installs the dtoverlay pre/post +scripts in ${CMAKE_BINARY_DIR}/../../bin + +However: + + - this points outside of the package directory.; it even points two + directories higher; + + - when doing cross-compilation, this is definitely not the place where + the /bin directory really is; + + - the scripts are already properly installed without this code. + +Remove that code, it serves no purpose and breaks for cross-compilation. + +Signed-off-by: "Yann E. MORIN" +--- + host_applications/linux/apps/dtoverlay/CMakeLists.txt | 8 -------- + 1 file changed, 8 deletions(-) + +diff --git a/host_applications/linux/apps/dtoverlay/CMakeLists.txt b/host_applications/linux/apps/dtoverlay/CMakeLists.txt +index 9009200..dd48d83 100755 +--- a/host_applications/linux/apps/dtoverlay/CMakeLists.txt ++++ b/host_applications/linux/apps/dtoverlay/CMakeLists.txt +@@ -22,12 +22,4 @@ add_custom_command(TARGET dtoverlay POST_BUILD COMMAND ln;-sf;dtoverlay;dtparam) + install(FILES ${CMAKE_CURRENT_BINARY_DIR}/dtparam DESTINATION bin) + + set(DTOVERLAY_SCRIPTS dtoverlay-pre dtoverlay-post) +-foreach(_script ${DTOVERLAY_SCRIPTS}) +- add_custom_command( +- TARGET dtoverlay +- COMMAND ${CMAKE_COMMAND} +- -E copy ${CMAKE_CURRENT_SOURCE_DIR}/${_script} +- ${CMAKE_BINARY_DIR}/../../bin/${_script} +- ) +-endforeach() + install(PROGRAMS ${DTOVERLAY_SCRIPTS} DESTINATION bin) +-- +2.7.4 +