| Message ID | 1476720440-22239-77-git-send-email-gustavo.zacarias@free-electrons.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 17-10-16 18:07, gustavo.zacarias@free-electrons.com wrote: > From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com> > > Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com> > --- > package/dtc/dtc.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk > index 8fdcdbe..01699bb 100644 > --- a/package/dtc/dtc.mk > +++ b/package/dtc/dtc.mk > @@ -37,12 +37,12 @@ endef > > # For staging, only the library is needed > define DTC_INSTALL_STAGING_CMDS > - $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install-lib \ > + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install-lib \ Why TARGET_CONFIGURE_OPTS instead of TARGET_MAKE_ENV? Also, the line is a bit long and it anyway makes more sense to have install-lib and install-includes on the same line. Regards, Arnout > install-includes > endef > > define DTC_INSTALL_TARGET_CMDS > - $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL) > + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL) > endef > > # host build >
On 18-10-16 22:09, Arnout Vandecappelle wrote: > > > On 17-10-16 18:07, gustavo.zacarias@free-electrons.com wrote: >> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com> >> >> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com> >> --- >> package/dtc/dtc.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk >> index 8fdcdbe..01699bb 100644 >> --- a/package/dtc/dtc.mk >> +++ b/package/dtc/dtc.mk >> @@ -37,12 +37,12 @@ endef >> >> # For staging, only the library is needed >> define DTC_INSTALL_STAGING_CMDS >> - $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install-lib \ >> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install-lib \ > > Why TARGET_CONFIGURE_OPTS instead of TARGET_MAKE_ENV? Scratch that, I guess we just always want to pass TARGET_CONFIGURE_OPTS in either the environment or the arguments of make. No further explanation needed. > > Also, the line is a bit long and it anyway makes more sense to have install-lib > and install-includes on the same line. This one stands of course. Regards, Arnout > > Regards, > Arnout > >> install-includes >> endef >> >> define DTC_INSTALL_TARGET_CMDS >> - $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL) >> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL) >> endef >> >> # host build >> >
diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk index 8fdcdbe..01699bb 100644 --- a/package/dtc/dtc.mk +++ b/package/dtc/dtc.mk @@ -37,12 +37,12 @@ endef # For staging, only the library is needed define DTC_INSTALL_STAGING_CMDS - $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install-lib \ + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install-lib \ install-includes endef define DTC_INSTALL_TARGET_CMDS - $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL) + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) PREFIX=/usr $(DTC_INSTALL_GOAL) endef # host build