From patchwork Sun Jul 24 15:39:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 652107 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ry7qc3KgTz9t0p for ; Mon, 25 Jul 2016 01:39:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=N63tbGcT; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 98CCA8721B; Sun, 24 Jul 2016 15:39:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QC_9j1jT8GyJ; Sun, 24 Jul 2016 15:39:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 150E286ED5; Sun, 24 Jul 2016 15:39:52 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 1920D1C10B8 for ; Sun, 24 Jul 2016 15:39:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1333B2D701 for ; Sun, 24 Jul 2016 15:39:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yMPtJDTAwmtN for ; Sun, 24 Jul 2016 15:39:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by silver.osuosl.org (Postfix) with ESMTPS id D8E2F267B5 for ; Sun, 24 Jul 2016 15:39:49 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id x83so13152422wma.3 for ; Sun, 24 Jul 2016 08:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=TrTDVkXO9AKEBRcmvpTAwn3DAU8g2oFjZ+/3cEm/Xmk=; b=N63tbGcTjYIFr1/S0IiLlASw2efn5LPseeipJn+v9gqTGqpTtx5hur5RmTHuUgrQhL yLjSHZeqQw9OtU2Aolk0uYulGUBKATcNOuRhTOrrnHZpiAALXAQqoOrlDunQktmj7SA9 CfoT/inIqJ9w21t5nA6fxQEezueREsKuQw1OJoYY2ciDlO91hAHVkbGhyYzokMT01d1p OfJGnh2+4Hax2RkovJ19Lc8BvWQOqKBKxPWd4eeBrXzNQj91adYC/JlYQe9hZQLgp6c4 sc7xAJTR59tpVKUEFyCrbJPjbBPpQ1wS+QnTYAIiPZEZ/RmMQyCbwjgz2BU1InYhlpPT YNEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TrTDVkXO9AKEBRcmvpTAwn3DAU8g2oFjZ+/3cEm/Xmk=; b=BNQSqTa+S20mqkbAh+3diqIGm7Zm6NqYPVG9X9dze5jGm7AM86G5k38GIcv3c3Hmxl A+O8kFhRwTuIFP48J7O/rCTyGPgF1jLgtmOQMlifczNRz8ppdLZS3kLC6cTZEqjUSksN OHJrr+sh4oB4XEpQeYMQDmmCzb2s2dZyy2ysFTLsGgTDEzpEK4TG5lWBO3f8lXeSeo5z gfef4A/Gr6jR3sMyIwqSI5GVBlkJrIdalYqM0ez+jcWyV2S0MZsGBaBAJtXxCjg0xqNX xASN61POmabOZvTW8THohP1sq21oHSVLJ90iaPsrlx7gusYWNouqEClHMMYv2Jr5cbCD CIAQ== X-Gm-Message-State: ALyK8tKDb+5u404TbOWgDUAVhnIrACBN0RFqkVdiCzaXCgrCnM+KCLDgXrQED2cgq82j4g== X-Received: by 10.28.168.83 with SMTP id r80mr34179110wme.44.1469374788392; Sun, 24 Jul 2016 08:39:48 -0700 (PDT) Received: from atlas.localdomain.localdomain ([2a01:e35:1391:67d0:caf7:33ff:fe77:d120]) by smtp.gmail.com with ESMTPSA id f3sm11198653wjh.2.2016.07.24.08.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jul 2016 08:39:47 -0700 (PDT) From: Romain Naour To: buildroot@buildroot.org Date: Sun, 24 Jul 2016 17:39:43 +0200 Message-Id: <1469374783-22190-1-git-send-email-romain.naour@gmail.com> X-Mailer: git-send-email 2.5.5 Cc: Thomas Petazzoni , Romain Naour , Christian Stewart Subject: [Buildroot] [PATCH] package/go: needs PIE support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" When build statically, runc try to link against Scrt1.o which is not provided by uClibc ARM toolchain for static build only. [...]arm-buildroot-linux-uclibcgnueabi/bin/ld: cannot find Scrt1.o: No such file or directory collect2: error: ld returned 1 exit status On ARM, Go forces the use of -pie, for some reason: pie := (goarch == "arm" && goos == "linux") || goos == "android" if pie { // we need to use -pie for Linux/ARM to get accurate imported sym cgoLDFLAGS = append(cgoLDFLAGS, "-pie") } For this reason, add a dependency on BR2_TOOLCHAIN_SUPPORTS_PIE for ARM CPUs to disable Go for such toolchains. While at it, rewrap Go dependencies. [1] http://lists.busybox.net/pipermail/buildroot/2016-July/167206.html Signed-off-by: Romain Naour Cc: Thomas Petazzoni Cc: Christian Stewart Tested-by: Christian Stewart --- Require https://patchwork.ozlabs.org/patch/646956/ --- package/go/Config.in.host | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package/go/Config.in.host b/package/go/Config.in.host index d6d35dc..d79c669 100644 --- a/package/go/Config.in.host +++ b/package/go/Config.in.host @@ -1,7 +1,9 @@ config BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS bool default y - depends on BR2_arm || BR2_aarch64 || BR2_i386 || BR2_x86_64 || BR2_powerpc64 || BR2_powerpc64le || BR2_mips64 || BR2_mips64el + depends on (BR2_arm && BR2_TOOLCHAIN_SUPPORTS_PIE) || BR2_aarch64 \ + || BR2_i386 || BR2_x86_64 || BR2_powerpc64 || BR2_powerpc64le \ + || BR2_mips64 || BR2_mips64el depends on !BR2_ARM_CPU_ARMV4 # MIPS R6 support in Go has not yet been developed. depends on !BR2_mips_64r6