| Message ID | 1463469451-18931-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Rejected |
| Headers | show |
On May 17, 2016 9:17:31 AM GMT+02:00, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: >As suggested by Peter Korsgaard, now that the eglibc support has been >removed, it is useful to automatically make the user's configuration >fall back to glibc (instead of uClibc, which would be the default C >library). > >Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >--- > Config.in.legacy | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/Config.in.legacy b/Config.in.legacy >index a0a2059..461af69 100644 >--- a/Config.in.legacy >+++ b/Config.in.legacy >@@ -155,11 +155,14 @@ config BR2_BINUTILS_VERSION_2_23_X > config BR2_TOOLCHAIN_BUILDROOT_EGLIBC > bool "eglibc support has been removed" > select BR2_LEGACY >+ select BR2_TOOLCHAIN_BUILDROOT_GLIBC > help > The eglibc project no longer exists, as it has been merged > back into the glibc project. Therefore, support for eglibc > has been removed, and glibc should be used instead. > >+ glibc has been automatically selected as a fallback. >+ > config BR2_GDB_VERSION_7_8 > bool "gdb 7.8 has been removed" > select BR2_LEGACY >-- >2.7.4 > >_______________________________________________ >buildroot mailing list >buildroot@busybox.net >http://lists.busybox.net/mailman/listinfo/buildroot BR2_TOOLCHAIN_BUILDROOT_GLIBC is part of a choice, so you can't select it. That's the limit of our legacy handling: it can't handle choices. Regards, Yann E. MORIN.
Hello, On Tue, 17 May 2016 09:23:03 +0200, Yann E. MORIN wrote: > BR2_TOOLCHAIN_BUILDROOT_GLIBC is part of a choice, so you can't select it. > > That's the limit of our legacy handling: it can't handle choices. Gah, yes, indeed. I guess the only option is to keep a: default BR2_TOOLCHAIN_BUILDROOT_GLIBC if BR2_TOOLCHAIN_BUILDROOT_EGLIBC but it's rather annoying to keep legacy code forever elsewhere than in Config.in.legacy. So I'd prefer that we don't do anything in fact: the number of users using eglibc in their configuration is probably pretty low. Thanks for the review! Thomas
On 05/17/16 09:26, Thomas Petazzoni wrote: > Hello, > > On Tue, 17 May 2016 09:23:03 +0200, Yann E. MORIN wrote: > >> BR2_TOOLCHAIN_BUILDROOT_GLIBC is part of a choice, so you can't select it. >> >> That's the limit of our legacy handling: it can't handle choices. > > Gah, yes, indeed. I guess the only option is to keep a: > > default BR2_TOOLCHAIN_BUILDROOT_GLIBC if BR2_TOOLCHAIN_BUILDROOT_EGLIBC > > but it's rather annoying to keep legacy code forever elsewhere than in > Config.in.legacy. So I'd prefer that we don't do anything in fact: the > number of users using eglibc in their configuration is probably pretty > low. Agreed. Regards, Arnout > > Thanks for the review! > > Thomas >
diff --git a/Config.in.legacy b/Config.in.legacy index a0a2059..461af69 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -155,11 +155,14 @@ config BR2_BINUTILS_VERSION_2_23_X config BR2_TOOLCHAIN_BUILDROOT_EGLIBC bool "eglibc support has been removed" select BR2_LEGACY + select BR2_TOOLCHAIN_BUILDROOT_GLIBC help The eglibc project no longer exists, as it has been merged back into the glibc project. Therefore, support for eglibc has been removed, and glibc should be used instead. + glibc has been automatically selected as a fallback. + config BR2_GDB_VERSION_7_8 bool "gdb 7.8 has been removed" select BR2_LEGACY
As suggested by Peter Korsgaard, now that the eglibc support has been removed, it is useful to automatically make the user's configuration fall back to glibc (instead of uClibc, which would be the default C library). Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- Config.in.legacy | 3 +++ 1 file changed, 3 insertions(+)