From patchwork Mon May 2 16:37:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geoff Levand X-Patchwork-Id: 617598 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 3qz92s28WSz9t3v for ; Tue, 3 May 2016 02:37:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B826B86F7D; Mon, 2 May 2016 16:37:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VgeKYtD86HNy; Mon, 2 May 2016 16:37:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A9E4F86F14; Mon, 2 May 2016 16:37:53 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 043C91C0D74 for ; Mon, 2 May 2016 16:37:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id F24E58B4BC for ; Mon, 2 May 2016 16:37:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kI3e7O5T4AVP for ; Mon, 2 May 2016 16:37:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4FBF98B49C for ; Mon, 2 May 2016 16:37:52 +0000 (UTC) Received: from 107-1-141-74-ip-static.hfc.comcastbusiness.net ([107.1.141.74] helo=[192.168.253.130]) by bombadil.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1axGr0-0004ay-Pj; Mon, 02 May 2016 16:37:50 +0000 Message-ID: <1462207070.27026.20.camel@infradead.org> From: Geoff Levand To: Christian Stewart , Thomas Petazzoni Date: Mon, 02 May 2016 09:37:50 -0700 In-Reply-To: <1462074238901-b9436b8a-0eb718e2-8f9a915c@mixmax.com> References: <20160421224301.6a05f711@free-electrons.com> <1461965160.27026.9.camel@infradead.org> <20160430140314.4ff30ff1@free-electrons.com> <1462074238901-b9436b8a-0eb718e2-8f9a915c@mixmax.com> X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Cc: buildroot@busybox.net Subject: Re: [Buildroot] [PATCH v3 0/3] Add go language support X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On Sun, 2016-05-01 at 03:43 +0000, Christian Stewart wrote: > Indeed, the cross compiler toolchain is NOT compiled before Go. I > think a dependency needs to be added for this. I have the patch below that adds BR2_TOOLCHAIN_HAS_THREADS. Is it enough to pull in the toolchain? -Geoff From b461b3a39f5ce64641006845157748295568151c Mon Sep 17 00:00:00 2001 From: Geoff Levand Date: Mon, 25 Apr 2016 12:59:04 -0700 Subject: [PATCH 1/9] package/go: Add BR2_TOOLCHAIN_HAS_THREADS CGO needs thread support. Fixes build errors like these: warning requested reentrant code, but thread support was disabled Signed-off-by: Geoff Levand --- package/go/Config.in.host | 1 + 1 file changed, 1 insertion(+) diff --git a/package/go/Config.in.host b/package/go/Config.in.host index 094e402..e988483 100644 --- a/package/go/Config.in.host +++ b/package/go/Config.in.host @@ -1,5 +1,6 @@ config BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS bool default y + depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_arm || BR2_aarch64 || BR2_i386 || BR2_x86_64 || BR2_powerpc depends on !BR2_ARM_CPU_ARMV4