diff mbox

[v6,1/1] PyMySQL: new package

Message ID 1460497151-29117-1-git-send-email-stevecalfee@gmail.com
State Accepted
Headers show

Commit Message

Steve Calfee April 12, 2016, 9:39 p.m. UTC 
add python to MySQL connection software, written in pure python

Signed-off-by: Steve Calfee <stevecalfee@gmail.com>

---
v4 fix git commit per review

---
v5 fixup missed review request for Capitalization of MySQL
---
 package/Config.in                          |  1 +
 package/python-pymysql/Config.in           |  7 +++++++
 package/python-pymysql/python-pymysql.hash |  4 ++++
 package/python-pymysql/python-pymysql.mk   | 14 ++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/python-pymysql/Config.in
 create mode 100644 package/python-pymysql/python-pymysql.hash
 create mode 100644 package/python-pymysql/python-pymysql.mk

Comments

Arnout Vandecappelle April 12, 2016, 9:48 p.m. UTC | #1 
On 04/12/16 23:39, Steve Calfee wrote:
> add python to MySQL connection software, written in pure python
>
> Signed-off-by: Steve Calfee <stevecalfee@gmail.com>

  As said:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  Regards,
  Arnout

>
> ---
> v4 fix git commit per review
>
> ---
> v5 fixup missed review request for Capitalization of MySQL
> ---
>   package/Config.in                          |  1 +
>   package/python-pymysql/Config.in           |  7 +++++++
>   package/python-pymysql/python-pymysql.hash |  4 ++++
>   package/python-pymysql/python-pymysql.mk   | 14 ++++++++++++++
>   4 files changed, 26 insertions(+)
>   create mode 100644 package/python-pymysql/Config.in
>   create mode 100644 package/python-pymysql/python-pymysql.hash
>   create mode 100644 package/python-pymysql/python-pymysql.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 529ad33..2543195 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -683,6 +683,7 @@ menu "External python modules"
>   	source "package/python-pyftpdlib/Config.in"
>   	source "package/python-pygame/Config.in"
>   	source "package/python-pyinotify/Config.in"
> +	source "package/python-pymysql/Config.in"
>   	source "package/python-pyparsing/Config.in"
>   	source "package/python-pyparted/Config.in"
>   	source "package/python-pypcap/Config.in"
> diff --git a/package/python-pymysql/Config.in b/package/python-pymysql/Config.in
> new file mode 100644
> index 0000000..d0db376
> --- /dev/null
> +++ b/package/python-pymysql/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_PYMYSQL
> +	bool "python-pymysql"
> +	help
> +	  PyMySQL is a pure-Python MySQL client library.
> +	  It follows the DB-API 2.0.
> +
> +	  https://pypi.python.org/pypi/PyMySQL/
> diff --git a/package/python-pymysql/python-pymysql.hash b/package/python-pymysql/python-pymysql.hash
> new file mode 100644
> index 0000000..fc7e5e3
> --- /dev/null
> +++ b/package/python-pymysql/python-pymysql.hash
> @@ -0,0 +1,4 @@
> +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7
> +md5     6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz
> +# Locally calculated:
> +sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba  PyMySQL-0.7.2.tar.gz
> diff --git a/package/python-pymysql/python-pymysql.mk b/package/python-pymysql/python-pymysql.mk
> new file mode 100644
> index 0000000..e58ff7e
> --- /dev/null
> +++ b/package/python-pymysql/python-pymysql.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-pymysql
> +#
> +################################################################################
> +
> +PYTHON_PYMYSQL_VERSION = 0.7.2
> +PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz
> +PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL
> +PYTHON_PYMYSQL_LICENSE = MIT
> +PYTHON_PYMYSQL_LICENSE_FILES = LICENSE
> +PYTHON_PYMYSQL_SETUP_TYPE = setuptools
> +
> +$(eval $(python-package))
>
Thomas Petazzoni April 13, 2016, 8:20 p.m. UTC | #2 
Hello,

On Tue, 12 Apr 2016 14:39:11 -0700, Steve Calfee wrote:
> add python to MySQL connection software, written in pure python
> 
> Signed-off-by: Steve Calfee <stevecalfee@gmail.com>

The title of the commit should have used the package name:

	python-pymysql: new package

> diff --git a/package/python-pymysql/Config.in b/package/python-pymysql/Config.in
> new file mode 100644
> index 0000000..d0db376
> --- /dev/null
> +++ b/package/python-pymysql/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_PYMYSQL
> +	bool "python-pymysql"
> +	help
> +	  PyMySQL is a pure-Python MySQL client library. 

There was a trailing whitespace on this line.

Also, your patch did not apply due to a conflict in package/Config.in,
caused by packages that were added quite some time ago in Buildroot.
This seems to indicate that you are not working on top of the latest
master. Please submit patches that are based and tested on top of the
latest master.

I've applied after fixing the minor issues mentioned above. Thanks a
lot!

Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 529ad33..2543195 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -683,6 +683,7 @@  menu "External python modules"
 	source "package/python-pyftpdlib/Config.in"
 	source "package/python-pygame/Config.in"
 	source "package/python-pyinotify/Config.in"
+	source "package/python-pymysql/Config.in"
 	source "package/python-pyparsing/Config.in"
 	source "package/python-pyparted/Config.in"
 	source "package/python-pypcap/Config.in"
diff --git a/package/python-pymysql/Config.in b/package/python-pymysql/Config.in
new file mode 100644
index 0000000..d0db376
--- /dev/null
+++ b/package/python-pymysql/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_PYTHON_PYMYSQL
+	bool "python-pymysql"
+	help
+	  PyMySQL is a pure-Python MySQL client library. 
+	  It follows the DB-API 2.0.
+
+	  https://pypi.python.org/pypi/PyMySQL/
diff --git a/package/python-pymysql/python-pymysql.hash b/package/python-pymysql/python-pymysql.hash
new file mode 100644
index 0000000..fc7e5e3
--- /dev/null
+++ b/package/python-pymysql/python-pymysql.hash
@@ -0,0 +1,4 @@ 
+#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7
+md5     6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz
+# Locally calculated:
+sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba  PyMySQL-0.7.2.tar.gz
diff --git a/package/python-pymysql/python-pymysql.mk b/package/python-pymysql/python-pymysql.mk
new file mode 100644
index 0000000..e58ff7e
--- /dev/null
+++ b/package/python-pymysql/python-pymysql.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# python-pymysql
+#
+################################################################################
+
+PYTHON_PYMYSQL_VERSION = 0.7.2
+PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz
+PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL
+PYTHON_PYMYSQL_LICENSE = MIT
+PYTHON_PYMYSQL_LICENSE_FILES = LICENSE
+PYTHON_PYMYSQL_SETUP_TYPE = setuptools
+
+$(eval $(python-package))