From patchwork Sat Mar 12 12:43:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niels Skou Olsen X-Patchwork-Id: 596651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 3qMkGm1DmDz9s5M for ; Sat, 12 Mar 2016 23:44:15 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3468333B19; Sat, 12 Mar 2016 12:44:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IXYtEm31t33f; Sat, 12 Mar 2016 12:44:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id B12E3339D6; Sat, 12 Mar 2016 12:44:12 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 46ABA1C2BB2 for ; Sat, 12 Mar 2016 12:44:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 426DAA5B9D for ; Sat, 12 Mar 2016 12:44:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XkdXJN9ETasi for ; Sat, 12 Mar 2016 12:44:09 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from prime.nsonet.eu (prime.nsonet.eu [178.63.75.197]) by fraxinus.osuosl.org (Postfix) with ESMTP id 98B2AA5B78 for ; Sat, 12 Mar 2016 12:44:09 +0000 (UTC) Received: from localhost.localdomain (x1-6-20-e5-2a-e1-6c-ca.cpe.webspeed.dk [2.108.243.104]) by prime.nsonet.eu (Postfix) with ESMTPSA id B2FB820625CD; Sat, 12 Mar 2016 13:44:07 +0100 (CET) From: Niels Skou Olsen To: buildroot@buildroot.org Date: Sat, 12 Mar 2016 13:43:58 +0100 Message-Id: <1457786638-13861-1-git-send-email-niels@tonebarker.dk> X-Mailer: git-send-email 2.5.0 Cc: Niels Skou Olsen Subject: [Buildroot] [PATCH 1/1] kbd: fix target install X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The package makefile fails to append to the KBD_INSTALL_TARGET_OPTS variable in autotools-package. This means that the DESTDIR and install target are lost, and so the package is never installed to target. To fix it the append must happen after the eval of autotools-package. Signed-off-by: Niels Skou Olsen --- package/kbd/kbd.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package/kbd/kbd.mk b/package/kbd/kbd.mk index 9dabce1..72519ff 100644 --- a/package/kbd/kbd.mk +++ b/package/kbd/kbd.mk @@ -17,6 +17,7 @@ KBD_LICENSE = GPLv2+ KBD_LICENSE_FILES = COPYING KBD_AUTORECONF = YES -KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs - $(eval $(autotools-package)) + +# must happen after the autotools-package eval, or else the append becomes an overwrite +KBD_INSTALL_TARGET_OPTS += MKINSTALLDIRS=$(@D)/config/mkinstalldirs