diff mbox

package/x11r7/xapp_xf86dga: remove dependencies on Xt/Xaw/Xmu

Message ID 1455055451-19200-1-git-send-email-arnout@mind.be
State Accepted
Commit 63b77dd64c98825edef7d0cddd945ce096785ecd
Headers show

Commit Message

Arnout Vandecappelle Feb. 9, 2016, 10:04 p.m. UTC
Since the bump to 1.0.3, xapp_xf86dga no longer uses libXt, libXaw and
libXmu. So these dependencies should be removed from the .mk file.

They were already removed from Config.in, leading to messages like:
Makefile:475: *** xlib_libXaw is in the dependency chain of xapp_xf86dga
that has added it to its _DEPENDENCIES variable without selecting it or
depending on it from Config.in.  Stop.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/x11r7/xapp_xf86dga/xapp_xf86dga.mk | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Ricardo Martincoski Feb. 10, 2016, 12:10 a.m. UTC | #1
On Tue, Feb 09, 2016 at 08:04 PM, Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> wrote:
> Since the bump to 1.0.3, xapp_xf86dga no longer uses libXt, libXaw and
> libXmu. So these dependencies should be removed from the .mk file.
> 
> They were already removed from Config.in, leading to messages like:
> Makefile:475: *** xlib_libXaw is in the dependency chain of xapp_xf86dga
> that has added it to its _DEPENDENCIES variable without selecting it or
> depending on it from Config.in.  Stop.

You can add if you want:

Fixes:
http://autobuild.buildroot.net/results/aee/aee4a895c74647292715705bfcdf742f3ea2f76f/

> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Build test for the autobuild issue using minimal config
BR2_TOOLCHAIN_EXTERNAL=y # easy for toolchain w/ MMU support
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XAPP_XF86DGA=y

Regards,
Ricardo
Peter Korsgaard Feb. 10, 2016, 6:52 a.m. UTC | #2
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > Since the bump to 1.0.3, xapp_xf86dga no longer uses libXt, libXaw and
 > libXmu. So these dependencies should be removed from the .mk file.

 > They were already removed from Config.in, leading to messages like:
 > Makefile:475: *** xlib_libXaw is in the dependency chain of xapp_xf86dga
 > that has added it to its _DEPENDENCIES variable without selecting it or
 > depending on it from Config.in.  Stop.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed with the autobuilder reference added as suggested by Ricardo, thanks.
diff mbox

Patch

diff --git a/package/x11r7/xapp_xf86dga/xapp_xf86dga.mk b/package/x11r7/xapp_xf86dga/xapp_xf86dga.mk
index a2e08da..fe8e427 100644
--- a/package/x11r7/xapp_xf86dga/xapp_xf86dga.mk
+++ b/package/x11r7/xapp_xf86dga/xapp_xf86dga.mk
@@ -12,9 +12,6 @@  XAPP_XF86DGA_LICENSE_FILES = COPYING
 XAPP_XF86DGA_DEPENDENCIES = \
 	host-pkgconf \
 	xlib_libX11 \
-	xlib_libXxf86dga \
-	xlib_libXt \
-	xlib_libXaw \
-	xlib_libXmu
+	xlib_libXxf86dga
 
 $(eval $(autotools-package))