From patchwork Sat Jan 30 15:48:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Kuhls X-Patchwork-Id: 576021 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 99A86140B98 for ; Sun, 31 Jan 2016 02:48:21 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DC18D95552; Sat, 30 Jan 2016 15:48:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XoEJ2sfyO5Xo; Sat, 30 Jan 2016 15:48:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id C527E9550C; Sat, 30 Jan 2016 15:48:19 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5DE131C1654 for ; Sat, 30 Jan 2016 15:48:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 586249550C for ; Sat, 30 Jan 2016 15:48:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YNxPZl7ZZEsy for ; Sat, 30 Jan 2016 15:48:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout08.t-online.de (mailout08.t-online.de [194.25.134.20]) by hemlock.osuosl.org (Postfix) with ESMTPS id 4684D95500 for ; Sat, 30 Jan 2016 15:48:16 +0000 (UTC) Received: from fwd29.aul.t-online.de (fwd29.aul.t-online.de [172.20.26.134]) by mailout08.t-online.de (Postfix) with SMTP id 91B9B370FCB for ; Sat, 30 Jan 2016 16:48:14 +0100 (CET) Received: from fli4l.lan.fli4l (rIF7IoZcohhf6G0fcTtvojirrrTWVl0mmqJ+MKiQ6-P-6D3wuXI-I2dxo+6-yKuQ7Y@[84.178.233.95]) by fwd29.t-online.de with (TLSv1:ECDHE-RSA-AES256-SHA encrypted) esmtp id 1aPXkt-0phkA40; Sat, 30 Jan 2016 16:48:07 +0100 Received: from mahler.lan.fli4l ([192.168.1.1]:36906 helo=kuhls.lan.fli4l) by fli4l.lan.fli4l with esmtp (Exim 4.86) (envelope-from ) id 1aPXkt-000147-1x; Sat, 30 Jan 2016 16:48:07 +0100 From: Bernd Kuhls To: buildroot@buildroot.org Date: Sat, 30 Jan 2016 16:48:06 +0100 Message-Id: <1454168886-30961-2-git-send-email-bernd.kuhls@t-online.de> X-Mailer: git-send-email 2.7.0.rc3 In-Reply-To: <1454168886-30961-1-git-send-email-bernd.kuhls@t-online.de> References: <1454168886-30961-1-git-send-email-bernd.kuhls@t-online.de> X-ID: rIF7IoZcohhf6G0fcTtvojirrrTWVl0mmqJ+MKiQ6-P-6D3wuXI-I2dxo+6-yKuQ7Y X-TOI-MSGID: e80ee98e-7c0b-4bd0-bc7e-7824203d7ae5 Cc: Bernd Kuhls Subject: [Buildroot] [PATCH v2 2/2] package/kodi: reorder select/depends X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From [1]: "Even though the ordering has absolutely no consequences in Kconfig, it is not logical (when reading). It is more logical and far easier to understand when depends come first, followed by the selects." Also, the Config.in example in the manual suggests to use this coding style [2]. [1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html [2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in Signed-off-by: Bernd Kuhls --- v2: no changes package/kodi/Config.in | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/package/kodi/Config.in b/package/kodi/Config.in index ed90ed6..f1236f7 100644 --- a/package/kodi/Config.in +++ b/package/kodi/Config.in @@ -32,6 +32,14 @@ comment "kodi requires an OpenGL ES and EGL backend" menuconfig BR2_PACKAGE_KODI bool "kodi" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS + depends on BR2_PACKAGE_KODI_EGL_GLES || BR2_PACKAGE_KODI_GL + depends on !BR2_STATIC_LIBS # python + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_TOOLCHAIN_USES_MUSL + depends on BR2_USE_MMU # python + depends on BR2_USE_WCHAR select BR2_NEEDS_HOST_JAVA select BR2_PACKAGE_BOOST select BR2_PACKAGE_BOOST_THREAD @@ -88,14 +96,6 @@ menuconfig BR2_PACKAGE_KODI select BR2_PACKAGE_YAJL select BR2_PACKAGE_ZLIB select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_USES_GLIBC # runtime UTF conversion support - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_TOOLCHAIN_HAS_THREADS - depends on !BR2_TOOLCHAIN_USES_MUSL - depends on BR2_PACKAGE_KODI_EGL_GLES || BR2_PACKAGE_KODI_GL - depends on BR2_USE_MMU # python - depends on BR2_USE_WCHAR - depends on !BR2_STATIC_LIBS # python - depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS help Kodi is an award-winning free and open source (GPL) software media player and entertainment hub for digital media.