diff mbox

[1/1] xdotool: new package

Message ID 1451354367-26073-1-git-send-email-nunes.erico@gmail.com
State Accepted
Headers show

Commit Message

Erico Nunes Dec. 29, 2015, 1:59 a.m. UTC 
xdotool is a command-line X11 automation tool.

http://www.semicomplete.com/projects/xdotool

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
 package/Config.in            |  1 +
 package/xdotool/Config.in    | 11 +++++++++++
 package/xdotool/xdotool.hash |  2 ++
 package/xdotool/xdotool.mk   | 24 ++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/xdotool/Config.in
 create mode 100644 package/xdotool/xdotool.hash
 create mode 100644 package/xdotool/xdotool.mk

Comments

Baruch Siach Dec. 29, 2015, 7:07 a.m. UTC | #1 
Hi Erico,

On Mon, Dec 28, 2015 at 11:59:27PM -0200, Erico Nunes wrote:
> +################################################################################
> +#
> +# xdotool
> +#
> +################################################################################
> +
> +XDOTOOL_VERSION = v3.20150503.1
> +XDOTOOL_SITE = $(call github,jordansissel,xdotool,$(XDOTOOL_VERSION))
> +XDOTOOL_LICENSE = custom

Should be "BSD-3c". Compare COPYRIGHT to 
https://opensource.org/licenses/BSD-3-Clause.

> +XDOTOOL_LICENSE_FILES = COPYRIGHT

baruch
Erico Nunes Dec. 29, 2015, 1:51 p.m. UTC | #2 
Hi Baruch,

On Tue, Dec 29, 2015 at 5:07 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Should be "BSD-3c". Compare COPYRIGHT to
> https://opensource.org/licenses/BSD-3-Clause.
>

Thanks for pointing this out, I'll submit a v2.

Erico
Thomas Petazzoni Dec. 29, 2015, 2:04 p.m. UTC | #3 
Dear Erico Nunes,

On Tue, 29 Dec 2015 11:51:40 -0200, Erico Nunes wrote:
> Hi Baruch,
> 
> On Tue, Dec 29, 2015 at 5:07 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > Should be "BSD-3c". Compare COPYRIGHT to
> > https://opensource.org/licenses/BSD-3-Clause.
> >
> 
> Thanks for pointing this out, I'll submit a v2.

Not needed, I have already applied your patch locally, I'll push soon.

Thanks!

Thomas
Thomas Petazzoni Dec. 29, 2015, 3:09 p.m. UTC | #4 
Dear Erico Nunes,

On Mon, 28 Dec 2015 23:59:27 -0200, Erico Nunes wrote:
> xdotool is a command-line X11 automation tool.
> 
> http://www.semicomplete.com/projects/xdotool
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  package/Config.in            |  1 +
>  package/xdotool/Config.in    | 11 +++++++++++
>  package/xdotool/xdotool.hash |  2 ++
>  package/xdotool/xdotool.mk   | 24 ++++++++++++++++++++++++
>  4 files changed, 38 insertions(+)
>  create mode 100644 package/xdotool/Config.in
>  create mode 100644 package/xdotool/xdotool.hash
>  create mode 100644 package/xdotool/xdotool.mk

I've applied after doing a few changes:

    [Thomas:
     - fix <pkg>_LICENSE, as noticed by Baruch
     - use $(TARGET_MAKE_ENV).]

Also, I've submitted a pull request to the original project to allow
the LDCONFIG variable to be overridden so that ultimately we should be
able to use 'make install'. See
https://github.com/jordansissel/xdotool/pull/90.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index a024d3d..973fae1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -304,6 +304,7 @@  comment "X applications"
 	source "package/torsmo/Config.in"
 	source "package/wmctrl/Config.in"
 	source "package/x11vnc/Config.in"
+	source "package/xdotool/Config.in"
 	source "package/xscreensaver/Config.in"
 	source "package/xterm/Config.in"
 	source "package/xvkbd/Config.in"
diff --git a/package/xdotool/Config.in b/package/xdotool/Config.in
new file mode 100644
index 0000000..4d5f590
--- /dev/null
+++ b/package/xdotool/Config.in
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_XDOTOOL
+	bool "xdotool"
+	depends on BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_XLIB_LIBXINERAMA
+	select BR2_PACKAGE_LIBXKBCOMMON
+	select BR2_PACKAGE_XLIB_LIBX11
+	help
+	  Command-line X11 automation tool
+
+	  http://www.semicomplete.com/projects/xdotool
diff --git a/package/xdotool/xdotool.hash b/package/xdotool/xdotool.hash
new file mode 100644
index 0000000..f8adcd5
--- /dev/null
+++ b/package/xdotool/xdotool.hash
@@ -0,0 +1,2 @@ 
+# locally computed hash
+sha256 b097ef0e3897d1a24e3f45f0faed58329742d3d9434b9b46eb97eb1040f999bf  xdotool-v3.20150503.1.tar.gz
diff --git a/package/xdotool/xdotool.mk b/package/xdotool/xdotool.mk
new file mode 100644
index 0000000..7e9ae0a
--- /dev/null
+++ b/package/xdotool/xdotool.mk
@@ -0,0 +1,24 @@ 
+################################################################################
+#
+# xdotool
+#
+################################################################################
+
+XDOTOOL_VERSION = v3.20150503.1
+XDOTOOL_SITE = $(call github,jordansissel,xdotool,$(XDOTOOL_VERSION))
+XDOTOOL_LICENSE = custom
+XDOTOOL_LICENSE_FILES = COPYRIGHT
+XDOTOOL_DEPENDENCIES = xlib_libXtst xlib_libXinerama libxkbcommon xlib_libX11
+
+define XDOTOOL_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+# Avoid 'install' target to skip 'post-install' which runs ldconfig on host
+define XDOTOOL_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		pre-install installlib installprog installheader \
+		PREFIX="$(TARGET_DIR)/usr"
+endef
+
+$(eval $(generic-package))