From patchwork Mon Dec 28 21:23:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 561398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 18D31140213 for ; Tue, 29 Dec 2015 08:23:50 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=a5ZG2Ea+; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 06B32A558A; Mon, 28 Dec 2015 21:23:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q6gm9VbMM0mq; Mon, 28 Dec 2015 21:23:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5ED0CA550A; Mon, 28 Dec 2015 21:23:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id AB0781CF1F1 for ; Mon, 28 Dec 2015 21:23:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A7FACA550A for ; Mon, 28 Dec 2015 21:23:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K9rim2qJgAXl for ; Mon, 28 Dec 2015 21:23:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by fraxinus.osuosl.org (Postfix) with ESMTPS id B05E18B0EF for ; Mon, 28 Dec 2015 21:23:45 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id l65so16764350wmf.1 for ; Mon, 28 Dec 2015 13:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j5kNK3Ktszdp3Ri2LEcN4HGZnsKJaXyNqLs1AkRHihw=; b=a5ZG2Ea+ZmdUwqks+QF48/Ie0SHw3cVC+nNYqzkMTHwKxA8e1EOxqjXecDVTK4FtFj ZC1D0IzH2MZh47rT9Y6eBq+ZLRjTtqQHcyrE/2V2G+rDUBCbFVyTBjiJQDnwOdbj7r0/ J1qSiUKZic9f8px9UC+bPdue7f6xRLwoasFNJNIZfdr8i25uTPkbFneeb6fuyrv9F2nM 0bQ7RnTCddKAoAVIz6XZw1OT6yAuBGpAlOHxCzBovtpMSoarhMMTBeObg+9aoSpNlkcC caFm5VeWziGc6Xv+WGuLZjOg7kA4Z0xQjNQLK7bucbkUWQazTA2Tv1nn8Rk/A/3Qq4BH Q3Eg== X-Received: by 10.28.1.23 with SMTP id 23mr3533099wmb.37.1451337824399; Mon, 28 Dec 2015 13:23:44 -0800 (PST) Received: from atlas.localdomain (sch74-1-88-184-220-198.fbx.proxad.net. [88.184.220.198]) by smtp.gmail.com with ESMTPSA id pn6sm58415422wjb.15.2015.12.28.13.23.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Dec 2015 13:23:43 -0800 (PST) From: Romain Naour To: buildroot@buildroot.org Date: Mon, 28 Dec 2015 22:23:33 +0100 Message-Id: <1451337814-16379-2-git-send-email-romain.naour@gmail.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1451337814-16379-1-git-send-email-romain.naour@gmail.com> References: <1451337814-16379-1-git-send-email-romain.naour@gmail.com> Cc: Romain Naour Subject: [Buildroot] [PATCH v2 2/3] package/gtkmm3: reorder select/depends X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Romain Naour From [1]: "Even though the ordering has absolutely no consequences in Kconfig, it is not logical (when reading). It is more logical and far easier to understand when depends come first, followed by the selects." Also, the Config.in exemple in the manual suggest to use this coding style [2]. [1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html [2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in Signed-off-by: Romain Naour --- package/gtkmm3/Config.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package/gtkmm3/Config.in b/package/gtkmm3/Config.in index 30d3492..f617d83 100644 --- a/package/gtkmm3/Config.in +++ b/package/gtkmm3/Config.in @@ -1,17 +1,17 @@ config BR2_PACKAGE_GTKMM3 bool "gtkmm3" - select BR2_PACKAGE_ATKMM - select BR2_PACKAGE_CAIROMM - select BR2_PACKAGE_GLIBMM - select BR2_PACKAGE_LIBGTK3 - select BR2_PACKAGE_LIBSIGC - select BR2_PACKAGE_PANGOMM depends on BR2_ARCH_HAS_ATOMICS # libcairomm/libgtk3/libpangomm -> cairo depends on BR2_INSTALL_LIBSTDCPP # glibmm, libpangomm -> glibmm/pango depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 depends on BR2_TOOLCHAIN_HAS_THREADS # *mm/libgtk3 -> libglib2 depends on BR2_USE_MMU # *mm/libgtk3 -> libglib2 depends on BR2_USE_WCHAR # *mm/libgtk3 -> libglib2 + select BR2_PACKAGE_ATKMM + select BR2_PACKAGE_CAIROMM + select BR2_PACKAGE_GLIBMM + select BR2_PACKAGE_LIBGTK3 + select BR2_PACKAGE_LIBSIGC + select BR2_PACKAGE_PANGOMM help The gtkmm3 package is a set of C++ bindings for GTK 3.