diff mbox

[v3,1/2] assimp: new package

Message ID 1450390699-10377-1-git-send-email-ps.report@gmx.net
State Accepted
Headers show

Commit Message

Peter Seiderer Dec. 17, 2015, 10:18 p.m. UTC
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
----
Changes v1 -> v2:
  - use github helper (thanks to Jörg Krause)

Changes v2 -> v3:
  - add c++ dependency (suggested by Thomas Petazzoni)
  - fix linking problem with builtin zlib (linking code
    with/without '-fpic' compiled, see e.g. [2]), workaround by selecting
    buildroot zlib package (failure detected by Thomas Petazzoni [2])

[1] https://cmake.org/pipermail/cmake/2006-March/008482.html
[2] http://lists.busybox.net/pipermail/buildroot/2015-December/146859.html
---
 package/Config.in        |  1 +
 package/assimp/Config.in | 14 ++++++++++++++
 package/assimp/assimp.mk | 16 ++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/assimp/Config.in
 create mode 100644 package/assimp/assimp.mk

Comments

Thomas Petazzoni Dec. 30, 2015, 4:05 p.m. UTC | #1
Dear Peter Seiderer,

On Thu, 17 Dec 2015 23:18:18 +0100, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ----
> Changes v1 -> v2:
>   - use github helper (thanks to Jörg Krause)

This package is causing some build failures:

  http://autobuild.buildroot.org/?reason=assimp-v3.2

They all look similar. I guess it's because assimp needs C++11 support.
Can you have a look ?

Thanks,

Thomas
Thomas Petazzoni Dec. 30, 2015, 10:02 p.m. UTC | #2
Hello,

On Wed, 30 Dec 2015 17:05:47 +0100, Thomas Petazzoni wrote:

> This package is causing some build failures:
> 
>   http://autobuild.buildroot.org/?reason=assimp-v3.2
> 
> They all look similar. I guess it's because assimp needs C++11 support.
> Can you have a look ?

One of the issue is different though:

  http://autobuild.buildroot.org/results/79e/79edc3a8c7bcc5a7ffb433bf1ecb645050e2f044/build-end.log

Thanks for your feedback,

Thomas
Peter Seiderer Jan. 11, 2016, 9:56 p.m. UTC | #3
Hello Thomas,

On Wed, 30 Dec 2015 17:05:47 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Dear Peter Seiderer,
> 
> On Thu, 17 Dec 2015 23:18:18 +0100, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ----
> > Changes v1 -> v2:
> >   - use github helper (thanks to Jörg Krause)
> 
> This package is causing some build failures:
> 
>   http://autobuild.buildroot.org/?reason=assimp-v3.2
> 
> They all look similar. I guess it's because assimp needs C++11 support.
> Can you have a look ?

O.k, will have a look at it...

Regards,
Peter

> 
> Thanks,
> 
> Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index bdc3063..b8e13e0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -796,6 +796,7 @@  menu "Filesystem"
 endmenu
 
 menu "Graphics"
+	source "package/assimp/Config.in"
 	source "package/atk/Config.in"
 	source "package/bullet/Config.in"
 	source "package/cairo/Config.in"
diff --git a/package/assimp/Config.in b/package/assimp/Config.in
new file mode 100644
index 0000000..35e2f23
--- /dev/null
+++ b/package/assimp/Config.in
@@ -0,0 +1,14 @@ 
+config BR2_PACKAGE_ASSIMP
+	bool "assimp"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_ZLIB
+	help
+	  Open Asset Import Library (assimp) is a portable Open Source
+	  library to import various well-known 3D model formats in a uniform
+	  manner. The most recent version also knows how to export 3d files
+	  and is therefore suitable as a general-purpose 3D model converter.
+
+	  http://www.assimp.org
+
+comment "assimp needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/assimp/assimp.mk b/package/assimp/assimp.mk
new file mode 100644
index 0000000..fd556e5
--- /dev/null
+++ b/package/assimp/assimp.mk
@@ -0,0 +1,16 @@ 
+################################################################################
+#
+# assimp
+#
+################################################################################
+
+ASSIMP_VERSION = v3.2
+ASSIMP_SITE = $(call github,assimp,assimp,$(ASSIMP_VERSION))
+ASSIMP_LICENSE = BSD-3c
+ASSIMP_LICENSE_FILES = LICENSE
+ASSIMP_DEPENDENCIES = zlib
+ASSIMP_INSTALL_STAGING = YES
+
+ASSIMP_CONF_OPTS += -DASSIMP_BUILD_TESTS=OFF
+
+$(eval $(cmake-package))