From patchwork Fri Oct 16 09:56:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vicente Olivert Riera X-Patchwork-Id: 531179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 5719D1402D5 for ; Fri, 16 Oct 2015 20:56:24 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 8723A91415; Fri, 16 Oct 2015 09:56:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LCda4SG+Rc4g; Fri, 16 Oct 2015 09:56:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id A9C589142E; Fri, 16 Oct 2015 09:56:22 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id A73FB1C16BD for ; Fri, 16 Oct 2015 09:56:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A35EDA397B for ; Fri, 16 Oct 2015 09:56:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WYLUiJQX8-8v for ; Fri, 16 Oct 2015 09:56:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5AC2BA3971 for ; Fri, 16 Oct 2015 09:56:20 +0000 (UTC) Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 088058A2BE2B3 for ; Fri, 16 Oct 2015 10:56:12 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 16 Oct 2015 10:56:13 +0100 Received: from localhost.localdomain (192.168.154.63) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Fri, 16 Oct 2015 10:56:13 +0100 From: Vicente Olivert Riera To: Date: Fri, 16 Oct 2015 10:56:09 +0100 Message-ID: <1444989369-34046-1-git-send-email-Vincent.Riera@imgtec.com> X-Mailer: git-send-email 1.7.1 MIME-Version: 1.0 X-Originating-IP: [192.168.154.63] Subject: [Buildroot] [PATCH] ffmpeg: librtmp support depends on openssl X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" If you try to build ffmpeg with librtmp support and you don't have openssl installed in your system, the configure script will fail with an error like this one: ERROR: librtmp not found using pkg-config This message doesn't highlight the real problem, but a deeper look into the config.log will reveal the dependency between librtmp and openssl: check_pkg_config librtmp librtmp/rtmp.h RTMP_Socket /br/output/host/usr/bin/pkg-config --exists --print-errors librtmp Package libssl was not found in the pkg-config search path. Perhaps you should add the directory containing `libssl.pc' to the PKG_CONFIG_PATH environment variable Package 'libssl', required by 'librtmp', not found Package 'libcrypto', required by 'librtmp', not found ERROR: librtmp not found using pkg-config So let's enable librtmp support only when openssl support has already been enabled. Fixes: http://autobuild.buildroot.net/results/ae0/ae0c4bab7975ed2ad77a9f9fd6a300d1327d56b9/ Signed-off-by: Vicente Olivert Riera --- package/ffmpeg/ffmpeg.mk | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk index f361970..d4c28e0 100644 --- a/package/ffmpeg/ffmpeg.mk +++ b/package/ffmpeg/ffmpeg.mk @@ -198,6 +198,13 @@ FFMPEG_CONF_OPTS += --disable-openssl else FFMPEG_CONF_OPTS += --enable-openssl FFMPEG_DEPENDENCIES += openssl +# librtmp support requires openssl +ifeq ($(BR2_PACKAGE_RTMPDUMP),y) +FFMPEG_CONF_OPTS += --enable-librtmp +FFMPEG_DEPENDENCIES += rtmpdump +else +FFMPEG_CONF_OPTS += --disable-librtmp +endif endif else FFMPEG_CONF_OPTS += --disable-openssl @@ -246,13 +253,6 @@ else FFMPEG_CONF_OPTS += --disable-libbluray endif -ifeq ($(BR2_PACKAGE_RTMPDUMP),y) -FFMPEG_CONF_OPTS += --enable-librtmp -FFMPEG_DEPENDENCIES += rtmpdump -else -FFMPEG_CONF_OPTS += --disable-librtmp -endif - ifeq ($(BR2_PACKAGE_LAME),y) FFMPEG_CONF_OPTS += --enable-libmp3lame FFMPEG_DEPENDENCIES += lame