| Message ID | 1444203799-16230-3-git-send-email-gwenj@trabucayre.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Oct 7, 2015 at 9:43 AM, Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote: > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > > Some gnuradio python blocks needs python-numpy present. > > Without python-numpy, gnuradio-python based apps fails, on runtime, with traceback like: > > Traceback (most recent call last): > File "./top_block.py", line 18, in <module> > from gnuradio import analog > File "/usr/lib/python2.7/site-packages/gnuradio/analog/__init__.py", line 35, in <module> > from am_demod import * > File "/usr/lib/python2.7/site-packages/gnuradio/analog/am_demod.py", line 22, in <module> > from gnuradio import gr > File "/usr/lib/python2.7/site-packages/gnuradio/gr/__init__.py", line 44, in <module> > from top_block import * > File "/usr/lib/python2.7/site-packages/gnuradio/gr/top_block.py", line 30, in <module> > from hier_block2 import hier_block2 > File "/usr/lib/python2.7/site-packages/gnuradio/gr/hier_block2.py", line 26, in <module> > import pmt > File "/usr/lib/python2.7/site-packages/pmt/__init__.py", line 58, in <module> > from pmt_to_python import pmt_to_python as to_python > File "/usr/lib/python2.7/site-packages/pmt/pmt_to_python.py", line 22, in <module> > import numpy > ImportError: No module named numpy > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Dear Gwenhael Goavec-Merou, On Wed, 7 Oct 2015 09:43:19 +0200, Gwenhael Goavec-Merou wrote: > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > > Some gnuradio python blocks needs python-numpy present. > > Without python-numpy, gnuradio-python based apps fails, on runtime, with traceback like: > > Traceback (most recent call last): > File "./top_block.py", line 18, in <module> > from gnuradio import analog > File "/usr/lib/python2.7/site-packages/gnuradio/analog/__init__.py", line 35, in <module> > from am_demod import * > File "/usr/lib/python2.7/site-packages/gnuradio/analog/am_demod.py", line 22, in <module> > from gnuradio import gr > File "/usr/lib/python2.7/site-packages/gnuradio/gr/__init__.py", line 44, in <module> > from top_block import * > File "/usr/lib/python2.7/site-packages/gnuradio/gr/top_block.py", line 30, in <module> > from hier_block2 import hier_block2 > File "/usr/lib/python2.7/site-packages/gnuradio/gr/hier_block2.py", line 26, in <module> > import pmt > File "/usr/lib/python2.7/site-packages/pmt/__init__.py", line 58, in <module> > from pmt_to_python import pmt_to_python as to_python > File "/usr/lib/python2.7/site-packages/pmt/pmt_to_python.py", line 22, in <module> > import numpy > ImportError: No module named numpy > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > --- > Changes v5 -> v6: > * add space between # and runtime > Changes v4 -> v5: > * Re-add BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS > Changes v3 -> v4: > * add #runtime comment to BR2_PACKAGE_PYTHON_NUMPY select; > * suppress python-numpy in GNURADIO_DEPENDENCIES variable (not needed for > buildtime) > Changes v2 -> v3: > * Since commit 826a2bc18bc0be0b08f2926c9fa1819fe909557c no special attentions > is needed to select python-numpy. So BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS > is no more needed > Changes v1 -> v2: > * Add dependy to BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS; > * gnuradio-python select numpy; > * gnuradio-utils select again gnuradio-python; > * fix commit message > --- > package/gnuradio/Config.in | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. Thomas
Hello, On Wed, 7 Oct 2015 09:43:19 +0200, Gwenhael Goavec-Merou wrote: > From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com> > > Some gnuradio python blocks needs python-numpy present. > > Without python-numpy, gnuradio-python based apps fails, on runtime, with traceback like: Gwenhael, Samuel, did you really test this patch? It causes some clearly visible warnings when running "make menuconfig" : package/python/Config.in:5:error: recursive dependency detected! package/python/Config.in:5: symbol BR2_PACKAGE_PYTHON is selected by BR2_PACKAGE_GNURADIO_PYTHON package/gnuradio/Config.in:46: symbol BR2_PACKAGE_GNURADIO_PYTHON is selected by BR2_PACKAGE_GNURADIO_UTILS package/gnuradio/Config.in:55: symbol BR2_PACKAGE_GNURADIO_UTILS depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS package/python-numpy/Config.in:1: symbol BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS depends on BR2_PACKAGE_PYTHON I had to fix that up through a separate following commit http://git.buildroot.net/buildroot/commit/?id=ef531c6ded27b62462c74b964fad8f5c337da3a2, but I would have preferred the patch to not contain such an obvious issue. Thanks, Thomas
diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in index e264a21..f188d87 100644 --- a/package/gnuradio/Config.in +++ b/package/gnuradio/Config.in @@ -45,13 +45,16 @@ config BR2_PACKAGE_GNURADIO_FEC config BR2_PACKAGE_GNURADIO_PYTHON bool "python support" + depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS select BR2_PACKAGE_BOOST_PYTHON select BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON_NUMPY # runtime help Enable python component config BR2_PACKAGE_GNURADIO_UTILS bool "gr-utils support" + depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS select BR2_PACKAGE_GNURADIO_PYTHON help Misc python utilities