From patchwork Mon Sep 7 20:47:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Marie?= X-Patchwork-Id: 515247 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 994A914018C for ; Tue, 8 Sep 2015 06:47:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=openmailbox.org header.i=@openmailbox.org header.b=oPT1icfT; dkim=fail reason="signature verification failed" (1024-bit key) header.d=openmailbox.org header.i=@openmailbox.org header.b=VRBY4VSJ; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C94F9A3BA9; Mon, 7 Sep 2015 20:47:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v_Mh6fCq9DcV; Mon, 7 Sep 2015 20:47:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 04BECA3BA5; Mon, 7 Sep 2015 20:47:55 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 187FF1C160E for ; Mon, 7 Sep 2015 20:47:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 13AD08A1E4 for ; Mon, 7 Sep 2015 20:47:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DrjM4MYa2UeI for ; Mon, 7 Sep 2015 20:47:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail2.openmailbox.org (mail2.openmailbox.org [62.4.1.33]) by whitealder.osuosl.org (Postfix) with ESMTPS id 812E29238F for ; Mon, 7 Sep 2015 20:47:51 +0000 (UTC) Received: by mail2.openmailbox.org (Postfix, from userid 1004) id 123AC2AC1512; Mon, 7 Sep 2015 22:47:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1441658869; bh=a5Id3xxXnaVIYYrMJh7QA0IL1zLJ0r3BcDUaEO/45mI=; h=From:To:Cc:Subject:Date:From; b=oPT1icfTRWWlYbG3u2Ot9BGk2gtQmmk3fDJP1RTzWvSolEcO5GGg925/BtfqfwHaH cTjrPUFzJmSm8WDuyeBsbbyGs/M1vRWNRsWU6JHmmvDWbzPBcBIzNdvI/62nDsc3PD ueqvkLXng776qFVfCfygKCKhtsGOMN04YjpljqRg= From: =?UTF-8?q?C=C3=A9dric=20Marie?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org; s=openmailbox; t=1441658861; bh=a5Id3xxXnaVIYYrMJh7QA0IL1zLJ0r3BcDUaEO/45mI=; h=From:To:Cc:Subject:Date:From; b=VRBY4VSJ1arDaUlVIdok7kX7BnqVm1WgYBvgrxorLXvl8fXQ6TUjDsVncdSDxeNBM zMz+VeHx5RYB+ulrJHHx95VddyrNeN1E4IVPzArVXkXe/qt1mRJv5VTMSBJcQpvER5 MOwpDYiqRsEVoqqWFxUca068XJgoNS2kGcY69y/A= To: buildroot@busybox.net Date: Mon, 7 Sep 2015 22:47:26 +0200 Message-Id: <1441658846-5786-1-git-send-email-cedric.marie@openmailbox.org> X-Mailer: git-send-email 2.5.1 MIME-Version: 1.0 Cc: =?UTF-8?q?C=C3=A9dric=20Marie?= Subject: [Buildroot] [PATCH] Makefile: Remove KBUILD_VERBOSE and quiet X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" KBUILD_VERBOSE and quiet variables are set and exported, but they are not used. We can safely remove them. These variables are inherited from the Makefile of the Linux kernel, and are not used in Buildroot. In support/scripts/mkmakefile, quiet value is checked, but the test is always true (quiet is never set to silent_), so the test can be removed as well. Signed-off-by: Cédric Marie Acked-by: Arnout Vandecappelle (Essensium/Mind) Tested-by: Arnout Vandecappelle (Essensium/Mind) --- Makefile | 20 ++++++-------------- support/scripts/mkmakefile | 4 +--- 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/Makefile b/Makefile index 23e2ee6..05dd2db 100644 --- a/Makefile +++ b/Makefile @@ -218,23 +218,15 @@ endif # To put more focus on warnings, be less verbose as default # Use 'make V=1' to see the full commands +Q = @ ifeq ("$(origin V)", "command line") - KBUILD_VERBOSE = $(V) -endif -ifndef KBUILD_VERBOSE - KBUILD_VERBOSE = 0 -endif - -ifeq ($(KBUILD_VERBOSE),1) - quiet = - Q = +ifeq ($(V),1) +Q = ifndef VERBOSE - VERBOSE = 1 +VERBOSE = 1 endif export VERBOSE -else - quiet = quiet_ - Q = @ +endif endif # we want bash as shell @@ -245,7 +237,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \ # kconfig uses CONFIG_SHELL CONFIG_SHELL := $(SHELL) -export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE +export SHELL CONFIG_SHELL Q ifndef HOSTAR HOSTAR := ar diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile index 833be6a..37162a3 100755 --- a/support/scripts/mkmakefile +++ b/support/scripts/mkmakefile @@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile then exit 0 fi -if [ "${quiet}" != "silent_" ]; then - echo " GEN $2/Makefile" -fi +echo " GEN $2/Makefile" cat << EOF > $2/Makefile # Automatically generated by $0: don't edit