diff mbox

[2/3] Fix elf2flt build when LTO is enabled

Message ID 1441470809-23403-1-git-send-email-public.douglas.raillard@gmail.com
State Superseded
Headers show

Commit Message

Douglas RAILLARD Sept. 5, 2015, 4:33 p.m. UTC 
Signed-off-by: Douglas RAILLARD <public.douglas.raillard@gmail.com>
---
 package/elf2flt/elf2flt.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni Sept. 6, 2015, 1:24 p.m. UTC | #1 
Dear Douglas RAILLARD,

On Sat,  5 Sep 2015 18:33:29 +0200, Douglas RAILLARD wrote:

> diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
> index 3fcada4..d028259 100644
> --- a/package/elf2flt/elf2flt.mk
> +++ b/package/elf2flt/elf2flt.mk
> @@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
>  	--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
>  	--target=$(GNU_TARGET_NAME)
>  
> +

Unnecessary new line addition.

>  HOST_ELF2FLT_CONF_ENV = LIBS=-lz
>  
> +ifeq ($(BR2_GCC_ENABLE_LTO),y)
> +	HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"

Don't intend variables.

Also, please change this to:

HOST_ELF2FLT_LIBS = -lz

ifeq ($(BR2_GCC_ENABLE_LTO),y)
HOST_ELF2FLT_LIBS += -ldl
endif

HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
index 3fcada4..d028259 100644
--- a/package/elf2flt/elf2flt.mk
+++ b/package/elf2flt/elf2flt.mk
@@ -21,6 +21,12 @@  HOST_ELF2FLT_CONF_OPTS = \
 	--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
 	--target=$(GNU_TARGET_NAME)
 
+
 HOST_ELF2FLT_CONF_ENV = LIBS=-lz
 
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+	HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"
+endif
+
+
 $(eval $(host-autotools-package))