diff mbox

[4/7,v2] pkg-cmake: add PKG_CONFIG_* variables to help cmake find host packages

Message ID 1436458921-4199-5-git-send-email-sylvain.raybaud@green-communications.fr
State Changes Requested
Headers show

Commit Message

Sylvain Raybaud July 9, 2015, 4:21 p.m. UTC
Signed-off-by: Sylvain Raybaud <sylvain.raybaud@green-communications.fr>
---
 package/pkg-cmake.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Samuel Martin July 10, 2015, 10:47 p.m. UTC | #1
Hi Sylvain,

On Thu, Jul 9, 2015 at 6:21 PM, Sylvain Raybaud
<sylvain.raybaud@green-communications.fr> wrote:
> Signed-off-by: Sylvain Raybaud <sylvain.raybaud@green-communications.fr>
> ---
>  package/pkg-cmake.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index f17a883..a757a2b 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -111,6 +111,8 @@ define $(2)_CONFIGURE_CMDS
>         cd $$($$(PKG)_BUILDDIR) && \
>         rm -f CMakeCache.txt && \
>         PATH=$$(BR_PATH) \
> +       PKG_CONFIG_PATH='$$(HOST_DIR)/usr/lib/pkgconfig' \
> +       PKG_CONFIG_SYSROOT_DIR='$$(HOST_DIR)' \
The PKG_CONFIG_SYSROOT_DIR is wrong.

Anyway, these settings should be set the same way they are for
host-autotools packages, see [1].

>         $$(HOST_DIR)/usr/bin/cmake $$($$(PKG)_SRCDIR) \
>                 -DCMAKE_INSTALL_SO_NO_EXE=0 \
>                 -DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[1] http://git.buildroot.net/buildroot/tree/package/Makefile.in#n304

Regards,
diff mbox

Patch

diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index f17a883..a757a2b 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -111,6 +111,8 @@  define $(2)_CONFIGURE_CMDS
 	cd $$($$(PKG)_BUILDDIR) && \
 	rm -f CMakeCache.txt && \
 	PATH=$$(BR_PATH) \
+	PKG_CONFIG_PATH='$$(HOST_DIR)/usr/lib/pkgconfig' \
+	PKG_CONFIG_SYSROOT_DIR='$$(HOST_DIR)' \
 	$$(HOST_DIR)/usr/bin/cmake $$($$(PKG)_SRCDIR) \
 		-DCMAKE_INSTALL_SO_NO_EXE=0 \
 		-DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \