From patchwork Sat Feb 28 18:15:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 444659 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id B53BF14012A for ; Sun, 1 Mar 2015 05:15:44 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2B4DC91CAA; Sat, 28 Feb 2015 18:15:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0tQeyn3+x6xs; Sat, 28 Feb 2015 18:15:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id B164C91BE1; Sat, 28 Feb 2015 18:15:33 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id C00A71BF978 for ; Sat, 28 Feb 2015 18:15:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BD45D9510C for ; Sat, 28 Feb 2015 18:15:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R3AeemPSHfd1 for ; Sat, 28 Feb 2015 18:15:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by hemlock.osuosl.org (Postfix) with ESMTP id 23A0B950DC for ; Sat, 28 Feb 2015 18:15:25 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id F2AB75D5; Sat, 28 Feb 2015 19:15:30 +0100 (CET) Received: from localhost (unknown [37.162.115.79]) by mail.free-electrons.com (Postfix) with ESMTPSA id AF80577; Sat, 28 Feb 2015 19:15:30 +0100 (CET) From: Thomas Petazzoni To: buildroot@uclibc.org Date: Sat, 28 Feb 2015 19:15:09 +0100 Message-Id: <1425147313-17380-4-git-send-email-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425147313-17380-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1425147313-17380-1-git-send-email-thomas.petazzoni@free-electrons.com> Cc: Thomas Petazzoni Subject: [Buildroot] [PATCH 3/7] pkg-generic: take into account _EXTRA_DOWNLOADS to display "Downloading" message X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The .stamp_downloaded target displays the "Downloading" message even if there is really something to download. However, this logic only checks for _SOURCE and _PATCH: it does not check if something needs to be downloaded in _EXTRA_DOWNLOADS. This commit fixes that, which makes sure that the "Downloading" message is displayed if one of the items in _EXTRA_DOWNLOADS has not yet been downloaded. Signed-off-by: Thomas Petazzoni Reviewed-by: Romain Naour Reviewed-by: Arnout Vandecappelle (Essensium/Mind) --- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 1482194..0098b29 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -76,7 +76,7 @@ ifeq ($(DL_MODE),DOWNLOAD) $(Q)if test ! -e $(DL_DIR)/$($(PKG)_SOURCE); then \ $(call MESSAGE,"Downloading") ; \ else \ - for p in $($(PKG)_PATCH) ; do \ + for p in $($(PKG)_PATCH) $($(PKG)_EXTRA_DOWNLOADS) ; do \ if test ! -e $(DL_DIR)/`basename $$p` ; then \ $(call MESSAGE,"Downloading") ; \ break ; \