From patchwork Wed Dec 3 22:05:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 417576 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 4781E14003E for ; Thu, 4 Dec 2014 09:05:51 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7C039A3525; Wed, 3 Dec 2014 22:05:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FwOFlrHleI7W; Wed, 3 Dec 2014 22:05:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id D2B16A3519; Wed, 3 Dec 2014 22:05:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D0B2A1C2855 for ; Wed, 3 Dec 2014 22:05:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CBFCE32EBF for ; Wed, 3 Dec 2014 22:05:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VTfUc7Olr3Fo for ; Wed, 3 Dec 2014 22:05:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by silver.osuosl.org (Postfix) with ESMTP id 277972F33B for ; Wed, 3 Dec 2014 22:05:47 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 3AEB364C; Wed, 3 Dec 2014 23:05:46 +0100 (CET) Received: from localhost (AToulouse-657-1-1136-181.w92-156.abo.wanadoo.fr [92.156.162.181]) by mail.free-electrons.com (Postfix) with ESMTPSA id E324464A; Wed, 3 Dec 2014 23:05:45 +0100 (CET) From: Thomas Petazzoni To: buildroot@uclibc.org Date: Wed, 3 Dec 2014 23:05:44 +0100 Message-Id: <1417644344-3116-1-git-send-email-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 2.1.0 Cc: Thomas Petazzoni Subject: [Buildroot] [PATCHv2] qtuio: add error handling to for loop X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Also remove unneeded sub-shell usage in the build and installation steps. It is kept for the configure step as it is actually useful, and works fine because "|| exit 1" is outside the sub-shell. Signed-off-by: Thomas Petazzoni Acked-by: "Yann E. MORIN" --- Changes v1 -> v2: * Remove unneeded sub-shell usage, noticed by Yann E. Morin. Signed-off-by: Thomas Petazzoni --- package/qtuio/qtuio.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/qtuio/qtuio.mk b/package/qtuio/qtuio.mk index 9925f84..5fa10a7 100644 --- a/package/qtuio/qtuio.mk +++ b/package/qtuio/qtuio.mk @@ -19,7 +19,7 @@ QTUIO_EXAMPLES = dials fingerpaint knobs pinchzoom ifeq ($(BR2_QTUIO_EXAMPLES),y) define QTUIO_CONFIGURE_EXAMPLES for example in $(QTUIO_EXAMPLES) ; do \ - (cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) ; \ + (cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) || exit 1; \ done endef endif @@ -32,7 +32,7 @@ endef ifeq ($(BR2_QTUIO_EXAMPLES),y) define QTUIO_BUILD_EXAMPLES for example in $(QTUIO_EXAMPLES) ; do \ - ($(MAKE) -C $(@D)/examples/$${example}) ; \ + $(MAKE) -C $(@D)/examples/$${example} || exit 1; \ done endef endif @@ -46,7 +46,7 @@ endef ifeq ($(BR2_QTUIO_EXAMPLES),y) define QTUIO_INSTALL_EXAMPLES for example in $(QTUIO_EXAMPLES) ; do \ - ($(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example}) ; \ + $(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example} || exit 1 ; \ done endef endif