diff mbox

[07/10] dhcp: install dhclient to /sbin

Message ID 1415969096-3032-8-git-send-email-gustavo@zacarias.com.ar
State Superseded
Headers show

Commit Message

Gustavo Zacarias Nov. 14, 2014, 12:44 p.m. UTC
Debian ifupdown uses an explicit call to /sbin/dhclient.
Busybox ifupdown uses the search path.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/dhcp/dhcp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnout Vandecappelle Nov. 14, 2014, 10:17 p.m. UTC | #1
On 14/11/14 13:44, Gustavo Zacarias wrote:
> Debian ifupdown uses an explicit call to /sbin/dhclient.
> Busybox ifupdown uses the search path.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/dhcp/dhcp.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 27fb60b..1eb6b32 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -59,7 +59,7 @@ define DHCP_INSTALL_CLIENT
>  	mkdir -p $(TARGET_DIR)/var/lib
>  	(cd $(TARGET_DIR)/var/lib; ln -snf /tmp dhcp)
>  	$(INSTALL) -m 0755 -D $(DHCP_DIR)/client/dhclient \
> -		$(TARGET_DIR)/usr/sbin/dhclient
> +		$(TARGET_DIR)/sbin/dhclient

 Then you should also update network-manager.mk:

NETWORK_MANAGER_CONF_OPTS += --with-dhclient=/usr/sbin/dhclient


 Regards,
 Arnout

>  	$(INSTALL) -m 0644 -D package/dhcp/dhclient.conf \
>  		$(TARGET_DIR)/etc/dhcp/dhclient.conf
>  	$(INSTALL) -m 0755 -D package/dhcp/dhclient-script \
>
Gustavo Zacarias Nov. 14, 2014, 10:27 p.m. UTC | #2
On 11/14/2014 07:17 PM, Arnout Vandecappelle wrote:

>> --- a/package/dhcp/dhcp.mk
>> +++ b/package/dhcp/dhcp.mk
>> @@ -59,7 +59,7 @@ define DHCP_INSTALL_CLIENT
>>  	mkdir -p $(TARGET_DIR)/var/lib
>>  	(cd $(TARGET_DIR)/var/lib; ln -snf /tmp dhcp)
>>  	$(INSTALL) -m 0755 -D $(DHCP_DIR)/client/dhclient \
>> -		$(TARGET_DIR)/usr/sbin/dhclient
>> +		$(TARGET_DIR)/sbin/dhclient
> 
>  Then you should also update network-manager.mk:
> 
> NETWORK_MANAGER_CONF_OPTS += --with-dhclient=/usr/sbin/dhclient

Evidently nobody used it because it never worked out of the box (because
of the lack of a proper dhclient-script) ;)
I'll adjust it.
Regards.
diff mbox

Patch

diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
index 27fb60b..1eb6b32 100644
--- a/package/dhcp/dhcp.mk
+++ b/package/dhcp/dhcp.mk
@@ -59,7 +59,7 @@  define DHCP_INSTALL_CLIENT
 	mkdir -p $(TARGET_DIR)/var/lib
 	(cd $(TARGET_DIR)/var/lib; ln -snf /tmp dhcp)
 	$(INSTALL) -m 0755 -D $(DHCP_DIR)/client/dhclient \
-		$(TARGET_DIR)/usr/sbin/dhclient
+		$(TARGET_DIR)/sbin/dhclient
 	$(INSTALL) -m 0644 -D package/dhcp/dhclient.conf \
 		$(TARGET_DIR)/etc/dhcp/dhclient.conf
 	$(INSTALL) -m 0755 -D package/dhcp/dhclient-script \