From patchwork Wed Nov 12 15:04:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 410002 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 8724C1400D2 for ; Thu, 13 Nov 2014 02:04:58 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 44D84A2CB4; Wed, 12 Nov 2014 15:04:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WFGqBsdqA3Ml; Wed, 12 Nov 2014 15:04:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A9769A2CAE; Wed, 12 Nov 2014 15:04:56 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id AD13E1C2439 for ; Wed, 12 Nov 2014 15:04:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A7E6E2F4BE for ; Wed, 12 Nov 2014 15:04:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e+80h4-N5hD8 for ; Wed, 12 Nov 2014 15:04:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay.synopsys.com (smtprelay.synopsys.com [198.182.60.111]) by silver.osuosl.org (Postfix) with ESMTPS id 5F3FB2631B for ; Wed, 12 Nov 2014 15:04:54 +0000 (UTC) Received: from us01secmta2.synopsys.com (us01secmta2.synopsys.com [10.9.203.102]) by smtprelay.synopsys.com (Postfix) with ESMTP id 9AF0710C0EC2; Wed, 12 Nov 2014 07:04:53 -0800 (PST) Received: from us01secmta2.internal.synopsys.com (us01secmta2.internal.synopsys.com [127.0.0.1]) by us01secmta2.internal.synopsys.com (Service) with ESMTP id 8BF78A4112; Wed, 12 Nov 2014 07:04:53 -0800 (PST) Received: from mailhost.synopsys.com (unknown [10.13.184.66]) by us01secmta2.internal.synopsys.com (Service) with ESMTP id 5F9A3A4102; Wed, 12 Nov 2014 07:04:53 -0800 (PST) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 4E9B4786; Wed, 12 Nov 2014 07:04:53 -0800 (PST) Received: from abrodkin-8560l.internal.synopsys.com (unknown [10.121.8.116]) by mailhost.synopsys.com (Postfix) with ESMTP id 8A1E0773; Wed, 12 Nov 2014 07:04:51 -0800 (PST) From: Alexey Brodkin To: buildroot@buildroot.org Date: Wed, 12 Nov 2014 18:04:44 +0300 Message-Id: <1415804684-17297-1-git-send-email-abrodkin@synopsys.com> X-Mailer: git-send-email 1.9.3 Cc: Thomas Petazzoni , Alexey Brodkin , Khem Raj Subject: [Buildroot] [PATCH] uclibc: enable UCLIBC_HAS_STRING_GENERIC_OPT in all configs X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Description in uClibc for this optoin is: --->--- bool "Use faster (but larger) generic string functions" default y help Answer Y to use the (tweaked) glibc generic string functions. In general, they are faster (but 3-5K larger) than the base uClibc string functions which are optimized solely for size. Many people will answer Y. --->--- Additional 3-5K of size is not that important if resulting libuClibc.so is of size about 300k. But benefits in terms of performance could be pretty significant. For example on ARC in LMbench we see more than 3 times bump in some tests --->--- libc bcopy unaligned ... 8.39 - 6.76 (UCLIBC_HAS_STRING_GENERIC_OPT=no) 8.39 - 23.86 (UCLIBC_HAS_STRING_GENERIC_OPT=yes) --->--- Also since the option in question is default in uClibc I don't expect if enabled back (it was silently disabled in http://git.buildroot.net/buildroot/commit/?id=cfbf8abc33d86a0cf5c1bb3e0817a22009b7f301 on introduction of NPTL in uClibc by Khem Raj) it to introduce problems. Signed-off-by: Alexey Brodkin Cc: Thomas Petazzoni Cc: Anton Kolesov Cc: Peter Korsgaard Cc: Khem Raj --- package/uclibc/uClibc-0.9.31.config | 2 +- package/uclibc/uClibc-0.9.33.config | 2 +- package/uclibc/uClibc-snapshot.config | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package/uclibc/uClibc-0.9.31.config b/package/uclibc/uClibc-0.9.31.config index 76772e8..83df7d0 100644 --- a/package/uclibc/uClibc-0.9.31.config +++ b/package/uclibc/uClibc-0.9.31.config @@ -144,7 +144,7 @@ UCLIBC_HAS_LIBNSL_STUB=y # # String and Stdio Support # -# UCLIBC_HAS_STRING_GENERIC_OPT is not set +UCLIBC_HAS_STRING_GENERIC_OPT=y UCLIBC_HAS_STRING_ARCH_OPT=y UCLIBC_HAS_CTYPE_TABLES=y UCLIBC_HAS_CTYPE_SIGNED=y diff --git a/package/uclibc/uClibc-0.9.33.config b/package/uclibc/uClibc-0.9.33.config index 1b07d4a..88dc7fa 100644 --- a/package/uclibc/uClibc-0.9.33.config +++ b/package/uclibc/uClibc-0.9.33.config @@ -178,7 +178,7 @@ UCLIBC_HAS_LIBNSL_STUB=y # # String and Stdio Support # -# UCLIBC_HAS_STRING_GENERIC_OPT is not set +UCLIBC_HAS_STRING_GENERIC_OPT=y UCLIBC_HAS_STRING_ARCH_OPT=y UCLIBC_HAS_CTYPE_TABLES=y UCLIBC_HAS_CTYPE_SIGNED=y diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config index ffc1535..1f04561 100644 --- a/package/uclibc/uClibc-snapshot.config +++ b/package/uclibc/uClibc-snapshot.config @@ -183,7 +183,7 @@ UCLIBC_HAS_LIBNSL_STUB=y # # String and Stdio Support # -# UCLIBC_HAS_STRING_GENERIC_OPT is not set +UCLIBC_HAS_STRING_GENERIC_OPT=y UCLIBC_HAS_STRING_ARCH_OPT=y UCLIBC_HAS_CTYPE_TABLES=y UCLIBC_HAS_CTYPE_SIGNED=y