From patchwork Sun Nov 9 13:18:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 408560 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id EA2651400E7 for ; Mon, 10 Nov 2014 00:19:08 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 33ABB33CED; Sun, 9 Nov 2014 13:19:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aUaV4HQrQLWW; Sun, 9 Nov 2014 13:19:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id CEA8533BF1; Sun, 9 Nov 2014 13:19:02 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4C5781C1774 for ; Sun, 9 Nov 2014 13:18:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 45A3295F88 for ; Sun, 9 Nov 2014 13:18:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 890bbVoEEsQZ for ; Sun, 9 Nov 2014 13:18:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by hemlock.osuosl.org (Postfix) with ESMTP id A024095F76 for ; Sun, 9 Nov 2014 13:18:57 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 7A4D973A; Sun, 9 Nov 2014 14:19:01 +0100 (CET) Received: from localhost (132.230.147.77.rev.sfr.net [77.147.230.132]) by mail.free-electrons.com (Postfix) with ESMTPSA id 1A7CF4BF; Sun, 9 Nov 2014 14:19:01 +0100 (CET) From: Thomas Petazzoni To: Buildroot List Date: Sun, 9 Nov 2014 14:18:48 +0100 Message-Id: <1415539129-25721-3-git-send-email-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 2.0.0 In-Reply-To: <1415539129-25721-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1415539129-25721-1-git-send-email-thomas.petazzoni@free-electrons.com> Cc: Thomas Petazzoni , Alexey Brodkin Subject: [Buildroot] [PATCH 2/3] quota: remove dependency on util-linux X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The dependency on util-linux is only present in Config.in, and not in quota.mk, and quota indeed builds properly without util-linux. It could be a runtime dependency, but there is no indication that it is the case, and I don't see why quota would run-time depend on util-linux utilities. Looking back at when the quota package was introduced, in one of the preliminary patch, he following explanation was given by the original author: [Update: I added check for util-linux mount because it support usrquota and grpquota mount options.] But I still don't see why usrquota and grpquota mount options would be the source of a dependency of the quota utilities on util-linux. Here is what the util-linux mount man page says about those two mount options: grpquota|noquota|quota|usrquota These options are accepted but ignored. (However, quota utilities may react to such strings in /etc/fstab.) So indeed, the quota tools will look at /proc/mounts and see if those options are used for certain mount points, but that doesn't create a dependency of quota on util-linux. Therefore, this commit gets rid of the dependency of quota on util-linux. It allows to re-enable quota on Microblaze, since this dependency was inherited from util-linux. igned-off-by: Thomas Petazzoni Signed-off-by: Thomas Petazzoni --- package/quota/Config.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/package/quota/Config.in b/package/quota/Config.in index 69f03af..46a6c05 100644 --- a/package/quota/Config.in +++ b/package/quota/Config.in @@ -3,11 +3,7 @@ config BR2_PACKAGE_QUOTA depends on BR2_LARGEFILE depends on BR2_USE_WCHAR depends on BR2_USE_MMU # fork() - depends on !(BR2_microblazeel || BR2_microblazebe) # util-linux depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc - select BR2_PACKAGE_UTIL_LINUX - select BR2_PACKAGE_UTIL_LINUX_BINARIES - select BR2_PACKAGE_UTIL_LINUX_MOUNT select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC help @@ -16,7 +12,7 @@ config BR2_PACKAGE_QUOTA http://sourceforge.net/projects/linuxquota/ comment "quota needs a toolchain w/ largefile, wchar, threads" - depends on BR2_USE_MMU && !(BR2_microblazeel || BR2_microblazebe) + depends on BR2_USE_MMU depends on !BR2_LARGEFILE || \ !BR2_USE_WCHAR || \ !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)