From patchwork Tue Nov 4 13:04:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B6rg_Krause?= X-Patchwork-Id: 406604 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 162A71400A0 for ; Wed, 5 Nov 2014 00:04:42 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 29EC233791; Tue, 4 Nov 2014 13:04:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tVoq+024hH0P; Tue, 4 Nov 2014 13:04:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 431ED33356; Tue, 4 Nov 2014 13:04:39 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 7CA9A1C268C for ; Tue, 4 Nov 2014 13:04:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 79215914DC for ; Tue, 4 Nov 2014 13:04:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ep2UZYxYmRIv for ; Tue, 4 Nov 2014 13:04:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx02.posteo.de (mx02.posteo.de [89.146.194.165]) by whitealder.osuosl.org (Postfix) with ESMTPS id 07A159164E for ; Tue, 4 Nov 2014 13:04:35 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mx02.posteo.de (Postfix) with ESMTP id 5E37F25ACC52 for ; Tue, 4 Nov 2014 14:04:33 +0100 (CET) X-Virus-Scanned: amavisd-new at posteo.de Received: from posteo.de ([10.125.125.178]) (using TLS with cipher AES256-GCM-SHA384) by localhost (amavis1.posteo.de [10.125.125.165]) (amavisd-new, port 10026) with ESMTPS id 8BAAtVusjcAQ; Tue, 4 Nov 2014 14:04:16 +0100 (CET) Received: from mail.posteo.de (localhost [127.0.0.1]) by mail.posteo.de (Postfix) with ESMTPSA id 639AA2C0117; Tue, 4 Nov 2014 14:04:13 +0100 (CET) From: =?UTF-8?q?J=C3=B6rg=20Krause?= To: buildroot@buildroot.org Date: Tue, 4 Nov 2014 14:04:29 +0100 Message-Id: <1415106269-17526-1-git-send-email-jkrause@posteo.de> X-Mailer: git-send-email 2.1.3 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2 1/1] package/shairport-sync: fix avahi dependency X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" shairport-sync uses mDNS to pubish its service. This task is implemented (among others) in avahi and tinysvcmdns. To use avahi as the mDNS backend, shairport-sync requires libavahi-client or libdns_sd. Both will work, but libavahi-client is sufficient. To get libavahi-client support from avahi BR2_PACKAGE_AVAHI_DAEMON and BR2_PACKAGE_DBUS needs to be selected. Unfortunatly this is not immediately obvious if you've not checked avahis configure file. A BR2_PACKAGE_LIBAVAHI_CLIENT config symbol may help here for clarification, but is not present yet. Fixes autobuild errors: - http://autobuild.buildroot.net/results/a6a/a6ab7641a3cafcdaeffe11f08d5fcacbbb882d8d/ - http://autobuild.buildroot.net/results/cb4/cb41980f2fb416d627bea0950e1dae727eae0ca6/ - http://autobuild.buildroot.net/results/009/00929df01474813be576936e80e86374efdbc327/ - http://autobuild.buildroot.net/results/a40/a40b8cf9aaa4ade4d96524219276cfad2920104c/ - http://autobuild.buildroot.net/results/03f/03fff2805b3348f2557bbef73a716eadea3add03/ and some more. Signed-off-by: Jörg Krause --- Changes v1 -> v2: - check for avahi-daemon and dbus instead of libdns_sd to enable avahi support --- package/shairport-sync/shairport-sync.mk | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk index 8c345f2..da69171 100644 --- a/package/shairport-sync/shairport-sync.mk +++ b/package/shairport-sync/shairport-sync.mk @@ -13,8 +13,12 @@ SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libdaemon popt SHAIRPORT_SYNC_AUTORECONF = YES SHAIRPORT_SYNC_CONF_OPTS = --with-alsa # required -# Avahi or tinysvcmdns (shaiport-sync bundles its own version of tinysvcmdns) -ifeq ($(BR2_PACKAGE_AVAHI),y) +# Avahi or tinysvcmdns (shaiport-sync bundles its own version of tinysvcmdns). +# Avahi support needs libavahi-client, which is built by avahi if avahi-daemon +# and dbus is selected. Since there is no BR2_PACKAGE_LIBAVAHI_CLIENT config +# option yet, use the avahi-daemon and dbus congig symbols to check for +# libavahi-client. +ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy) SHAIRPORT_SYNC_DEPENDENCIES += avahi SHAIRPORT_SYNC_CONF_OPTS += --with-avahi else