| Message ID | 1414352079-17708-1-git-send-email-ezequiel@vanguardiasur.com.ar |
|---|---|
| State | Accepted |
| Headers | show |
Dear Ezequiel Garcia, On Sun, 26 Oct 2014 16:34:39 -0300, Ezequiel Garcia wrote: > +Instead of trying to fix the macro, let's fix the real issue here, > +and remove -Werror. I actually think the real problem should also be fixed :) Thomas
Dear Ezequiel Garcia, On Sun, 26 Oct 2014 16:34:39 -0300, Ezequiel Garcia wrote: > Add patch to remove -Werror and avoid build errors because of warnings. > > Fixes: http://autobuild.buildroot.net/results/6935e1107d832e5678c8742239eccd89d4abed47/ > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > -- > Sent upstream: https://github.com/HardySimpson/zlog/pull/68 > --- > ...ove-Werror-and-avoid-build-failures-becau.patch | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 package/zlog/zlog-02-compile-Remove-Werror-and-avoid-build-failures-becau.patch Applied, thanks. Thomas
On 10/26/2014 05:52 PM, Thomas Petazzoni wrote: > Dear Ezequiel Garcia, > > On Sun, 26 Oct 2014 16:34:39 -0300, Ezequiel Garcia wrote: > >> +Instead of trying to fix the macro, let's fix the real issue here, >> +and remove -Werror. > > I actually think the real problem should also be fixed :) > But which is the real problem: the BSD_SOURCE macro usage or the warning in the toolchain? Other architectures are not producing any warning, so this sounds like yet another issue with the toolchain.
Dear Ezequiel Garcia, On Sun, 26 Oct 2014 23:44:58 -0300, Ezequiel Garcia wrote: > But which is the real problem: the BSD_SOURCE macro usage or the warning > in the toolchain? The BSD_SOURCE macro usage. > Other architectures are not producing any warning, so this sounds like > yet another issue with the toolchain. That's because NIOS II is for now the only toolchain using glibc 2.20, which has deprecated certain macros. Packages should be converted, as such warnings will also appear with other toolchain as they start using glibc 2.20. See commit 116733c6c211f49d7ba5fff5883f682eb72106a3 for instance. Best regards, Thomas
On 10/27/2014 04:02 AM, Thomas Petazzoni wrote: > Dear Ezequiel Garcia, > > On Sun, 26 Oct 2014 23:44:58 -0300, Ezequiel Garcia wrote: > >> But which is the real problem: the BSD_SOURCE macro usage or the warning >> in the toolchain? > > The BSD_SOURCE macro usage. > >> Other architectures are not producing any warning, so this sounds like >> yet another issue with the toolchain. > > That's because NIOS II is for now the only toolchain using glibc 2.20, > which has deprecated certain macros. Packages should be converted, as > such warnings will also appear with other toolchain as they start using > glibc 2.20. > > See commit 116733c6c211f49d7ba5fff5883f682eb72106a3 for instance. > Great, thanks. I hadn't noticed you fixed a similar thing before.
diff --git a/package/zlog/zlog-02-compile-Remove-Werror-and-avoid-build-failures-becau.patch b/package/zlog/zlog-02-compile-Remove-Werror-and-avoid-build-failures-becau.patch new file mode 100644 index 0000000..0f1b912 --- /dev/null +++ b/package/zlog/zlog-02-compile-Remove-Werror-and-avoid-build-failures-becau.patch @@ -0,0 +1,38 @@ +From 4a08c9e07fa8b7a1d6a76b927ea97e3eaa784845 Mon Sep 17 00:00:00 2001 +From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> +Date: Sun, 26 Oct 2014 16:16:25 -0300 +Subject: [PATCH] compile: Remove -Werror and avoid build failures because of + warnings + +Using -Werror on production is a bad idea, as otherwise harmless warnings +get treated as errors breaking builds. This is currently the case with +Nios-II architecture toolchain, warning about a deprecated macro: + +../usr/nios2-buildroot-linux-gnu/sysroot/usr/include/features.h:148:3: +error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp] + # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" + +Instead of trying to fix the macro, let's fix the real issue here, +and remove -Werror. + +Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> +--- + src/makefile | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/makefile b/src/makefile +index 294dc08..4ac4c43 100644 +--- a/src/makefile ++++ b/src/makefile +@@ -32,7 +32,7 @@ ZLOG_MINOR=2 + # Fallback to gcc when $CC is not in $PATH. + CC:=$(shell sh -c 'type $(CC) >/dev/null 2>/dev/null && echo $(CC) || echo gcc') + OPTIMIZATION?=-O2 +-WARNINGS=-Wall -Werror -Wstrict-prototypes -fwrapv ++WARNINGS=-Wall -Wstrict-prototypes -fwrapv + DEBUG?= -g -ggdb + REAL_CFLAGS=$(OPTIMIZATION) -fPIC -pthread $(CFLAGS) $(WARNINGS) $(DEBUG) + REAL_LDFLAGS=$(LDFLAGS) -pthread +-- +2.1.0 +
Add patch to remove -Werror and avoid build errors because of warnings. Fixes: http://autobuild.buildroot.net/results/6935e1107d832e5678c8742239eccd89d4abed47/ Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> -- Sent upstream: https://github.com/HardySimpson/zlog/pull/68 --- ...ove-Werror-and-avoid-build-failures-becau.patch | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 package/zlog/zlog-02-compile-Remove-Werror-and-avoid-build-failures-becau.patch